[HOLD for payment 2023-10-25] [$1000] "This is the beginning of ..." message shows up on LHN of a new chat for a deleted thread instead of [message deleted]

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Post a new message in a new chat with no history (i.e. PARENT MESSAGE) and reply in thread (i.e. CHILD MESSAGE)
2. Go back to the chat and delete the new message (i.e. PARENT MESSAGE)
3. Notice the LHN does not say [message deleted], even though the chat states this

Expected Result:

In the LHN for a PARENT MESSAGE, [message deleted] should show instead of "This is the beginning of..." for

Actual Result:

In the LHN for a new chat with a deleted PARENT MESSAGE, we see "This is the beginning of..."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-05-22.15.26.36.mp4

Recording.2860.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684758578526459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018360917605fa9833
• Upwork Job ID: 1663327696563245056
• Last Price Increase: 2023-09-22
• Automatic offers:
• rojiphil | Contributor | 26910081
• Nathan-Mulugeta | Reporter | 26910082

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

I can repro this on v1.3.18-2 (prod) and Staging.

On a chat with history, the deleted thread doesn't show in the LHN:

On a new chat without history, I see ___fake___ briefly, then the "This is the beginning" message:

[jliexpensify]

Confirming what message should show: https://expensify.slack.com/archives/C049HHMV9SM/p1685235997879309?thread_ts=1684758578.526459&cid=C049HHMV9SM

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018360917605fa9833

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jliexpensify]

@rushatgabhane @puneetlath - it looks like another contributor has proposed the solution to this issue on another GH

[jliexpensify]

If the solution in the other GH is the same/fixes this issue, then I think we should close this out and pay @Nathan-Mulugeta for reporting.

[rushatgabhane]

@dukenv0307 thanks for your proposal! I agree with the root cause.

[dukenv0307]

@rushatgabhane I just updated a bit to be able to translate this text [message deleted] to Spanish. What do you think about my solution

[rushatgabhane]

@dukenv0307 when a parent message is deleted, it's still present in reportActions and it has this flag set as true - isDeletedParentAction: true.

Could we use this information in any way to determine if it's a parent message?

[rushatgabhane]

Optional, I also suggest we will not update lastVisibleActionCreated

@dukenv0307 could you please explain why?

[dukenv0307]

Optional, I also suggest we will not update lastVisibleActionCreated

@rushatgabhane Because we will not hide deleted messages, [message deleted] will display instead of deleted message. The user still see [message deleted] so I think the lastVisibleActionCreated should be the last message that the user can see in the chat
Note: As in the code, lastVisibleActionCreated field is used to check isUnread and sort report in LHN

[dukenv0307]

when a parent message is deleted, it's still present in reportActions and it has this flag set as true - isDeletedParentAction: true.

Could we use this information in any way to determine if it's a parent message?

@rushatgabhane Thanks for your comment. But this field is responded from BE after API success. So when building optimistic data for DeleteComment API, we will not receive this field

[hoangzinh]

If we hard set optimisticReport.lastMessageText = Localize.translateLocal('parentReportAction.deletedMessage') to chatReport, it leads to another bug that when user changes language after that, the [Deleted message] is translated in chatReport view, but in LHN, we still see [message deleted]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Deleted message] in LHN subtitle #28364

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment offer (Contributor)
• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment
• @Nathan-Mulugeta requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary - this job is really messy so please weigh in and let me know if you have thoughts/anything's incorrect!

• Bug Reporter: @Nathan-Mulugeta $250
• Contributor: @rojiphil $1500 - see comment
• C+: @rushatgabhane $1000 (New.Dot)

Upworks job

It looks like PR #28364 took 14 days to merge - normally we'd cancel payment but it looks like even as the PR was happening, there was still a lot of debate. @chiragsalian what are you thoughts? Should we keep payment at $1000?

Also @dukenv0307 was assigned early onwards but didn't submit a PR to resolve this issue, right?

[rojiphil]

It looks like PR #28364 took 14 days to merge - normally we'd cancel payment but it looks like even as the PR was happening, there was still a lot of debate. @chiragsalian what are you thoughts? Should we keep payment at $1000?

@chiragsalian @rushatgabhane

Considering that there was a gap of about 7 days (this minus this) when @rushatgabhane was not available to work on this issue, can we consider the total time taken to work on this issue as 7 days [14 - 7(gap)]?

Further, there was one extended fix added here in the same PR.
So, would it be reasonable to consider $1500 [i.e. $1000(this fix) + $500(extended fix)] as compensation here?

In addition, there is another extended fix mentioned here. I am fine to include this extended fix too within the compensation of $1500 as mentioned above.
Does this overall approach sound fair?

[chiragsalian]

can we consider the total time taken to work on this issue as 7 days [https://github.com//issues/19722#issuecomment-1767066579 - 7(gap)]?

Yeah I'm fine with that.

Yeah i think 1500 is fair for your work here.

[jliexpensify]

Great thanks @chiragsalian - will adjust the payments and make a new Upworks job.

[Nathan-Mulugeta]

There is one other job open on upwork with this issue linked, it would be great if you close that one after processing payment for this issue as well, @jliexpensify

[jliexpensify]

Hmm can you link me the Upworks link @Nathan-Mulugeta ? I looked at the links in this GH and the jobs were all closed. Cheers!

[Nathan-Mulugeta]

I couldn't find a way to copy the link of an already hired contract from upwork.

[jliexpensify]

Is it a closed job though? Because what I'm finding is that Upworks randomly closes jobs after a month of inactivity (even if people are hired) which means we need to create new ones. There isn't an option to "re-open" a job.

[Nathan-Mulugeta]

It is not closed yet, it was open on Sep 27, so I think we can wait until it gets closed by upwork.

[rojiphil]

@jliexpensify
Just checked in my Upwork account and noticed a duplicate offer for me.
I have just sent a message via Upwork.
You can close that one.

[rojiphil]

@jliexpensify Just checked in my Upwork account and noticed a duplicate offer for me. I have just sent a message via Upwork. You can close that one.

Here is the link. Hope this helps

[jliexpensify]

Right @rojiphil and @Nathan-Mulugeta this is a closed job in Upworks:

I also don't have an option to cancel these contracts, since it's closed:

[jliexpensify]

@Nathan-Mulugeta Can you help me understand what the issue is if there's an outstanding contract on a closed job? Does it affect your Upworks score or something?

You're the first Contributor who has reached out to me regarding this, so I want to understand what the issue is.

[jliexpensify]

Also bumping @rushatgabhane to complete the checklist!

[Nathan-Mulugeta]

Hey @jliexpensify the upwork Job that I was referring to is not the one you linked. I'll attach a screenshot of it below. But having an outstanding contract which upwork automatically closes might have an impact on the JSS (Job success score) of that account, but the impact might be low so we can ignore it. I just asked if it was possible for you to close it out before it manually gets closed.

The job is this one:

[jliexpensify]

It looks like this is the Upworks job:

I'm a day ahead in Australia, so that's why it's showing as the 28th in the screenshot.

However, this job is closed, and I can't re-open it - that's why I had to make a new job. This seems like a super annoying quirk of Upworks, so I'll surface this with our team to see if we can disable the auto-close!

[jliexpensify]

Just circling back here @Nathan-Mulugeta and @rojiphil - I raised this with our team and someone discovered a workaround: anytime before the 4-week period is up, you can manually edit one letter in the Upworks description to extend the contract another 4 weeks. So Jack is going to look into a way to automatically edit these Upworks jobs before the 4 week period.

[jliexpensify]

Paying now based off this summary.

[jliexpensify]

Paid and job closed!

[rojiphil]

Received the payment. Thanks @jliexpensify