[HOLD for payment 2023-06-29] [$1000] mWeb - LHN - Huge selection appears when pinning a chat by holding down

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com on IOS/Chrome
2. Log in with any account
3. Pinn the chat by holding down

Expected Result:

Huge selection does not appear when pinning a chat by holding down

Actual Result:

Huge selection appears when pinning a chat by holding down

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Chrome
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.3.25.8

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1686233864.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc286f7e3c9684a5
• Upwork Job ID: 1667218616558620672
• Last Price Increase: 2023-06-16

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[honnamkuan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user is on mobile Chrome browser and long press on chat row to bring up “Pin” context menu, the large text block get selected along with mobile OS default context menu being shown (e.g. Copy / Select All / Find Selection for IOS)
Note: Part of the issue where IOS default context menu being shown id also reproducible using IOS Safari mobile browser.

What is the root cause of that problem?

We are missing userSelectNone styling for sidebar, that is why the text elements are getting selected upon long press in mobile web.

What changes do you think we should make in order to solve the problem?

While it might makes sense to allow text selection on desktop web, we should not allow it for mobile web as it interfere with the long press "Pin" context menu behaviour.

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js

Lines 49 to 51 in 82ce35f

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.sidebar]}

We can fix this behaviour by adding styling styles.userSelectNone only when page is accessed using mobile browser

style={[styles.sidebar, Browser.isMobile() ? styles.userSelectNone : {}]}

What alternative solutions did you explore? (Optional)

Alternatively, we can choose to add identical styling changes to

App/src/pages/home/sidebar/SidebarLinks.js

Lines 213 to 214 in 82ce35f

	<LHNOptionsList
	contentContainerStyles={[styles.sidebarListContainer, {paddingBottom: StyleUtils.getSafeAreaMargins(this.props.insets).marginBottom}]}

instead, the difference is this approach would only makes the chat list no selectable, whereas the solution proposed above will cover the header line as well, I believe the environment badges (e.g. DEV, STG) should not be selectable on mobile web as well, hence my proposal to apply the change at BaseSidebarScreen.js

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dc286f7e3c9684a5

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[johncschuster]

Not overdue. This was assigned before the weekend.

[honnamkuan]

@eVoloshchak would like to mention that I have added my proposal above for your review.
Thanks

[honnamkuan]

Updated my proposal #20470 (comment)
to use Browser.isMobile() instead of this.props.isSmallScreenWidth to determine mobile browser scenario.

[johncschuster]

@eVoloshchak can you take a look at the updated proposal? Thanks!

[eVoloshchak]

I think we should proceed with @honnamkuan's proposal
Simple and straightforward

We can fix this behaviour by adding styling styles.userSelectNone only when page is accessed using mobile browser

🎀👀🎀 C+ reviewed!
cc: @neil-marcellini

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[neil-marcellini]

I like the proposal too and I'll hire him, but I do think we'll need some more changes in the PR because when I tested there was still a slight outline.

[melvin-bot]

📣 @honnamkuan You have been assigned to this job by @neil-marcellini!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[honnamkuan]

Thank you, I have applied for the job in Upwork.

The slight outline mentioned in #20470 (comment) seems to me is being shown for web accessibility and not a selection issue.

I will spend some time to investigate and confirm on it before raising a PR.

[neil-marcellini]

Thanks for the great investigation and explanation @honnamkuan! I agree that it's ok if there is still a slight outline, at least we are improving it substantially.

Also @eVoloshchak yes let's make sure there is an issue for this, or create one if needed, mostly so that it doesn't get reported multiple times. Maybe one of us can fix Webkit 😛?

[melvin-bot]

🎯 ⚡️ Woah @eVoloshchak / @honnamkuan, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @honnamkuan got assigned: 2023-06-16 21:37:15 Z
• when the PR got merged: 2023-06-20 17:03:38 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• disable chat list user select on mobile web #21042

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - Applause
• Contributor that fixed the issue - @honnamkuan
• Contributor+ that helped on the issue and/or PR - @eVoloshchak

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eVoloshchak]

Also @eVoloshchak yes let's make sure there is an issue for this, or create one if needed, mostly so that it doesn't get reported multiple times. Maybe one of us can fix Webkit 😛?

Can't find an issue for this, so reported it in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1687457056485909

[johncschuster]

@honnamkuan I've sent the offer to hire you on Upwork. Please let me know when you've accepted that!

@eVoloshchak can you apply to the job in Upwork when you get a moment? Thanks!

[honnamkuan]

@johncschuster I’ve accepted the offer. Thank you!

[eVoloshchak]

• The PR that introduced the bug has been identified: I'm not able to pinpoint the exact PR that caused this, this was implemented initially, but we didn't have the "long press on thread" functionality, so it got surfaced only now

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a simple visual bug, I don't think additional discussion is necessary here

• Determine if we should create a regression test for this bug. It's very easy to test and it's related to a common action (pinning a thread), I think we could create a small regression test

[eVoloshchak]

Regression Test Proposal

Action Performed:

1. Login with any account (mobile only)
2. Pin any chat by holding down
3. Verify that there is no selection covering the whole screen

Do we agree 👍 or 👎

[eVoloshchak]

@eVoloshchak can you apply to the job in Upwork when you get a moment? Thanks!

@johncschuster, I'll request the payment via NewDot instead, need just a couple of days for the first payment to clear

[neil-marcellini]

Not overdue

[johncschuster]

Quick summary:

• @eVoloshchak will request payment via NewDot
• @honnamkuan needs to be paid via Upwork (I will get that taken care of shortly)
• Regression test issue needs to be created and linked

Working on that now

[johncschuster]

Payment has been issued to @honnamkuan

[eVoloshchak]

Requested the payment via NewDot

[eVoloshchak]

Not overdue, this can be closed