[HOLD for payment 2023-07-17] [$1000] [mWeb-safari] topbar color is different in LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. open App
2. check the top bar of LHN

Expected Result:

top bar colour should not be different

Actual Result:

top bar colour is different

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685961858016909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b4f1a55f600d32fe
• Upwork Job ID: 1667192033642819584
• Last Price Increase: 2023-06-09

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

Nice, thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b4f1a55f600d32fe

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MrJithil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb user seeing a different darker topbar color on iOS safari browser.

What is the root cause of that problem?

theme-color meta info on head of the html causing this issue. Currently, the theme-color meta being rendered as

<meta name="theme-color" content="#061B09">

What changes do you think we should make in order to solve the problem?

The theme-color meta should be set to colors.highlightBG in the area where we altering the color only for mWeb.

In short,

        StatusBar.setBackgroundColor(themeColors.appBG);

should be changed to

            StatusBar.setBackgroundColor(themeColors.highlightBG);

in the CustomStatusBar component

Evidence iOS:

Evidence Android:

What alternative solutions did you explore? (Optional)

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - topbar color is different.

What is the root cause of that problem?

Currently themeColors.appBG is applied to StatusBar. even if we change it highlightBG. it will not solve our problem.

App/src/components/CustomStatusBar/index.js

Line 8 in 489d83b

StatusBar.setBackgroundColor(themeColors.appBG);

As different pages showing different status bar color currently in native.

What changes do you think we should make in order to solve the problem?

Firstly we need to update MODAL file.
before applying new color to statusbar. we need current color of status bar so we can revert back while hiding modal. we can add state variable for that.
and before apply new color we can save old color in state.

 const showModal = () => {
    setLastStatusBarColor(StatusBar.getBackgroundColor()) // old color
    setStatusBarColor(StyleUtils.getThemeBackgroundColor());
    props.onModalShow();
};
// restore old color on modal hide.
 const hideModal = () => {
        setStatusBarColor(lastStatusBarColor);
        props.onModalHide();
};

We need to update few components to get richer experience.

• We need to add useFocusEffect into SideBarScreen to update StatusBar color back to sidebar color.

useFocusEffect(()=>{
    StatusBar.setBackgroundColor(themeColors.sidebar);
})

• We need to add StatusBar.setBackgroundColor(themeColors.appBG) on componentDidMount of ReportScreen.

• We need to add useEffect into RightModalNavigator to update StatusBarColor to appBG.

Result

Android

android.mp4

Ios

Simulator.Screen.Recording.-.iPhone.14.-.2023-06-12.at.02.43.51.mov

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[MrJithil]

Updated the proposal #20516 (comment) , because the way we set meta[name=theme-color] has been changed as part of the PR-20436 after my initial proposal.

[conorpendergrast]

Proposals are coming in and waiting for review by @thesahindia

[thesahindia]

This solution will work but I am wondering if we can fix this in a more simpler way. I would prefer getting some thoughts from @Julesssss about the solution, because I think they have worked the most at similar issues.

Also TBH I don't think this is worth fixing, I haven't seen any mWeb application dynamically changing the color of the address bar/ top bar

[pecanoro]

Yeah, I rarely saw websites with this working, I had to try at least 10 until I found one (I think it was snapchat). @Julesssss Do you think this is worth fixing?

[Julesssss]

This is something that we fixed on Android, but I think each platform where this occurs might require a native solution. I think the decision to fix this or not depends on the complexity of the solution. I could go either way, but probably not if the solution touches other platforms.

[MrJithil]

function CustomStatusBar() {
    useEffect(() => {
        StatusBar.setBarStyle('light-content', true);
        // StatusBar.setBackgroundColor(themeColors.appBG);
       StatusBar.setBackgroundColor(themeColors.highlightBG);
    }, []);
    return <StatusBar />;
}

If are altering this line, its likely not to impact other places than a mobile web as it is modifying the meta information.

proposal here: #20516 (comment)

[pecanoro]

@thesahindia What do you think about the proposals?

[thesahindia]

@kushu7's proposal will do the job.

C+ reviewed 🎀👀🎀

[allroundexperts]

We don’t pay until 7 days after the new PR is deployed to production

@conorpendergrast weren't 7 days elapsed when this was discovered?

[situchan]

It seems first discovered on June 22 and GH created on Jun 28, while PR deployed to production on Jun 22

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @kushu7 got assigned: 2023-06-14 20:33:34 Z
• when the PR got merged: 2023-07-06 00:02:21 UTC
• days elapsed: 15

On to the next one 🚀

[melvin-bot]

@conorpendergrast, @pecanoro, @allroundexperts, @kushu7 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• revert usage of InteractionManager in Modal #21865

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[pecanoro]

@allroundexperts friendly bump for the list above
@conorpendergrast friendly bump for the payments

🤗

[conorpendergrast]

Nice, thanks Roccio. I'll get that paid today

[conorpendergrast]

Huh it should be daily now, weird. Moving to daily for the payments step

[conorpendergrast]

Payments made, with these adjustments.

Once the checklist is done, we can close this out

[allroundexperts]

@pecanoro This was more of a feature request than a bug in my opinion. As a result, the checklist isn't really needed here. Let me know if you'd disagree.

[conorpendergrast]

That works for me 👍

[anmurali]

Approved $500 @allroundexperts based on #20516 (comment)

[conorpendergrast]

@anmurali @allroundexperts I think we double-paid Sibtain for this. He was already paid via Upwork

[conorpendergrast]

I think the easiest approach is probably that I request a refund via Upwork. Unless I hear otherwise, I'll do that

[allroundexperts]

I think the easiest approach is probably that I request a refund via Upwork. Unless I hear otherwise, I'll do that

My mistake. I did not realise that I was paid at Upwork. Please send me a refund request and I'll approve straightaway!

[conorpendergrast]

Nope, my mistake. The Upwork hire was created before we had ND payments, and I didn't double-check before paying. Refund request sent, thank you!

[allroundexperts]

Approved!

[conorpendergrast]

Great, confirmed. Thank you!