Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Bank Account - Checkbox is checked after returning to previous stage #20950

Closed
4 of 6 tasks
lanitochka17 opened this issue Jun 16, 2023 · 5 comments
Closed
4 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue foung when executing PR #20193

Action Performed:

  1. Open http://staging.new.expensify.com/
  2. Log into a new account
  3. Navigate to Workspace > Bank Account
  4. Click on "Connect manually"
  5. Insert the routing number 011401533 and account number 1111222233331111
  6. Check the ToS checkbox
  7. Click on "Continue"
  8. Click "Back" to return to previous stage
  9. Click on "Continue"
  10. Fill in the Company information
  11. Check the "restricted business" checkbox
  12. Click on "Save & Continue"
  13. Click "Back" to return to previous stage

Expected Result:

At steps 8 and 13 the checkbox is not checked

Actual Result:

At steps 8 and 13 the checkbox is checked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6096129_Bug.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause -Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 16, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alitoshmatov
Copy link
Contributor

I think you should remove defaultValue and shouldSaveDraft or set them to false

<CheckboxWithLabel
inputID="hasNoConnectionToCannabis"
defaultValue={this.props.getDefaultStateForField('hasNoConnectionToCannabis', false)}
LabelComponent={() => (
<Text>
{`${this.props.translate('companyStep.confirmCompanyIsNot')} `}
<TextLink
// eslint-disable-next-line max-len
href="https://community.expensify.com/discussion/6191/list-of-restricted-businesses"
>
{`${this.props.translate('companyStep.listOfRestrictedBusinesses')}.`}
</TextLink>
</Text>
)}
style={[styles.mt4]}
shouldSaveDraft
/>

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@SofoniasN
Copy link

Hey guys, I hope all is well i reported a similar bug to this a week ago. Here https://expensify.slack.com/archives/C049HHMV9SM/p1686592692164449?thread_ts=1686592692.164449&cid=C049HHMV9SM

@luacmartins
Copy link
Contributor

luacmartins commented Jun 19, 2023

This has been fixed here already - #20091. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants