Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Settings - Dropdown arrow is non functional in dropdown selectors #2122

Closed
isagoico opened this issue Mar 27, 2021 · 15 comments · Fixed by #3200
Closed

Android - Settings - Dropdown arrow is non functional in dropdown selectors #2122

isagoico opened this issue Mar 27, 2021 · 15 comments · Fixed by #3200
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@isagoico
Copy link

isagoico commented Mar 27, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Dropdown menu options should be displayed on tapping the dropdown arrow

Actual Result:

Dropdown arrow nonfunctional, tapping the v does nothing.

Action Performed:

  1. Launch the app and login
  2. Tap on the profile icon to open settings
  3. Tap on profile
  4. Unselect checkbox for Set my time zone
  5. Tap dropdown arrow for Timezone , Preferred pronouns and Priority mode in preferences

Workaround:

User can tap on the left side of the dropdown and it will work

Platform:

Where is this issue confirmed?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.51-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Video

Upwork URL: https://www.upwork.com/jobs/~01ef186547791f24ac

@marcaaron marcaaron added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Mar 31, 2021
@MelvinBot
Copy link

Triggered auto assignment to @mateocole (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Mar 31, 2021
@MelvinBot
Copy link

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mateocole mateocole added the Weekly KSv2 label Apr 19, 2021
@mateocole mateocole removed their assignment Apr 19, 2021
@mateocole mateocole added the Improvement Item broken or needs improvement. label Apr 19, 2021
@cead22 cead22 removed their assignment Apr 19, 2021
@isagoico
Copy link
Author

isagoico commented May 9, 2021

Issue reproducible during today's KI retests

2 similar comments
@isagoico
Copy link
Author

isagoico commented May 17, 2021

Issue reproducible during today's KI retests

@isagoico
Copy link
Author

Issue reproducible during today's KI retests

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label May 24, 2021
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@trjExpensify
Copy link
Contributor

Version Number: 1.0.7-0

👋 @isagoico just to confirm, this is reproducible on the latest v1.0.51-2 Android release right? (the screenshot in the OP looks old as it doesn't have the phone number field).

In the meantime, I'm going to add the external label to get this prepped for Upwork.

@trjExpensify
Copy link
Contributor

Voila, what are the chances! Let me know about the above and I'll get it over to Upwork. A fresh Android screenshot would be awesome too if you could.

@isagoico
Copy link
Author

isagoico commented May 24, 2021

Yep! I was able to reproduce the issue on Android build 1.0.51-2 with the same steps.

@MelvinBot
Copy link

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@trjExpensify trjExpensify removed the Weekly KSv2 label May 25, 2021
@vtkmbiz
Copy link

vtkmbiz commented May 25, 2021

The proposed solution for this bug would be just to change some RN component which are connected to the dropdown menu and change some function or style.

@aliabbasmalik8
Copy link
Contributor

aliabbasmalik8 commented May 26, 2021

PROPOSAL
We need to pass fixAndroidTouchableBug props to component RNPickerSelect at this point
https://github.com/Expensify/Expensify.cash/blob/0d5be8275b6f50054867b9e2f0a7a30a6db95492/src/components/Picker/index.js#L17

NOTE: This solution already mentioned in component documentation https://www.npmjs.com/package/react-native-picker-select
Thanks

@roryabraham
Copy link
Contributor

That's funny ... hopefully that fixAndroidTouchableBug prop is temporary and the maintainers decide to merge a long-term solution which doesn't require a separate prop that literally says "yes I want this bug" or "no I don't want this bug"...

But good find @aliabbasmalik8! Feel free to submit a pull request once you've been hired on Upwork!

@trjExpensify feel free to hire @aliabbasmalik8 on Upwork 👍

@trjExpensify
Copy link
Contributor

Thanks, @aliabbasmalik8. Hired! 👍

@isagoico
Copy link
Author

Issue reproducible today during KI retests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants