Deploy Checklist: Expensify.cash 2021-03-19

[OSBotify]

Release Version: 1.0.16-0
Compare Changes: 1.0.15-0...1.0.16-0

This release contains changes from the following pull requests:

• refactor CreateMenu to have dynamic items #1548
• Only use image thumbnail instead of full sized profile image #1568
• Added Tooltips to the report users' titles.  #1632
• Update profilePage to include timezone #1717
• Colorize git #1726
• [User Settings] Add new Profile view #1767
• Remove slack notifications for QA #1776
• Persist IOU data in Onyx #1785
• Prevent sleep timer from running on native platforms #1786
• Add accountID to the set password link #1857
• Update CONTRIBUTING.md #1862
• Add Video Call Chat Links #1878
• Update internal dev partnerID and password #1893
• Update version to 1.0.2-92 on master #1922
• Check for unvalidated accounts and change in password flow #1929
• Rename profile page to details page #1931
• Skip mobile staging deploys for production releases #1932
• Create lockDeploys workflow #1938
• Add link to issue template to enforce linking back to Expensify/Expensify if relevant  #1939
• Fix race condition with automerge and lockDeploys workflow #1945
• [E.cash] - Updated Lodash Dependency to Fix Vulnerability #1947
• Move ReportActionContextMenu up for grouped ReportActionItems #1948
• Fix automerge race condition again #1952
• Update fastlane to 2.178 #1953
• Skip staging deploy if StagingDeployCash is locked #1959
• Fix modal closing animation on web/desktop #1960
• Update User_UploadAvatar to take in a file instead of a base64 image #1966
• Introduce translations and translate library for internationalization #1969
• Add terms to signin/settings pages #1971
• [No QA] Update expensify-common hash #1972
• Update app modal design refactor #1973
• Hax contributor updates #1974
• fixed Sidebar theme #1979
• Temporarily hide incomplete IOU modal #1981
• Remove flag that is causing iOS to fail to upload #1984
• Update Onyx version #1994
• Due to Fastlane error, skip beta rollout temporarily #1995
• Fix width of report header on mobile web #2001
• Fixed moving cursor to end problem except IOUAmountPage #2010
• [No QA] Ensure automerge PRs are not included in StagingDeployCash #2020
• Make iOS update commands run in sequence instead of all at once #2024
• make terms smaller on sign in page #2026
• Focus compose box when LHN report clicked #2032
• Update issue template to include slack invite email #2033
• Ensure we're always including timezone in myPersonalDetails #2040
• fixed tooltip shows up on Mobile Web while navigating the reports #2044
• Focus compose box when navigate away from RHN #2050
• Setup deep links for iOS / Android #2052
• Tooltip modifications #2056
• Deploy Android, Web and Desktop to staging and production #2060
• Create separate build configuration for staging #2064
• Update appstore profile #2081
• Add ability to zoom images on web/desktop #2085
• Merge all IOU data in one swoop #2086
• [No QA] Add QA steps to the pull request template #2091
• Updating ecash referer #2093
• Add IOU badge to report row and header #2095
• Fix missing avatars #2099
• Fix Mobile Web Scrolling in OptionsList #2101
• fix-new-chat #2103
• Fix issue where IOUAction causes crash in empty chat #2110
• Fix: Modal closes immediately after launch #2114
• Remove timezone migration #2115
• Add image view container style #2134
• [No QA] Add new style rule for refs in constructor #2143
• Update expensify-common hash #2144
• Padding issue on Chat rows. #2158
• [User Settings] Allow users to add secondary logins #2169
• Fix sign in page styles #2192
• [No QA] Schema Validation for Github Actions #2197
• [No QA] DRY up menu item styles #2232
• [No QA] Remove the ReportActionContextMenu beta #2234
• Initialize current user's personal details when personalDetailsList is non empty and they can't be found #2250
• Update User.fetch to get a valid login list on mobile #2255
• [NO QA] Bump Onyx version #2262
• Revert changes introduced by PR 2183 #2267
• Change GSD to focus #2273

Deploy Blockers:

• Focus compose box when LHN report clicked #2032
• Group creation - Not enough space between circle and edge #2123
• Group Creation - Message that you reached the max participants is not displayed.  #2175
• Web - Email Test - The username on the left hand navigation isn't displayed bold when a new message arrives #2177
• Android - Chat - Tapping plus opens chat instead of new or group chat options #2207
• Chat - Blank LHN with keypad opens when login #2236
• Android - Profile - Blank page is displayed when accessing profile settings #2253
• Web - Login - Blank white screen after login #2278

cc @Expensify/applauseleads

[isagoico]

#1548 cannot be tested because of #1981 (which was a pass) Not sure if it can be checked off @Julesssss or @thienlnam can you guys confirm which is the intended behaviour?

[isagoico]

#2032 (comment) Not sure if deploy blocker. Issue is not reproducible in Android devices.

#1948 (comment)

#2010 (comment) - Tested and checked off!

#2040 (comment)

Looks like #2086 was not deployed to staging . It was added to the deploy list after the lock label was applied. Not sure if we should check it off (also looks like internal QA) CC @marcaaron

[Julesssss]

#1548 cannot be tested because of #1981 (which was a pass) Not sure if it can be checked off @Julesssss or @thienlnam can you guys confirm which is the intended behaviour?

Hi @isagoico. No need to test #1548, as its test steps were made redundant.

[Julesssss]

I've also commented in #2010 with testing steps. (it's listed twice here, was that a duplication, or is there supposed to be a 4th issue in the list?)

[isagoico]

Thank a lot ! there was a link missing indeed and I just duplicated the #2010 🤦

[roryabraham]

Looks like #2086 was not deployed to staging . It was added to the deploy list after the lock label was applied.

This was a bug in the deploy process. So we should proceed without that one for this deploy cycle, and try to remember to retest after our next staging deploy.

[roryabraham]

Working with @NikkiWines to determine if #2040 is a true deploy blocker. Looks like that's our last unchecked box. Other PRs are being erroneously added to the list despite not being deployed to staging, but they should be included in the next StagingDeployCash, so we can just ignore them for now. When the new StagingDeployCash is created alongside the production deploy, then we can double-check to make sure any PRs added to this checklist while it was locked are included in the next checklist.

[roryabraham]

Okay, just a clarification on the process that's happening here:

When the LockCashDeploys label is applied to this issue, it creates a new PATCH version (i.e: bumps from 1.0.6-xx to 1.0.7-0) This is necessary for us to deploy iOS and Android to production. However, on TestFlight that also means that it will be subject to Apple review, and therefore will take ~1 day to deploy. Therefore, on all platforms we should be testing the latest PATCH version (aka 1.0.7-0), but on iOS we'll need to test the highest BUILD version from the previous PATCH version. In this case, that's 1.0.6-5. And in case you're wondering, you can always see a full list of the versions by looking at the Expensify.cash tags here.

As a result, in cases like we had today where there are deploy blockers and we need to remove and re-add the lock label, we won't be able to do staging QA on iOS of the code that was deployed to staging today. So @isagoico that means you can skip iOS staging QA today. We may be able to bypass the Apple review on TestFlight for a small set of people, so hopefully this won't be a problem in the future if we can get you added to that list.

[isagoico]

Summary of today's run:
Both PRs that required QA were a pass 🎉 I went ahead and checked off #2040 too since the fix was a pass. Only unchecked PR is this one is #2086 that following what was said in QA we should assume it passed QA after this run and we can check it off. (@roryabraham please stop me if I'm wrong)

Issues found during regression testing:
#2121
#2122
#2123 - Deploy blocker
#2124

[isagoico]

Hello! These PRs seems like internal QA (or just not QAable by applause)

1. Fix issue where IOUAction causes crash in empty chat #2110 CC @Julesssss
2. Merge all IOU data in one swoop #2086 CC @marcaaron
3. Add IOU badge to report row and header #2095 CC @marcaaron

[marcaaron]

Hmm it should be testable, but not very obvious so I can test it myself. The two issues are also using more or less the same testing steps.

[marcaaron]

Ah actually I can't see any clear way to test it besides modifying local JS in Web-E. But I did get it working on web staging so I think we can check them off.

[isagoico]

Chat Regressions and PRs are finished!
Issues found:

1. iOS/Android - Profile page does not scroll  #2147
2. Android - Profile - "Save" button overlaps on the self select pronouns field #2149
3. [HOLD] Going back to main list after keyboard call won't close keypad #2150

PRs are finished too, no comments added.

[isagoico]

@roryabraham Regression is done! iOS build in TF was the same as yesterday (1.0.7-0) so we holded on executing the regression on that one. Let me know if we should execute either way.

[roryabraham]

Nope, for the time being that's the plan! No need to perform regression testing twice on the same app version.

[isagoico]

Regression is finished!
3 issues found today:

1. Group Creation - Message that you reached the max participants is not displayed.  #2175 - Deploy Blocker
2. Web - Email Test - The username on the left hand navigation isn't displayed bold when a new message arrives #2177
3. Android - No notifications are received when app is in the background #2184 - Deploy Blocker

• iOS in TF is still on build 1.0.7-0 so we skipped regression on this round. Hopefully TF is all set up for tomorrow so we can resume iOS testing 🤞

Today's PRs were all a pass 🎉

@Julesssss there's this PR #2110 that I think it's internal QA. Can you confirm?

Removing the lock label.

[Julesssss]

Hi @isagoico. Yeah that can be tested internally as the test steps are a bit tricky currently.

[marcaaron]

Fix for 2175 in review now #2189

[isagoico]

Regression is finished!
1 issue found:

1. Android - Chat - Tapping plus opens chat instead of new or group chat options #2207 - Deploy blockers

PRs are finished too.
2 comments added:

1. Add Video Call Chat Links #1878 (comment) - Checking it off.
2. Fix sign in page styles #2192 (comment)

[isagoico]

Regression is finished!
2 issues found:

1. Chat - Sent message is hidden for the Group Chat when we use the GSD mode #2235
2. Chat - Blank LHN with keypad opens when login #2236

PRs were a pass! 🎉

[isagoico]

Regression is finished!
3 issues found today:

1. Chat - Unable to send message from newly created account #2247
2. Chat - Unable to create a new account with gmail, stuck in "Resend link" loop #2248
3. Android - Profile - Blank page is displayed when accessing profile settings #2253

PRs are finished too:
4 comments added:

• Fix: Modal closes immediately after launch #2114 (comment)
• Fix: Modal closes immediately after launch #2114 (comment)
• Fix: Modal closes immediately after launch #2114 (comment)
• [User Settings] Allow users to add secondary logins #2169 (comment)

[isagoico]

We have been able to reproduce this issue several times and in different devices during regression 1.0.1-15 https://github.com/Expensify/Expensify/issues/157735. It's not consistently reproducible.

[isagoico]

Regression is finished!
3 issues found today:

1. Web - Login - Blank white screen after login #2278 - Possible deploy blocker (?)
2. iOS/Android - Message - Copy message menu is not displayed when pressing on the message #2279
3. Android - Chat - Recent users displayed without user's name #2280

PRs are finished too!
No comments added 🎉

#2110 was going to be tested internally CC @Julesssss
#2050 is missing testing steps