-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge all IOU data in one swoop #2086
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julesssss
reviewed
Mar 25, 2021
Julesssss
reviewed
Mar 25, 2021
I think this is good to go now @AndrewGable |
AndrewGable
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Julesssss
Details
Cleaning up the report IOU fetching logic so that we can use mergeCollection on the report and report ious that we get back. Eventually we should make the server send this information, but this should work OK for now. I'm not really following how to use curl to set up the IOUs. But the PR should work for adding this to the report data I think.
Not sure if there is another issue to handle the realtime event pusher event, but not including it here.
Fixed Issues (Partial / Clean Up)
https://github.com/Expensify/Expensify/issues/158424
Tests
hasOutstandingIOU
&iouReportID
fields in the Onyx data for the reporthasOutstandingIOU=false
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android