Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge all IOU data in one swoop #2086

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Mar 25, 2021

cc @Julesssss

Details

Cleaning up the report IOU fetching logic so that we can use mergeCollection on the report and report ious that we get back. Eventually we should make the server send this information, but this should work OK for now. I'm not really following how to use curl to set up the IOUs. But the PR should work for adding this to the report data I think.

Not sure if there is another issue to handle the realtime event pusher event, but not including it here.

Fixed Issues (Partial / Clean Up)

https://github.com/Expensify/Expensify/issues/158424

Tests

  1. Create a new IOU transaction via
CreateIOUTransaction
authToken: <auth token>
debtorEmail: <email of user you want to request payment from>
currency: USD
comment: 'test'
amount: 299
  1. Open E.cash as the user (same authToken that you just used)
  2. Verify that there is a hasOutstandingIOU & iouReportID fields in the Onyx data for the report
    Screen Shot 2021-03-25 at 12 51 20 PM
  3. Run the next command to mark it as paid
PayIOU
authToken: <auth token of the payee> // must sign in as the "debtor"
reportID: <IOU Report ID> 
paymentMethodType: 'Venmo'
  1. Refresh the page
  2. Verify that the report data shows hasOutstandingIOU=false
    Screen Shot 2021-03-25 at 12 58 35 PM

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Mar 25, 2021
@marcaaron marcaaron marked this pull request as ready for review March 25, 2021 20:03
@marcaaron marcaaron requested a review from a team as a code owner March 25, 2021 20:03
@marcaaron marcaaron removed the request for review from a team March 25, 2021 20:03
@botify botify requested a review from Beamanator March 25, 2021 20:04
@marcaaron
Copy link
Contributor Author

I think this is good to go now @AndrewGable

Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and code looks good!

Screen Shot 2021-03-25 at 5 36 04 PM

Screen Shot 2021-03-25 at 5 38 59 PM

@AndrewGable AndrewGable merged commit 6777860 into master Mar 25, 2021
@AndrewGable AndrewGable deleted the marcaaron-fixMergeCollection branch March 25, 2021 23:40
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants