Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ecash referer #2093

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Updating ecash referer #2093

merged 1 commit into from
Mar 30, 2021

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Mar 25, 2021

On HOLD till https://github.com/Expensify/Web-Expensify/pull/30556 goes live.

Details

Fixed Issues

Helps with https://github.com/Expensify/Web-Expensify/pull/30466#discussion_r599597823

Tests

None. Tested from this PR.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian requested a review from a team as a code owner March 25, 2021 23:40
@botify botify requested review from Gonals and removed request for a team March 25, 2021 23:40
@chiragsalian chiragsalian self-assigned this Mar 26, 2021
@roryabraham
Copy link
Contributor

Don't forget to make sure this works for staging too 😉

@roryabraham
Copy link
Contributor

@chiragsalian explained to me why it won't matter for dev vs staging vs prod:

now the referer is dependent on the URL, but with the change in [this] PR it won't be

@chiragsalian chiragsalian changed the title [HOLD] updating ecash referer Updating ecash referer Mar 29, 2021
@chiragsalian
Copy link
Contributor Author

Off HOLD. Ready for review / merge.

@Gonals Gonals merged commit 4f573cf into master Mar 30, 2021
@Gonals Gonals deleted the chirag-ecash-referer-update branch March 30, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants