Add terms to signin/settings pages #1971
Conversation
puneetlath
changed the title
|
@deetergp this is ready for you! cc @Expensify/design can you double-check that the spacing looks okay? |
| loginTermsText: { | ||
| color: themeColors.textSupporting, | ||
| fontSize: variables.fontSizeSmall, | ||
| lineHeight: 20, |
There was a problem hiding this comment.
Can we try backing this down to 16 and seeing what it feels like?
We also need to include our font family here so that we serve this up in the correct font. Just add fontFamily: fontFamily.GTA, and we should be good.
There was a problem hiding this comment.
Yep. Here's what it looks like on web and android.
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,3 @@ | |||
| import TermsOnly from './TermsOnly'; | |||
There was a problem hiding this comment.
NAB: Why aren't we including licenses in desktop?
There was a problem hiding this comment.
It's only a banking requirement on web as explained here: https://github.com/Expensify/Expensify/issues/154672#issue-810980012
|
@megankelso it looks like that copy was written here: https://github.com/Expensify/Expensify/issues/155153 So maybe reopen that issue to see what people think? |
<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>
Details
1. Adds terms of service and privacy policy links to settings modal. 2. Adds terms of service and privacy policy links (only) on mobile apps/desktop 3. Adds terms of service, privacy policy, and licenses links on web/mobile webFixed Issues
Fixes https://github.com/Expensify/Expensify/issues/154672Tests
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android