Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mobile staging deploys for production releases #1932

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Android and iOS staging deploys will invariably fail if the version has already been deployed. Therefore, when creating a production release, we want to make sure we're skipping staging deploys.

Fixed Issues

Failed workflow runs:

Tests

  1. Merge this PR
  2. Close a StagingDeployCash
  3. The iOS and Android deploy workflows should be triggered, but it should not attempt to deploy staging. We should not be pinged in #announce

@roryabraham roryabraham self-assigned this Mar 19, 2021
@roryabraham roryabraham requested a review from a team as a code owner March 19, 2021 18:37
@botify botify requested review from Luke9389 and removed request for a team March 19, 2021 18:38
@AndrewGable
Copy link
Contributor

Looks great!

@AndrewGable AndrewGable merged commit 65f8720 into master Mar 19, 2021
@AndrewGable AndrewGable deleted the Rory-SkipStagingDeploysForReleaseCreated branch March 19, 2021 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
@AndrewGable
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants