fixed Sidebar theme

[parasharrajat]

Please review @marcaaron. As these changes are directly linked to your code.

Details

<SafeAreaInsetsContext.Consumer> does not have styling support but in ScreenWrapper component was passing parent style prop to it. I have moved it to the child View which is working without regression.

Fixed Issues

Fixes #1967

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Before	After

CC @shawnborton

[shawnborton]

Looks good but would love to see screenshots of all of the platforms, especially iOS.

[parasharrajat]

@shawnborton Unfortunately, I don't have IOS. Here are screenshots for other platforms. As per your query, the Statusbar is transparent and its color depends on the screen below.

Desktop

Mobile Web

Android

[parasharrajat]

@Luke9389 Updated.
@shawnborton Any comments on the screenshots above.
Thanks.

[shawnborton]

Let me pull this down and test on iOS for you.

[shawnborton]

Looks good on iOS!

[Luke9389]

@parasharrajat nice work on this PR! Sorry that my reviews may have felt a bit... nit-picky. In the future, please know that if I ask a question on a review, I really don't know the answer. So don't feel like I'm asking you rhetorical questions, or that I'm hinting at something. I'll always be direct 😄. Anyway, good job, and thank you! 🙇‍♂️

[parasharrajat]

@Luke9389. I actually like the nit-picky reviews. it helps in decision-making. Eventually, a review is a kind of second personality's point of view. So tackling all these reviews is making me good at making decisions related to code. I am sure it will help in the long run when we have to work over a lib for developers and not for consumers. 👍

[laurenreidexpensify]

@parasharrajat I will make a plan to get you paid for this PR as a bonus on your next Upwork payment 👍🏽

[parasharrajat]

@laurenreidexpensify Amazing. Thanks

[laurenreidexpensify]

Okay as that was merged on Tues 23 March, will pay you on 30 March as per the 7 day regression test 👍🏽