[No QA] Ensure automerge PRs are not included in StagingDeployCash #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
changed the title
5 tasks
roryabraham
changed the title
|
Okay, no longer on hold. Ready for review |
AndrewGable
approved these changes
Mar 25, 2021
TomatoToaster
approved these changes
Mar 25, 2021
|
Hey @roryabraham, since the testing steps mentioned that you'd start with merging this PR, I figured it'd make sense to wait for you to merge it and test it. Let me know if there's any way I can help with the testing. |
|
Ah yes. Thanks @TomatoToaster, I can test this! Need to wait until the deploy checklist doesn't have the lock label tho 🙃 |
85 tasks
roryabraham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Right now, the StagingDeployCash issue includes version-bump PRs that are auto-generated and auto-merged. These do not need to be included in our QA checklists.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157810
Tests
Added automated tests. To live-test:
StagingDeployCashis updated as part of thepreDeployGithub workflow.StagingDeployCashshould not include any version-bump PRs.