[HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method #21220

kbecciv · 2023-06-21T15:08:11Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings > Profile > Contact method
Press New Contact method > Enter any of your email address
Go to the newly added Contact method and Press Resend magic code 5-6 times until we get the error of the maximum number of attempts
Enter the last magic code from the Email
If the magic code worked and then It will navigate back to the Contact Methods page, and we can see the RBR error beside the newly added email

Expected Result:

If the magic code worked, we should remove the red dot error as we can not access the Enter magic code page, so we can not access/remove the error.

Actual Result:

Magic code worked, and we navigated back to the Contact Methods page, but still, we could see the red dot.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.27-6

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.5070.1.mp4

no-way-to-remove-RBR.1.mov

no-way-remove-RBR.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @jayeshmangwani

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686751798535969

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012abf0b985aa6c54b
Upwork Job ID: 1673362150600179712
Last Price Increase: 2023-06-26

melvin-bot · 2023-06-21T15:08:17Z

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-21T15:08:19Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

kbecciv · 2023-06-21T15:08:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR for the maximum number of attempts of the resend magic code persists after Successfully verifying the magic code

What is the root cause of that problem?

When we press the Resend magic code at that, we time call the requestContactMethodValidateCode method from User.js,

App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

Lines 80 to 81 in f15e6dc

    
           const resendValidateCode = () => { 
        
               User.requestContactMethodValidateCode(props.contactMethod);

if the API return the error then we set the error for validateCodeSent to errorFields in failureData

App/src/libs/actions/User.js

Lines 168 to 170 in a2d074b

    
           errorFields: { 
        
               validateCodeSent: ErrorUtils.getMicroSecondOnyxError('contacts.genericFailureMessages.requestContactMethodValidateCode'), 
        
           },

And when we get an error for validateCodeSent, and we do not clear the error by pressing the cross icon from the RBR, we add the correct magic code. At that time validateCodeSent error does not reset to null, and then we do not show the magic code page. However, the validateCodeSent error value is still there, and we can see the red dot beside the contact method.

What changes do you think we should make in order to solve the problem?

We should set the validateCodeSent error to null when we get the success response for the ValidateSecondaryLogin, so that when we successfully validate the contact method and the magic code works, then no need to show the error for a maximum number of magic code requests.

so here we need to add the errorFields: {validateCodeSent: null} to the successData of the ValidateSecondaryLogin

App/src/libs/actions/User.js

Lines 426 to 437 in f15e6dc

    
           const successData = [ 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: ONYXKEYS.LOGIN_LIST, 
        
                   value: { 
        
                       [contactMethod]: { 
        
                           pendingFields: { 
        
                               validateLogin: null, 
        
                           }, 
        
                       }, 
        
                   }, 
        
               },

    errorFields: {
        validateCodeSent: null,
    }

What alternative solutions did you explore? (Optional)

none

jayeshmangwani · 2023-06-21T15:44:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR for the maximum number of attempts of the resend magic code persists after Successfully verifying the magic code

What is the root cause of that problem?

When we press the Resend magic code at that, we time call the requestContactMethodValidateCode method from User.js,

App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

Lines 80 to 81 in f15e6dc

    
           const resendValidateCode = () => { 
        
               User.requestContactMethodValidateCode(props.contactMethod);

if the API return the error then we set the error for validateCodeSent to errorFields in failureData

App/src/libs/actions/User.js

Lines 168 to 170 in a2d074b

    
           errorFields: { 
        
               validateCodeSent: ErrorUtils.getMicroSecondOnyxError('contacts.genericFailureMessages.requestContactMethodValidateCode'), 
        
           },

And when we get an error for validateCodeSent, and we do not clear the error by pressing the cross icon from the RBR, we add the correct magic code. At that time validateCodeSent error does not reset to null, and then we do not show the magic code page. However, the validateCodeSent error value is still there, and we can see the red dot beside the contact method.

What changes do you think we should make in order to solve the problem?

We should set the validateCodeSent error to null when we get the success response for the ValidateSecondaryLogin, so that when we successfully validate the contact method and the magic code works, then no need to show the error for a maximum number of magic code requests.

so here we need to add the errorFields: {validateCodeSent: null} to the successData of the ValidateSecondaryLogin

App/src/libs/actions/User.js

Lines 426 to 437 in f15e6dc

    
           const successData = [ 
        
               { 
        
                   onyxMethod: Onyx.METHOD.MERGE, 
        
                   key: ONYXKEYS.LOGIN_LIST, 
        
                   value: { 
        
                       [contactMethod]: { 
        
                           pendingFields: { 
        
                               validateLogin: null, 
        
                           }, 
        
                       }, 
        
                   }, 
        
               },

    errorFields: {
        validateCodeSent: null,
    }

What alternative solutions did you explore? (Optional)

none

melvin-bot · 2023-06-26T16:06:43Z

Job added to Upwork: https://www.upwork.com/jobs/~012abf0b985aa6c54b

melvin-bot · 2023-06-26T16:06:47Z

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-26T16:06:53Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

sonialiap · 2023-06-26T16:07:01Z

triaging to external 👍

mollfpr · 2023-06-27T19:26:15Z

Thanks @jayeshmangwani and the proposal looks good to me 🚀

🎀 👀 🎀 C+ reviewed!

melvin-bot · 2023-06-27T19:26:21Z

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

deetergp · 2023-06-28T18:38:12Z

That seems like the right solution. Hiring @jayeshmangwani.

jayeshmangwani · 2023-06-29T04:58:52Z

@mollfpr PR is ready for review

melvin-bot · 2023-07-05T16:57:36Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-07-05T16:57:37Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Set validateCodeSent null on success of validateSecondaryLogin #21841

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-05T16:57:39Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mollfpr · 2023-07-12T16:01:16Z

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#15204

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/15204/files#r1261394662

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This can be caught while QA, so the regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to Settings > Profile > Contact method
Press New Contact method > Enter any of your email address
Go to the newly added Contact method and Press Resend magic code 5-6 times until we get the error of the maximum number of attempts
Enter the last magic code from the Email
If the magic code worked and then It will navigate back to the Contact Methods page
Check the Added Contact method and verify there is no red dot(RBR) for the contact method
👍 or 👎

mollfpr · 2023-07-12T16:03:07Z

Melvin forgot to calculate this issue 🤔

The assignment Jun 29
PR merged on Jul 1

sonialiap · 2023-07-13T13:30:15Z

@jayeshmangwani offer sent for reporting issue + fix (+bonus) - paid
@mollfpr offer sent for review (+bonus) - paid

mollfpr · 2023-07-13T13:30:59Z

@sonialiap Accepted, thank you!

jayeshmangwani · 2023-07-13T13:32:56Z

@sonialiap offer Accepted, Thank you!

sonialiap · 2023-07-13T13:36:14Z

All paid ✔️

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 21, 2023

melvin-bot bot assigned sonialiap Jun 21, 2023

melvin-bot bot added the Overdue label Jun 23, 2023

sonialiap added the External Added to denote the issue can be worked on by a contributor label Jun 26, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2023

melvin-bot bot assigned mollfpr Jun 26, 2023

melvin-bot bot removed the Overdue label Jun 26, 2023

melvin-bot bot assigned deetergp Jun 27, 2023

deetergp assigned jayeshmangwani Jun 28, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 28, 2023

jayeshmangwani mentioned this issue Jun 28, 2023

Fix: Set validateCodeSent null on success of validateSecondaryLogin #21841

Merged

57 tasks

melvin-bot bot added the Reviewing Has a PR in review label Jun 28, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 5, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jul 5, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 11, 2023

mollfpr mentioned this issue Jul 12, 2023

Show all Expensify logins in Contact Methods page & view each in new Contact Method Details page #15204

Merged

54 tasks

sonialiap closed this as completed Jul 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method #21220

[HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method #21220

kbecciv commented Jun 21, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023 •

edited by sonialiap

Loading

kbecciv commented Jun 21, 2023

jayeshmangwani commented Jun 21, 2023

melvin-bot bot commented Jun 26, 2023

melvin-bot bot commented Jun 26, 2023

melvin-bot bot commented Jun 26, 2023

sonialiap commented Jun 26, 2023

mollfpr commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

deetergp commented Jun 28, 2023

jayeshmangwani commented Jun 29, 2023

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

mollfpr commented Jul 12, 2023

mollfpr commented Jul 12, 2023

sonialiap commented Jul 13, 2023 •

edited

Loading

mollfpr commented Jul 13, 2023

jayeshmangwani commented Jul 13, 2023

sonialiap commented Jul 13, 2023

[HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method #21220

[HOLD for payment 2023-07-12] [$1000] Web - RBR(red dot) for the maximum number of attempts of the resend magic code persists after Successfully adding the Contact method #21220

Comments

kbecciv commented Jun 21, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023 • edited by sonialiap Loading

Bug0 Triage Checklist (Main S/O)

kbecciv commented Jun 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

jayeshmangwani commented Jun 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jun 26, 2023

melvin-bot bot commented Jun 26, 2023

melvin-bot bot commented Jun 26, 2023

sonialiap commented Jun 26, 2023

mollfpr commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

deetergp commented Jun 28, 2023

jayeshmangwani commented Jun 29, 2023

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

mollfpr commented Jul 12, 2023

mollfpr commented Jul 12, 2023

sonialiap commented Jul 13, 2023 • edited Loading

mollfpr commented Jul 13, 2023

jayeshmangwani commented Jul 13, 2023

sonialiap commented Jul 13, 2023

kbecciv commented Jun 21, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 21, 2023 •

edited by sonialiap

Loading

sonialiap commented Jul 13, 2023 •

edited

Loading