[HOLD for payment 2023-07-12] [$1000] Name of member does not update in invite member workspaces when change name

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login account A and B on 2 devices
2. A create workspace => Click member => invite
3. A input email B
4. Tick B
5. B open setting => profile => display name
6. Change display name
7. In A it is observed that B's name does not change

Expected Result:

B's name in the invite screen must update when B changes name

Actual Result:

B's name does not change

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-15.at.21.26.22.mov

Recording.1067.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686839643612879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015e0f66ef0caecefb
• Upwork Job ID: 1673363798457892864
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Name of selected member isn't udpated in workspace invite member page when name is changed

What is the root cause of that problem?

When we select a member, those members are stored state.selectedOptions as you can see below

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 200 to 223 in 4bf2918

	toggleOption(option) {
	this.clearErrors();
	this.setState((prevState) => {
	const isOptionInList = _.some(prevState.selectedOptions, (selectedOption) => selectedOption.login === option.login);
	let newSelectedOptions;
	if (isOptionInList) {
	newSelectedOptions = _.reject(prevState.selectedOptions, (selectedOption) => selectedOption.login === option.login);
	} else {
	newSelectedOptions = [...prevState.selectedOptions, option];
	}
	const {personalDetails, userToInvite} = OptionsListUtils.getMemberInviteOptions(this.props.personalDetails, this.props.betas, prevState.searchTerm, this.getExcludedUsers());
	return {
	selectedOptions: newSelectedOptions,
	personalDetails,
	userToInvite,
	searchTerm: prevState.searchTerm,
	};
	});
	}

The value of selectedOptions are not updated when personalDetails props is changed. That's why name change isn't reflected to the selected member.

What changes do you think we should make in order to solve the problem?

1. We can store only accountIDs or emails instead of storing the whold user details. These information won't be changed(accountID is the best choice), and we can get information of selected information from their IDs and personalDetails props. In this way, we can update the member data on update of personalDetails.

2. We can update selectedOptions when personalDetails props changes in componentDidUpdate. This is a solution that requires minimum changes.

Result

21325_mac_chrome.mp4

What alternative solutions did you explore? (Optional)

[trjExpensify]

I think the chances of anyone running into this in practice are very slim, as the timing has to be so exact for the invited member to change their name exactly as that same member has temporarily been selected to be invited to a workspace.

Nevertheless, it is inconsistent with other places a name change is displayed immediately (i.e chat title etc), so let's go ahead and fix it if it's an easy one. Moving on!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015e0f66ef0caecefb

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[narefyev91]

Really rare case - and not sure that many users will make such tests - but anyway - proposal from @s-alves10 looks good to me #21325 (comment). In all other places we directly working with personal details from onyx - but here options are not connected to it. In my view we should add logic inside componentDidUpdate to track possible changes from onyx and updated selectedOptions.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[flodnv]

In my view we should add logic inside componentDidUpdate to track possible changes from onyx and updated selectedOptions.

👍

[melvin-bot]

📣 @s-alves10 You have been assigned to this job by @flodnv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[s-alves10]

@narefyev91
PR is ready for review

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @s-alves10 got assigned: 2023-06-27 14:07:18 Z
• when the PR got merged: 2023-07-03 13:12:47 UTC
• days elapsed: 3

On to the next one 🚀

[flodnv]

I disagree with Melvin. The delay was caused by me being ooo, the PR was ready to merge well before 2 business days had elapsed. This is eligible for the bonus @trjExpensify.

[trjExpensify]

Yeah, makes sense. I tend to go with the date the C+ approved their PR providing there aren't further changes requested. :)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update selectedOptions when personalDetails or policyMembers changes #21700

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 can we address the checklist please @narefyev91 to proceed with payments here? Thanks!

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - that was not coming from any PR that really introduced a bug - such edge case we not even count in code
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - no comments
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - no discussions
• Determine if we should create a regression test for this bug - already have them in QA section

[trjExpensify]

Determine if we should create a regression test for this bug - already have them in QA section

Cool, so here we're looking to determine whether a regression test should be created for this issue or not. I think we agree we shouldn't given the precise timing required to run into this bug. With that, I'll proceed to offers and closing this out.

@s-alves10 @namhihi237, I've sent you both offers here.

[namhihi237]

Thanks accepted

[trjExpensify]

Settled up with you both, closing. Thanks!