-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-03] [$1000] Polish admins-only policy room feature #21456
Comments
Triggered auto assignment to @jliexpensify ( |
Triggered auto assignment to Design team member for new feature review - @shawnborton ( |
Internal issue for reference: https://github.com/Expensify/Expensify/issues/282865 I shared in Slack to see if a Callstack team member has capacity for this. |
LMK if you need any Upworks stuff sorted! |
Hi, I'm Michael (Mykhailo) from Callstack and I would like to work in this issue. |
@amyevans Hi! |
Done |
@amyevans I have a question about the last task.
|
This is the copy for the Then we have this feature we're working on here, which is any room that is restricted to only admins posting (but plenty of non-admins are in the room). Check out the screen recordings/code in #19094 for more context. So we'll want to insert a new condition here-ish: Line 571 in 5c6b751
that checks if it's a room where only admins can post and then spits out Does that make sense? |
@amyevans Thank you for your answer.
Correct me if I am wrong 🙂 |
Yep! (But again, that isn't the room we're talking about in this feature at all.)
This doesn't directly answer your question, but more to point of what to do here, we'll want to create a new helper function: function isAdminsOnlyPostingRoom(report) {
const capability = lodashGet(report, 'writeCapability', CONST.REPORT.WRITE_CAPABILITIES.ALL) || CONST.REPORT.WRITE_CAPABILITIES.ALL;
return capability === CONST.REPORT.WRITE_CAPABILITIES.ADMINS;
} and use that function in a new condition in this logic: } else if (isAdminsOnlyPostingRoom(report)) {
...
}
Good point about why we separate out the phrases. That looks correct, thanks! |
@amyevans Got it. Thank you! |
ProposalPlease re-state the problem that we are trying to solve in this issue.This is a feature issue. It has 4 tasks. Anyway, it resolves some user problems too:
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore?
|
The 2nd task example:2.mp4 |
Thanks for writing that out as a detailed proposal! I haven't had the opportunity to review it yet and will eventually want a C+ to help with the PR review, so going to pull 1 in now for proposal review as well, so that you won't be blocked. Asked in Slack for a volunteer. |
Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@amyevans Hi! |
@amyevans, @mananjadhav, I've opened a PR for review - #23919. |
Payment summary:
No Upworks job created |
@jliexpensify The payout for me will be 125$, as there are two regressions and the payout date will change as the PR for the second regression is still open. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-08. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-14. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
There won't be any offending PR because this was more of a feature request. About regressions steps, @amyevans Can you confirm if these are added during the feature design? |
Good reminder, I haven't put in the request for new regression tests yet but I will Monday! |
Payment summary here (to save me/JMills/Anu scrolling up) |
Regression tests GH created: https://github.com/Expensify/Expensify/issues/308182 I think we're set to proceed with payment today! |
Cool, so there isn't anything to pay in Upworks - @mananjadhav is getting paid in New.Dot and @rezkiy37 is invoicing us. @amyevans are you happy to close this one, if everything is done? |
Sure, I wasn't sure if we had to keep it open until the payment was made in NewDot. Closing now! |
Reviewed the details for @mananjadhav. Approved for payment in NewDot based on BZ summary above. |
Background
We recently added a configurable setting to all default and user-created policy rooms, available to admins only, that allows admins to define who can post in that room: All members or Admins only. This enables admins to "control the conversation" in rooms that have large membership, or for whatever other reason should be lower-noise.
While the bulk of the work is complete, there's some remaining polish to be done on the FE.
Tasks
all
writeCapability
value when calling theAddWorkspaceRoom
endpointwriteCapability
value in theAddWorkspaceRoom
endpoint aren't live yet, but don't need to block work hereUse ${roomName} to hear about important announcements related to ${workspaceName}
for admin-only roomsUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: