[$1000] "__fake___" is displayed when clicking on "Mark as Complete" without selecting an assignee

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the room chat
2. Navigate to the "Assign task" section in the room chat
3. Enter a title for the task and click on "Next" > "Confirm task"
4. Click on description then enter description and click on save
5. Click on "Mark as complete"
6. Go to the room chat

Expected Result:

The user who created the task should have their email displayed when no assignee selected

Actual Result:

When clicking on "Mark as Complete" without selecting an assignee, "fake" is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3. 32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-06-20-at-11640-pm_yjE5Rysc.mp4

Recording.1099.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687249560384329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013428f2d15bee366a
• Upwork Job ID: 1677054385495605248
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"fake_" is displayed when clicking on "Mark as Complete" without selecting an assignee

What is the root cause of that problem?

The root cause of this problem originates here -

App/src/components/ReportActionItem/TaskPreview.js

Line 61 in 820fa93

const taskAssignee = props.taskReport.managerEmail || props.action.childManagerEmail;

Here - we are using managerEmail i.e. the task assignee
When we do Mark as Done for a task that is without assignee, the managerEmail is set to - __fake__
and thus being rendered
and we are not checking if the email is __fake__ or not

What changes do you think we should make in order to solve the problem?

For the task that doesn't have assignee

We have no participantAccountIDs list.

We can add this check before directly rendering the managerEmail, which will be __fake__ if the task is marked as done.

What to show here instead of __fake__ shall be discussed and decided.

This is the task that has assignee

The solution is -

• Add check of participantAccountIDs while displaying the managerEmail. Based on output from Expensify team we can decide what to display there.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

Will triage on wednesday

[sonialiap]

I am not getting the __fake__. @ayazhussain79 is this issue still occurring for you?

Screen.Recording.2023-06-28.at.4.56.33.PM.mov

[sonialiap]

I wonder if it got fixed in this issue #21216

[sonialiap]

Sounds like a PR was in review when both this issue and #21216 were reported

PR: #21216 (comment)

[ayazhussain79]

@sonialiap sorry for the delay, I'm still able to reproduce it
Please try these steps and try it on room chat not on workspace room chat

1. Open the room chat (if not created then created a room)
2. Navigate to the "Assign task" section in the room chat
3. Enter a title for the task and click on "Next" > "Confirm task"
4. after that click on description and write something
5. Now click on "Mark as done" button
6. Go back to the room chat

[ayazhussain79]

You can also check the steps in this video :

screen-recording-2023-06-28-at-91208-pm_ANS6zxC5.mp4

[abdulrahuman5196]

@sonialiap I doubt if the PR mentioned would solve this issue. The PR was only expected to solve workspace chat requests where workspace is shown as actor.

[ayazhussain79]

@sonialiap you can even reproduce it on chat here is the steps:

1. Open a chat
2. Go to the "Assign task"
3. Just enter title and create the task
4. After creating task edit the description
5. After editing click on "Mark as done" Button
6. Go to the chat and check the check the created task

screen-recording-2023-06-29-at-83655-pm_RKDn9PWp.mp4

[ayazhussain79]

@sonialiap can you please check this one?

[mountiny]

@abdulrahuman5196 can you still reproduce this issue?

[abdulrahuman5196]

@mountiny This issue isn't reproducible in the latest main. Now we are not even showing the name, could have been some recent change.

[ayazhussain79]

@mountiny @abdulrahuman5196 i can still reproduce it on lates main you can also reproduce it using both steps: #21502 (comment)

1. Open the room chat
2. Navigate to the "Assign task" section in the room chat
3. Enter a title for the task and click on "Next" > "Confirm task"
4. Click on description then enter description and click on save
5. Click on "Mark as complete"
6. Go to the room chat

Here is the result after taking lates pull from main

screen-recording-2023-07-03-at-62251-pm_DoLgRgUe.mp4

[ayazhussain79]

You can reproduce it using these steps in room and also in 1:1 chat
please follow these steps:
step 1 for 1:1 chat:
#21502 (comment)
For room chat:

1. Open the room chat
2. Navigate to the "Assign task" section in the room chat
3. Enter a title for the task and click on "Next" > "Confirm task"
4. Click on description then enter description and click on save
5. Click on "Mark as complete"
6. Go to the room chat

[abdulrahuman5196]

@mountiny Yes. Able to reproduce this issue. We should re-open this issue @sonialiap

[ayazhussain79]

@sonialiap can you please check this bug

[sonialiap]

Sorry guys, was caught up in other issues. Thanks for the reproduction videos and the reopen. Triaging to external ⏭️

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013428f2d15bee366a

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[BhuvaneshPatil]

About #21502 (comment)

We need to decide on the placeholder that we will be showing instead of __fake__.

[hoangzinh]

It seems this issue is fixed in this PR #21781

[melvin-bot]

@sonialiap @Santhosh-Sellavel this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[BhuvaneshPatil]

@ayazhussain79 Can you confirm if it's has been fixed or not.

[Santhosh-Sellavel]

Not Reproducible for me

[ayazhussain79]

Not able to reproduce now

[sonialiap]

I cannot reproduce any more either. Looks like this got resolved by another PR