[HOLD for payment 2023-07-10] [$1000] Desktop - Two keyboard shortcuts to open keyboard shortcuts modal

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Press CMD+J
2. Press ESC
3. Press CMD+I
4. Press ESC

Expected Result:

Only one of these keyboard shortcuts should open the keyboard shortcuts information modal.

Actual Result:

Both keyboard shortcuts open the keyboard shortcuts information modal, which is just a bit weird / makes our app more likely to conflict with other shortcuts.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

No video

Expensify/Expensify Issue URL:
Issue reported by: Rory Abraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687451916488959

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0105de33e8954123db
• Upwork Job ID: 1673409124664610816
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

I'm able to reproduce this on Desktop. I'm guessing only CMD+J should open the dialog, since that's what the dialog itself says.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0105de33e8954123db

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Ctrl + I opens keyboard shortcut modal on desktop, while do nothing on all other platforms

What is the root cause of that problem?

We're still using Ctrl + I in desktop system menu

App/desktop/main.js

Line 222 in c13b15e

accelerator: 'CmdOrCtrl+I',

What changes do you think we should make in order to solve the problem?

update accelerator to CmdOrCtrl+J

[0xmiros]

@puneetlath Proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @situchan You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

🎯 ⚡️ Woah @0xmiroslav / @situchan, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @situchan got assigned: 2023-06-27 22:05:13 Z
• when the PR got merged: 2023-06-28 15:22:36 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update shortcut key of desktop keyboard shortcut menu #21765

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

Sent Upwork contracts.

@0xmiroslav friendly reminder on the checklist as well.

[puneetlath]

Paid @situchan.

@0xmiroslav I'll get you once the checklist is done.

[0xmiros]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR: Allow keyboard shortcuts to work on native devices #17708
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17708/files#r1258594926
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was missed while implementing new feature of keyboard shortcut on native and deprecating Cmd+I for iOS.
As we will not likely to change shortcut key again, I don't think regression test step is needed.

[puneetlath]

Perfect, thanks @0xmiroslav.

Everyone has been paid. Thanks everyone!