[HOLD for payment 2023-07-28] [$1000] Web - "(edited)" shows up when user clicks on the show message button on a deleted first thread message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send a message from account A to account B
2. Hover over the sent message on account B and click on reply in thread and send a message as a thread reply
3. Hover over the first thread message and click on the flag icon
4. Go to account A and go to the original chat where the thread started off and delete the first message where the thread reply is on
5. Go to account B and select a severity from the panel. For eg. "Intimidation"
6. Click on the show message button on the first message

Expected Result:

User should see [Deleted message] after clicking on the show message button.

Actual Result:

"(edited)" shows up when user clicks on the show message button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-06-23.18.09.28.1.mp4

Recording.5195.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687533238591329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131a4c134074c1f4f
• Upwork Job ID: 1674819820477284352
• Last Price Increase: 2023-06-30

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[s-alves10]

FlagComment API returns parentReportAction with isEdited=true, isDeletedParentAction=false. Calling OpenReport API again returns isEdited=true, isDeletedParentAction=true. This is the main reason. Looks like should be fixed in the backend

[jeet-dhandha]

Is there a way I can help with the API ? @kbecciv

[CortneyOfstad]

I was able to recreate this on my side as well. Getting some eyes on this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131a4c134074c1f4f

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[CortneyOfstad]

Heading OoO for the week (back July 10) so re-assigning this in the meantime 👍

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@johncschuster, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[eVoloshchak]

Not overdue, looks like this need to be fixed on the back end

[eVoloshchak]

Is there a way I can help with the API ?
@jeet-dhandha, I think contributors can work only on the front end part of the app

[luacmartins]

We're still having this issue even after the API update. That's because we store reportAction when FlagCommentPage renders, but it's never updated for threads since props.reportActions points to the reportActions of the thread report and not parent report. I'm gonna look into a solution for this soon.

[luacmartins]

Actually, since the report action was deleted, I don't think we should be able to flag it at all - see this line. I'm wondering if we need to do anything here at all. What do you think @dangrous?

[dangrous]

So yeah, the flag won't go through on a deleted message - but if the flag pane is already open, I believe it should just silently fail (there's a lot of discussion about that in this issue, we ultimately decided that was best). The message itself, though, should be updated to its usual status - in this case, [Deleted message]. So if it's NOT currently doing that, we should make sure it does.

[luacmartins]

I believe it should just silently fail

Yea, this sounds good. I'll work on a fix for showing [Deleted message]. Thanks for confirming!

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Silently fail flagComment request if reportAction has been deleted #22831

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @Nathan-Mulugeta
• Contributor that fixed the issue - Internal - @luacmartins
• Contributor+ that helped on the issue and/or PR - @eVoloshchak

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

@eVoloshchak bump on the checklist above

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: This was a bug on back end

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not sure an additional discussion is needed here, this was an enge case missed during review, not much we could add to our processes

• Determine if we should create a regression test for this bug.
  Ideally, we want to test both cases: this issue and steps from Silently fail flagComment request if reportAction has been deleted #22831.
  Both of these cases are similar
  Is it easy to test for this bug? No, requires multiple accounts to test
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? No
  I think we shouldn't create a regression test for this. The bug isn't impactful and doesn't affect user experience, while being not easy to test

[johncschuster]

Thanks, @eVoloshchak!

I think we shouldn't create a regression test for this. The bug isn't impactful and doesn't affect user experience, while being not easy to test

@luacmartins what are your thoughts on the above? Do you agree?

[luacmartins]

I agree. This is an edge case scenario that doesn't prevent the user from using the App.

[johncschuster]

Summary of payment:

External issue reporter - @Nathan-Mulugeta - $250
Internal engineer fixed the issue
Contributor+ that helped on the issue and/or PR - @eVoloshchak - $1000 (will request through NewDot)

[johncschuster]

Working on issuing the bug report payment to Nathan in the above-linked issue.

[johncschuster]

Payment has been issued to @Nathan-Mulugeta on #23967 🎉

[johncschuster]

@JmillsExpensify

Summary of payment:

External issue reporter - @Nathan-Mulugeta - $250 (Paid via Upwork)
Internal engineer fixed the issue
Contributor+ that helped on the issue and/or PR - @eVoloshchak - $1000 (will request through NewDot)

[JmillsExpensify]

Reviewed details for @eVoloshchak. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.