[Awaiting payment] [$1000] Web - Compose box is distorted and messages are not loaded on reload after expand in compose box

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the NewExpensify app at https://staging.new.expensify.com
2. Click on an existing compose box or create a new compose box from a chat or task
3. Shift enter in compose box to enable expand button > press enter a few times to make the compose box window wide
4. Click on expand button
5. Reload and observe that expand button and + button in compose box are distorted and app does not load the chats

Expected Result:

App should load the chats and display expanded view on reload when we expand compose box and reload

Actual Result:

App does not load the chats and compose box is distorted when we expand compose box and reload

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3312.mp4

expand.reload.does.not.work.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687948877344299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb137372e1458408
• Upwork Job ID: 1674819530237825024
• Last Price Increase: 2023-07-11

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)

Not the dupe but might be related to:
#15596
#16078
#19642

- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

The problem is that this.props.isSidebarLoaded for some reason remains false in ReportScreen.js, despite it actually being true (the first value is used and then never refreshed). Sometimes I'm unable to reproduce and it all works fine. Ideas?

[Christinadobrzyn]

I can reproduce it - seems to only be affecting Mac/Chrome/Safari. Adding external label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb137372e1458408

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[pasyukevich]

Hi,
I am from Callstack - an expert contributor group
I start to investigate this issue

[Christinadobrzyn]

Hi @aimane-chnaif are you okay with this #21881 (comment)

[pasyukevich]

Hi @Christinadobrzyn

Am I able to continue my investigation?
I was able to reproduce this issue and started some investigation.

[aimane-chnaif]

@pasyukevich sure, please go ahead

[pasyukevich]

Found some dependency between the isSidebarLoaded and isComposerFullSize flags.
Looks like isComposerFullSize prevents updating the isComposerFullSize if they are placed in the same component.

Created Slack thread related to this behavior. https://expensify.slack.com/archives/C01GTK53T8Q/p1688570107740179

[Christinadobrzyn]

Hired in Upwork:
Internal job: https://www.upwork.com/ab/applicants/1674819530237825024/job-details
External job: https://www.upwork.com/jobs/~01cb137372e1458408

@aimane-chnaif as C+
@dhanashree-sawant as reporter

Let me know when we should add an eng label @aimane-chnaif

[pasyukevich]

Found a few ways how to fix this issue.
I continue my investigation by looking for a better one.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pasyukevich]

Found a better solution how to fix this issue.
I am preparing the proposal.

[Christinadobrzyn]

update for melvin - @pasyukevich is preparing the proposal!

[Christinadobrzyn]

watching this PR - Expensify/react-native-onyx#283

[Christinadobrzyn]

Hey @aimane-chnaif it looks like this onyx PR is in production and I think that might have been what we were waiting for here?

I just tested the steps in our OP and I think this might be resolved. Can you double-check and see if you still see an issue (other than the curser being in the middle of the compose box which maybe we don't want)

[aimane-chnaif]

Onyx version was bumped and merged already.
So I can say the root cause is fixed. And this issue is already not reproducible.
We can close this issue. (I might be eligible for compensation for reviewing #26274)

[dhanashree-sawant]

Hi @Christinadobrzyn, since this job is older then job mentioned in PR, will it be eligible for reporting bonus? If so then I already have the offer for this job, can you approve that before closing it?

[Christinadobrzyn]

Hey @Julesssss do you have any thoughts on paying for #26274

@dhanashree-sawant yes, you will be paid are the reporter.

[Julesssss]

Hey @Julesssss do you have any thoughts on paying for #26274

Yeah that's fair. Someone else created a PR and merged it before mine, but it would have been a valid review still.

[Christinadobrzyn]

Sounds good, sorry for the delay in payment.

I'll pay this out tomorrow.

@aimane-chnaif I'm thinking we'll pay 25% for the work on the PR? Let me know if you feel the payment should be different based on the work you did. Are you paid in Upwork on NewExpensify?

thanks!

[aimane-chnaif]

I am using upwork. 25% is fine if you think it's fair, though I expected higher percent as bug was fixed and PR was in mergeable state.

[Julesssss]

Yeah I agree. @Christinadobrzyn this was only not merged because our internal review was too slow. We should pay 100% IMO

[Christinadobrzyn]

Sounds good, sorry @aimane-chnaif I should've asked you what seemed fair.

Payouts due:

Issue Reporter: $250 @dhanashree-sawant (paid in Upwork with this job posting - now closed)
Contributor: NA
Contributor+: $1000 @aimane-chnaif (please accept the offer in this Upwork posting )

Eligible for 50% #urgency bonus? N

Upwork job is here.

[melvin-bot]

📣 @perfectdev95! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Julesssss]

Just awaiting payment now

[aimane-chnaif]

@Christinadobrzyn accepted offer. thanks

[Christinadobrzyn]

Thanks @aimane-chnaif paid you in Upwork based on this payment plan - #21881 (comment)

Closing!