[HOLD for payment 2023-07-24] [$1000] Web - Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send a message from account A to account B
2. From account B reply to the message in thread
3. From account B go back to the original report and flag the message as Intimidation or Bullying

4. Go back to the thread and notice the thread title still being visible in LHN and thread report

Expected Result:

LHN title and thread report title should display "Message Hidden" while the parent message of the thread has MODERATOR_DECISION of PENDING_HIDE or HIDDEN

Actual Result:

LHN title and thread report title are still visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-28.at.5.14.55.PM.1.mov

Recording.959.mp4

Expensify/Expensify Issue URL:
Issue reported by: Amjed Nazzal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687962396495309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a0825ff8c5c6ab6
• Upwork Job ID: 1674891685053624320
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

AmjedNazzal on GH

Please re-state the problem that we are trying to solve in this issue.

Thread report and LHN title still visible after thread parent message being flagged as Intimidation or Bullying

What is the root cause of that problem?

The text used for the titles of OptionRowLHN is retrieved from ReportUtils.getReportName which isn't handling the case where the parent message has been reported as Intimidation/Bullying or has been hidden.

App/src/libs/SidebarUtils.js

Lines 372 to 374 in 6183609

	const reportName = ReportUtils.getReportName(report);
	result.text = reportName;

What changes do you think we should make in order to solve the problem?

We could firstly add a new entry to parentReportAction and for example call it hiddenMessage and give it a value similar to deletedMessage.
We then can then add a check in ReportUtils.getReportName that would return hiddenMessage if the parentReport has MODERATOR_DECISION_PENDING_HIDE or MODERATOR_DECISION_HIDDEN.

if (
    lodashGet(parentReportAction, 'message[0].moderationDecisions[0].decision') === CONST.MODERATION.MODERATOR_DECISION_PENDING_HIDE ||
    lodashGet(parentReportAction, 'message[0].moderationDecisions[0].decision') === CONST.MODERATION.MODERATOR_DECISION_HIDDEN
) {
    return Localize.translateLocal('parentReportAction.hiddenMessage');
}

Result

Screen.Recording.2023-06-28.at.5.09.28.PM.mov

[joekaufmanexpensify]

I can reproduce. We decided to split this off from #21497 (comment) . Seems like expected behavior here is:

Intimidation/Bullying: The message will show as [Hidden]. You can still access the replies. The thread can be seen in LHN but titled [Hidden]

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a0825ff8c5c6ab6

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[joekaufmanexpensify]

Not overdue. Waiting for proposals

[AmjedNazzal]

@joekaufmanexpensify There is my proposal by the way posted by kbecciv :)

[joekaufmanexpensify]

Ah, thanks! @thesahindia mind reviewing the proposal when you have a chance?

[thesahindia]

I not sure but it's possible that it is being handled somewhere else. @dangrous was going to handle this case in a follow-up PR as mentioned in #19476 (comment).

@dangrous, please let us know if this is being handled somewhere else.

[dangrous]

Whoops, nope, never did that. Would be great to handle it here!

[joekaufmanexpensify]

Works for me!

[AmjedNazzal]

@joekaufmanexpensify is it going to be like an internal fix? or is my proposal going to be reviewed?

[joekaufmanexpensify]

I'm thinking we'll review your proposal, right @thesahindia ?

[thesahindia]

@AmjedNazzal's proposal looks good but I think we should get @shawnborton's input about the expected behaviour.

What do you think about the final result @shawnborton?

Screen.Recording.2023-06-28.at.5.09.28.PM.mov

[shawnborton]

I'm not too sure here, @dangrous since you worked on moderation, what do you think?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dangrous]

Behavior is certainly fine by me! Only question would be the specific copy we use. Not to suggest a ping of yet another person, but have we had marketing take a look at it? [Hidden message] (note the lowercase "message") probably works fine and follows the [Deleted message] pattern, but would be good to double check.

[joekaufmanexpensify]

Sounds good! Adding marketing label to get copy input. Here's a summary of the issue, if you're assigned:

If a message is reported as being intimidation for bullying, we currently hide the message in the chat, and give the option to reveal its contents. However, if the reported message has a thread report beneath it, we still show the reported message's contents in the thread report title in LHN, and then in the thread header if you click into the thread report.

In this issue, we're proposing that when a message reported for bullying/intimidation has a thread beneath it, that we'll hide the reported message in LHN, and then the thread report's header. We're proposing that we do this with the following copy [Hidden message].

We're thinking this makes sense, as it follows a similar pattern to how we handle a thread's parent message being deleted (Deleted message), though curious if you agree?

[AmjedNazzal]

@joekaufmanexpensify Friendly nudge regarding payment :)

[joekaufmanexpensify]

Thanks! Yep we just need to complete the BZ checklist before we can send payment. @thesahindia mind completing your portion?

[joekaufmanexpensify]

Okay, this one qualifies for a speed bonus, so we need to make the following payments:

• @AmjedNazzal - $1,750 ($1000 for PR + $500 speed bonus + $250 reporting bonus).
• @thesahindia $1,500 ($1000 for C+ review, and $500 speed bonus).

[joekaufmanexpensify]

@AmjedNazzal you're already hired, so we'll issue payment as soon as the BZ checklist is complete.

[joekaufmanexpensify]

@thesahindia once the BZ checklist is complete, please submit a payment request, and comment on the issue once you've done that!

[joekaufmanexpensify]

Bumped in Slack.

[thesahindia]

We can skip the checklist because it wasn't a regression. We knew about this case when the main PR was open but we decided to handle it in a follow up PR.

If we wanna add a test case here are steps-

1. Send a message from account A to account B
2. From account B reply to the message in thread
3. While inside the new thread reply with anything like "Hello"
4. Go back to the original report and flag the message as Intimidation or Bullying
5. Go back to the thread and verify the thread title as well as the LHN title is now [Hidden message]

[joekaufmanexpensify]

BZ checklist is complete.

[joekaufmanexpensify]

@AmjedNazzal $1,750 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

@thesahindia could you please request $1,500 and comment here once complete?

[joekaufmanexpensify]

Note: payment summary message is here.

[thesahindia]

I will request the payment in the morning. I had some bank issues so I was busy resolving them.

[joekaufmanexpensify]

All good. Thanks!

[joekaufmanexpensify]

@thesahindia did you have a chance to request payment here yet?

[sonialiap]

I can reproduce the issue still

Screen.Recording.2023-07-28.at.4.42.23.PM.mov

[thesahindia]

I couldn't. I am facing issues while adding my bank account. I have asked about it here.

You can just close the issue, I will add it to my list and will request payment once the problem gets resolved (Did the same on other tickets)

[thesahindia]

I can reproduce the issue still

I think it is a regression and not related to the current issue.

[joekaufmanexpensify]

i will take a look into this today.

[joekaufmanexpensify]

@sonialiap are you still able to reproduce this now? I just tested on my end, and it seemed to work. Though, I had to click into the thread after reporting the message before the title updated to Hidden message.

[joekaufmanexpensify]

Still figuring this out

[joekaufmanexpensify]

Okay, I tested this again, and it's working for me. So going to close this out. @sonialiap LMK if you see this not working again, and happy to look into it more.

[joekaufmanexpensify]

Please note that @thesahindia still needs to request payment, but advised we can close this in the interim, and he'll request payment once the issue with his bank account is resolved.

Here's the summary of payments for when we pay this in NewDot:

• @AmjedNazzal - $1,750 ($1000 for PR + $500 speed bonus + $250 reporting bonus). Paid via Upwork.
• @thesahindia $1,500 ($1000 for C+ review, and $500 speed bonus). Still needs to be paid via NewDot.

[JmillsExpensify]

Reviewed the details for @thesahindia. $1,500 approved for payment in NewDot based on the BZ summary above.