Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - LHN - Console error when clicking FAB button #21944

Closed
1 of 6 tasks
kbecciv opened this issue Jun 30, 2023 · 8 comments
Closed
1 of 6 tasks

Web - LHN - Console error when clicking FAB button #21944

kbecciv opened this issue Jun 30, 2023 · 8 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jun 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Click on the green plus button (FAB)

Expected Result:

No console error when clicking FAB button

Actual Result:

Console error when clicking FAB button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.35.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image (6)

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 30, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 30, 2023

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Jun 30, 2023

@PauloGasparSv Console error when clicking on emoji picker, let me know if we need a separate bug for it.

image

@alitoshmatov
Copy link
Contributor

Might be helpful

Error is originating here:

function getThemeBackgroundColor(bgColor = themeColors.appBG) {
const backdropOpacity = variables.modalFullscreenBackdropOpacity;
const [backgroundRed, backgroundGreen, backgroundBlue] = hexadecimalToRGBArray(bgColor);
const [backdropRed, backdropGreen, backdropBlue] = hexadecimalToRGBArray(themeColors.modalBackdrop);

where bgColor is not in hexadecimal form but in rgba form, which is causing hexadecimalToRGBArray to return undefined.

This function is called here:

setStatusBarColor(isFullScreenModal ? themeColors.appBG : StyleUtils.getThemeBackgroundColor(statusBarColor));

This value is coming from here:

StatusBar.getBackgroundColor = () => {
const element = document.querySelector('meta[name=theme-color]');
if (!element || !element.content) {
return null;
}
return element.content;
};

I think this bug was introduced in this PR: #20805

@kushu7
Copy link
Contributor

kushu7 commented Jun 30, 2023

I'm working on this regression.

@situchan
Copy link
Contributor

Dupe of #21833 and already being worked there

@melvin-bot
Copy link

melvin-bot bot commented Jun 30, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@PauloGasparSv PauloGasparSv removed the DeployBlockerCash This issue or pull request should block deployment label Jun 30, 2023
@PauloGasparSv
Copy link
Contributor

Issue reported by: Applause - Internal team

Dupe of #21833 and already being worked there

Thks team, I'll close this as it is a Duplicate of #21833 (similar to #21952)

Also removing the DeployBlocker label from here since it's a regression and it started in #20516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants