[HOLD for checklist] [$1000] Dev: console error on attach large file

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send large file (<24 MB)

Expected Result:

Should not show any console error

Actual Result:

Console error appears (Failed prop type: The prop title is marked as required in ConfirmContent, but its value is null.)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1(occurs in dev)
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-29.at.12.34.26.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688026830153149

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019cbb5ba4f7a22f2f
• Upwork Job ID: 1676868760224428032
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

console error on attach large file

What is the root cause of that problem?

initially title of ConfirmModal is null and prop type of title is string

App/src/components/AttachmentModal.js

Line 86 in 5997357

const [attachmentInvalidReasonTitle, setAttachmentInvalidReasonTitle] = useState(null);

What changes do you think we should make in order to solve the problem?

use empty string instead of null to below code for initialization
change from

App/src/components/AttachmentModal.js

Line 86 in 5997357

const [attachmentInvalidReasonTitle, setAttachmentInvalidReasonTitle] = useState(null);

to
const [attachmentInvalidReasonTitle, setAttachmentInvalidReasonTitle] = useState(‘’);

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

console error on attach large file

What is the root cause of that problem?

initially title of ConfirmModal is null and prop type of title is string

App/src/components/AttachmentModal.js

Line 86 in 5997357

const [attachmentInvalidReasonTitle, setAttachmentInvalidReasonTitle] = useState(null);

What changes do you think we should make in order to solve the problem?

use empty string instead of null to below code for initialization
change from

App/src/components/AttachmentModal.js

Line 86 in 5997357

const [attachmentInvalidReasonTitle, setAttachmentInvalidReasonTitle] = useState(null);

to
const [attachmentInvalidReasonTitle, setAttachmentInvalidReasonTitle] = useState(‘’);

[kamaljitSharma21]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: console error on attach large file

What is the root cause of that problem?

1. The ConfirmModal is accepting a prop type of title and prompt as a string

2. Here we are setting the setIsAttachmentInvalid to true before setting the attachmentInvalidReasonTitle and attachmentInvalidReason. This setIsAttachmentInvalid will open the ConfirmModal and when ConfirmModal will open the attachmentInvalidReasonTitle and attachmentInvalidReason will still might be empty.

What changes do you think we should make in order to solve the problem?

1. Change the state of attachmentInvalidReasonTitle and attachmentInvalidReason from null to ' '

2. Set setIsAttachmentInvalid to true after setting the title and reason

update code -

if (lodashGet(_file, 'size', 0) > CONST.API_ATTACHMENT_VALIDATIONS.MAX_SIZE) {
  setAttachmentInvalidReasonTitle(props.translate('attachmentPicker.attachmentTooLarge'));
  setAttachmentInvalidReason(props.translate('attachmentPicker.sizeExceeded'));
  setIsAttachmentInvalid(true);
  return false;
}

NOTE : By just doing 1st point of the fix it might break the confirmation modal and show an empty title and empty reason in some scenarios where the network might be slow so 2nd point of the fix is recommended because this will set the title and reason before opening the ConfirmModal.

NOTE : This error will show for all the three scenarios which we are creating here - Invalid Extension, Max File Size, Min File Size

By doing similar changes as shown above we can fix this also.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[greg-schroeder]

Will review after the holiday

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019cbb5ba4f7a22f2f

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[narefyev91]

The issue here is that Confirm modal is not really waiting null for title. In all other components in which <ConfirmModal is used - we either directly apply title from props, or having default value as empty string - like here src/components/AvatarWithImagePicker.js
The correct solution is to have default empty string - @gadhiyamanan was the first one - his proposal looks good #21947 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[gadhiyamanan]

@kbecciv is from testing team and proposal was proposed by me in slack while reporting bug

cc: @narefyev91

[narefyev91]

@kbecciv is from testing team and proposal was proposed by me in slack while reporting bug

cc: @narefyev91

Oh makes sense - will update my comment, thanks!

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix console error on attach large file #22354

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Issuing offers

[gadhiyamanan]

@greg-schroeder offers have already been accepted which was shared by Malvin #21947 (comment) #21947 (comment)

[greg-schroeder]

Sorry I meant to say payment

[gadhiyamanan]

@greg-schroeder this is also eligible for 50% bonus

[greg-schroeder]

Payment complete. Awaiting checklist from @narefyev91

[greg-schroeder]

Bump on the above @narefyev91

[narefyev91]

@greg-schroeder Hey! Sorry I'm OOO on vacation - i hope @mountiny will help here

[mountiny]

@gadhiyamanan as the M=Pr author can you please complete the checklist?

[greg-schroeder]

bump @gadhiyamanan on the above

[gadhiyamanan]

[@narefyev91] The PR that introduced the bug has been identified. Link to the PR: #10118

[@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Should be caught based on checklist https://github.com/Expensify/App/pull/10118/files#r1275749150

[@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Should be caught based on checklist

[@narefyev91] Determine if we should create a regression test for this bug. N/A

[@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

We already have a checklist item. I don't think any further updates are required

[ ]I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed

I don't think we need a regression test as well. this is a minor issue

[greg-schroeder]

Thanks @gadhiyamanan!