[HOLD for payment 2023-08-24] [$1000] IOS - The email in welcome message acts like a button in iOS

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Go to any new chat
3. Long-press on the email in welcome message

Expected Result:

The opacity remains unchanged

Actual Result:

The opacity of the email changes like a button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1687979974.mov

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688035358417099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e1d49b9ff9897e9
• Upwork Job ID: 1676883137564983296
• Last Price Increase: 2023-07-27
• Automatic offers:
• abdulrahuman5196 | Reviewer | 25887098
• aman-atg | Contributor | 25887099
• aman-atg | Reporter | 25887101
• c3024 | Contributor | 25990000

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aman-atg]

Proposal

Please re-state the problem that we are trying to solve in this issue.

(Inconsistency) The email in welcome message acts like a button in iOS

What is the root cause of that problem?

The root cause of the problem is the usage of the component to wrap the email

What changes do you think we should make in order to solve the problem?

To solve the issue, we should replace the Text component with a PressableWithoutFeedback component in ReportWelcomeText.js here

What alternative solutions did you explore? (Optional)

An alternative solution would be to wrap the Text component with TouchableOpacity or PressableWithFeedback components

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e1d49b9ff9897e9

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[zanyrenney]

Hey @abdulrahuman5196 please review the proposal above from @aman-atg - thanks!

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Email in welcome message when clicked its opacity changes.

What is the root cause of that problem?

The root cause of the problem is in iOS a Text onPress highlights this way but it is desirable to have same feedback across devices on press so this needs to be fixed.
Here displayName is wrapped with this.
https://github.com/Expensify/App/blob/b5951017f7f299daf2f2ce6444dd4e9fc4b5e924/src/components/ReportWelcomeText.js#L101C37-L109C38

What changes do you think we should make in order to solve the problem?

We can add suppressHighlighting to the component to prevent highlighting.

<Text
                                        style={[styles.textStrong]}
                                        onPress={() => {
                                            const accountDetails = props.personalDetails[participantAccountIDs[index]];
                                            if (accountDetails && accountDetails.accountID) {
                                                Navigation.navigate(ROUTES.getProfileRoute(accountDetails.accountID));
                                            }
                                        }}
                                        suppressHighlighting
                                    >

We can change at other places Text is used in the same way.
Since this is a simple Text and not several components to be wrapped for a single Press functionality I think it's better to add supressHighlighting here than enclosing with a Pressable and moving the onPress to there.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[zanyrenney]

bump @abdulrahuman5196 please can you review the proposals on this issue and decide which is the best path forward here? thanks!

[zanyrenney]

bump @abdulrahuman5196 let me know your thoughts or any blockers I can help with? Thanks.

[abdulrahuman5196]

Sorry for the delay. Will complete the reviews tomorrow morning.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

@zanyrenney proposal from @aman-atg here #22103 (comment) is good. Do we need the behaviour of PressableWithFeedback or PressableWithoutFeedback here?

[abdulrahuman5196]

Thank you for the proposal @c3024 here #22103 (comment). But the current recommended approach is to use PressableWithFeedback or PressableWithoutFeedback or similar generic components instead of buttons

[c3024]

Is it somewhere specifically mentioned that the recommended approach is to use Pressables only because I have seen at few other places also where onPress events are used on components other than Pressables line this, this, this, this, this, this, and at several Text, Button, Wrapper and other components.

It seems overkill for a simple Text component to wrap in a Pressable and move onPress to the Preesable from Text for this case.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[danieldoglas]

Wait, the integrations got wrong here. Let me fix that.

[danieldoglas]

@zanyrenney the integrations might have gotten messed up here, so maybe when paying you'll need to recheck the Upwork contracts. Other than that, @c3024 , you're assigned now.

[c3024]

PR #24244 ready for review @abdulrahuman5196

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @c3024 got assigned: 2023-08-07 14:32:07 Z
• when the PR got merged: 2023-08-14 10:20:29 UTC
• days elapsed: 4

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• suppressHighlighting on Text components with onPress #24244

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment offer (Reviewer)
• @c3024 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

@abdulrahuman5196 PAID $1000 - no urgency bonus
@c3024 PAID $1000 - no urgency bonus
@aman-atg - PAID $250.

All payments completed.