[HOLD for payment 2023-07-21] [$1000] Web - Split bill with a new user displays 'undefined owes' on staging

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome and login with User A
2. Click on FAB icon and click on split bill
3. (IMP step)- Now search for a new user that has NO Expensify account and split the bill with the user
4. Notice that for a small period of time it displays 'undefined' owes on the report
5. Follow the same steps on production , no such problem occurs

Expected Result:

Split bill with a new user should not display 'undefined'

Actual Result:

Split bill with a new user displays 'undefined owes'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-07-03_14.22.25.mp4

Recording.3376.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688373739740659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162160db7d748962b
• Upwork Job ID: 1676900194451750912
• Last Price Increase: 2023-07-06

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill with new user displays undefined for user name when offline.

What is the root cause of that problem?

The root cause of this issue is that after migration from emails to account ids, we are not optimistically creating the user entry in the personalDetailsList object. Because of the missing entry, this condition returns undefined.

What changes do you think we should make in order to solve the problem?

We should create an entry in the personalDetailsList object optimistically here or here.
Note: We can also add the optimistic object somewhere else in our flow. The above 2 points are just an example of where we can add it.

What alternative solutions did you explore? (Optional)

If we do not want to create an optimistic persona detail object, we can also update the getPersonalDetailsForAccountID function such that it searches for the account id in the IOU object.

[madmax330]

Discussed here: https://expensify.slack.com/archives/C03TQ48KC/p1688391023413499?thread_ts=1688389934.788359&cid=C03TQ48KC

Since it is also happening in prod it's not a blocker.

[Julesssss]

Thanks, removed it from the checklist 👍

[madmax330]

Passing off to @Beamanator since it's related to the accountID migrationl

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0162160db7d748962b

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[Beamanator]

Making external b/c it looks like this has to do with optimistic personal details - @narefyev91 looks like you're auto-assigned to review proposals! We already have 1 above it looks like 👍

[narefyev91]

Making external b/c it looks like this has to do with optimistic personal details - @narefyev91 looks like you're auto-assigned to review proposals! We already have 1 above it looks like 👍

No problem at all

[MonilBhavsar]

May be we can fix this auto assigner issue 👍 😄

[allroundexperts]

@narefyev91 @allroundexperts just to be clear, if we create a new optimistic entry in Onyx we need to clean it up at some point, right? Maybe in successData or failureData of the API command(s)?

My understanding is that it will get overridden automatically by the backend response.

[Beamanator]

AFAIK we don't ever send the optimistic accountID to the backend, because there's nothing we do with it there - if the account doesn't exist yet, we create it (which automatically assigns a new accountID in sequence) and send that updated data back in Onyx

[allroundexperts]

AFAIK we don't ever send the optimistic accountID to the backend, because there's nothing we do with it there - if the account doesn't exist yet, we create it (which automatically assigns a new accountID in sequence) and send that updated data back in Onyx

Yes. We aren't sending that in this case as well. It will get overridden once the response comes from backend. We can fine tune this further in the PR though.

[Beamanator]

Yeah we can fine-tune in the PR 👍 Let's just make sure to watch out for the optimistic data sticking around longer than it should 👍

[melvin-bot]

📣 @allroundexperts 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Priya! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire priya for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[allroundexperts]

PR created!

[CortneyOfstad]

@Beamanator and @allroundexperts — where are we at with this? Anything needed from my side? TIA!

[Beamanator]

@CortneyOfstad looks like the PR is on staging! #22401 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: fix the logic for generating optimistic personal details #22401

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[CortneyOfstad]

@priya-zha and @allroundexperts I've extended contracts your way — please let me know once you accept in Upwork, and I can get those paid ASAP. Thanks!

[allroundexperts]

Hi @CortneyOfstad!

I'll be getting paid through the App.

Also, I THINK this might be eligible for bonus. Can you please do the calculations?

[CortneyOfstad]

@allroundexperts You do get the bonus, and I'll cancel the contract in UpWork — thank you!

[CortneyOfstad]

@priya-zha contract has been paid! Closing this out!

[anmurali]

Approved 1500 to Sibtain based on #22104 (comment)