-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-15] [$1000] Infinite loading on Invite members page after refresh #22508
Comments
Triggered auto assignment to @muttmuure ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Refreshing when viewing the invite members page in a workspace shows it's loading permanently. What is the root cause of that problem?The App/src/pages/workspace/WorkspaceInvitePage.js Lines 270 to 272 in 395f4a7
This event is normally fired when moving between screens, i.e. when navigating to the 'invite members page' indirectly (by clicking Workspace > Members > Invite). However, when directly browsing to it, there is no transition happening and This issue also exists in other components where loading is blocked until What changes do you think we should make in order to solve the problem?Option 1: Instead of setting Option 2: We can use What alternative solutions did you explore? (Optional)N/A |
ProposalPlease re-state the problem that we are trying to solve in this issue.Infinite loading on Invite members page after refresh What is the root cause of that problem?In
We just show the option if didScreenTransitionEnd is true, and didScreenTransitionEnd is updated to true when App/src/components/ScreenWrapper/index.js Lines 37 to 45 in 395f4a7
But if we visit the page directly, the What changes do you think we should make in order to solve the problem?
And in ScreenWrapper, we can early set didScreenTransitionEnd to true if didNavigate is false
What alternative solutions did you explore? (Optional)Another approach to fix this is part B in this solution (it's a related issue). ResultScreen.Recording.2023-07-10.at.18.24.10.mov |
I'm not able to reproduce this one. |
This is still reproducible to everyone. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@muttmuure This is still reproducible. @kavimuru can you please confirm? |
This is constantly reproducible to me |
Hey @muttmuure Reopening this as it's reproducible and other bugs (such as #22850) may depend on the solution implemented here |
Proposal updated to highlight an alternate solution. |
Job added to Upwork: https://www.upwork.com/jobs/~0160eb205488d8fcdd |
Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
@Santhosh-Sellavel if you are able to take a look here that would be great |
I don't think we need a regression test for this one, what do you think @bernhardoj @situchan ? |
@bernhardoj paid, @situchan offer sent |
Can we close this one then? |
Still waiting for @situchan to accept the offer https://www.upwork.com/nx/wm/offer/101907756 |
Moving to Monthly while @situchan is out. Feel free to tag me when you're back and I'll process it |
Waiting for @situchan to accept the offer |
Sorry for late. Accepted |
@muttmuure moving back to daily since @situchan is back |
Paid up |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Show contacts list to invite
Actual Result:
Show skeleton forever
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.38-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
bug.3.mov
Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688833373673129
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: