Split bill - App crashed when try to split bill via group

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #22643

Action Performed:

1. Create a brand new account that isn't on a domain with a subscription (xyz@expensify
   ❌ // xyz@gmail.com
   ✅ )
2. Create a group chat with multiple participants
3. 'Split Bill' for group

Expected Result:

You should be able to split a bill from someone successfully

Actual Result:

App crashed on iOS. Android App, Button "Split" not active for Mac/Chrome, Desktop App, mweb

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6130076_22643_Desktop.mp4

Bug6130076_22643_ios.mp4

Bug6130076_22643_Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Dupe of #21268

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when try to split bill with new users

What is the root cause of that problem?

The backend returns personalDetail info with login = 'undefined' for new users as I mentioned #22588 (comment).
So the parameters of Localize.arrayToString includes undefined for newly created accounts.

App/src/libs/actions/IOU.js

Line 462 in 25c8ae5

const formattedParticipants = Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login)]);

This is the root cause

What changes do you think we should make in order to solve the problem?

login field for new users are undefined. Instead they have alternateText(email) and text(display name) fields. We can use this

    const formattedParticipants = Localize.arrayToString([currentUserLogin, ..._.map(participants, (participant) => participant.login || participant.alternateText)]);

This works as expected.

What alternative solutions did you explore? (Optional)

This can be fixed in the backend

[johncschuster]

Closing since this is a duplicate of #21268. Please take all proposals to that issue instead.