Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-09-06] [Custom Status] Display status emojis in the LHN (including the user's own status) #23132

Closed
stitesExpensify opened this issue Jul 18, 2023 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Jul 18, 2023

Part of the Custom Status project

Main issue: #16350
Doc: https://docs.google.com/document/d/1uPS24aoRWE45piaTvr0XvrgV1lK3lSjieG3sD5ZPfQg/edit#bookmark=id.dm0yu67h9vq8
Project: https://github.com/orgs/Expensify/projects/59/views/1

Display status emojis in the LHN

This issue focuses on showing user status in the LHN in 2 places:

  1. The user's own status show appear in the top right of the LHN near the profile picture. When pressed, this will bring the user to the custom status page. When hovering this emoji on web/desktop, a tooltip will be shown with the emoji and the status text
2023-07-18_15-06-00 2023-07-18_15-10-13
  1. Other user's statuses will be shown next to their name in the LHN chat list
2023-07-18_15-06-10
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c5ffc19f1b06509d
  • Upwork Job ID: 1701267094553931776
  • Last Price Increase: 2023-09-11
@stitesExpensify
Copy link
Contributor Author

No update here, but work has started on the base PR!

@melvin-bot melvin-bot bot removed the Overdue label Jul 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2023
@stitesExpensify
Copy link
Contributor Author

Base PR is in review!

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 14, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 14, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 14, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 15, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 15, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 17, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 17, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 20, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 20, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 20, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Aug 22, 2023
stitesExpensify added a commit that referenced this issue Aug 24, 2023
Display status emojis in the LHN (including the user's own status)
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 30, 2023
@melvin-bot melvin-bot bot changed the title [Custom Status] Display status emojis in the LHN (including the user's own status) [HOLD for payment 2023-09-06] [Custom Status] Display status emojis in the LHN (including the user's own status) Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Sep 11, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-09-06] [Custom Status] Display status emojis in the LHN (including the user's own status) [$500] [HOLD for payment 2023-09-06] [Custom Status] Display status emojis in the LHN (including the user's own status) Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c5ffc19f1b06509d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Triggered auto assignment to @flaviadefaria (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@stitesExpensify
Copy link
Contributor Author

Hey @burczu this hadn't been marked as external when you reviewed the PR. If you want to apply as the C+ we will get it paid out ASAP!

@burczu
Copy link
Contributor

burczu commented Sep 12, 2023

Hey @stitesExpensify! I'm from Callstack, so payments via UpWork for my C+ work does not apply. But thanks ;)

@stitesExpensify
Copy link
Contributor Author

Oh 🤦 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

4 participants