[HOLD for payment 2023-08-17] [$1000] Create Onyx migration for previousReportActionID

[roryabraham]

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.bry74gx446k1
Project: Comment Linking

Create an Onyx migration called CheckForPreviousReportActionID that:

• Looks at a single reportAction from Onyx
• If that reportAction has the previousReportActionID field, resolve the migration.
• If the reportAction does not have the previousReportActionID field, delete all reportActions from Onyx

This migration should be created and tested, but not yet added to migrateOnyx until we are ready.

Manual Test Steps

Manually test this by locally adding the migration to migrateOnyx but do not commit that change.

Automated Tests

We should update MigrationTest to include tests for the new migration.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01382a606158d56e43
• Upwork Job ID: 1681813151297843200
2023-07-19
• Automatic offers:
• abdulrahuman5196 | Reviewer | 25687360
• neonbhai | Contributor | 25687361

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01382a606158d56e43

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[roryabraham]

No UI changes so I unassigned @shawnborton, but didn't mean to unassign @abdulrahuman5196

[roryabraham]

Sorry for any confusion, @abdulrahuman5196 is the C+ for this issue

[neonbhai]

Can contributors work on this feature? I am interested in working on this!

[neonbhai]

@roryabraham @abdulrahuman5196 The PR is ready for review!

[joekaufmanexpensify]

PR still in review.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @neonbhai got assigned: 2023-07-22 08:03:16 Z
• when the PR got merged: 2023-08-08 19:09:21 UTC
• days elapsed: 11

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Onyx Migration for checkPreviousReportActionID #23457

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment offer (Reviewer)
• @neonbhai requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[joekaufmanexpensify]

Not overdue. Payment due next week!

[abdulrahuman5196]

No BZ checklist, since this is a migration feature request.

[joekaufmanexpensify]

Okay, all set to issue payment here. Based on the guidelines for payment, this one would qualify for 50% speed penalty, since it took more than 9 business days to merge (11 specifically). This means we need to pay:

• @neonbhai $500 for PR.
• @abdulrahuman5196 $500 for C+ review.

LMK if you have any questions on this, and if not, I'll issue payment on Monday!

[neonbhai]

Hi @joekaufmanexpensify just wanted to say that the PR started reviewing about 3 days after raising the PR as I'm presuming @abdulrahuman5196 sir could not give enough time. As this was my first feature contribution, and since the migration is on the backend and the check could be running on every user signin, me and @abdulrahuman5196 tried to perfect and minimize the PR code. I hope the penalty can be forgiven 🙇

[joekaufmanexpensify]

@neonbhai Thanks for the context! The purpose of the speed bonus/penalty is to incentivize the contributor and C+ to collaborate to get the PR merged quickly. It doesn't look like there were any internal delays here, so we'd still need to apply the penalty.

But this doesn't impact your ability to contribute to future issues, or anything like that! LMK if you have any other questions.

[neonbhai]

@joekaufmanexpensify okay, got it!

[joekaufmanexpensify]

@neonbhai $500 sent and contract ended!

[joekaufmanexpensify]

@abdulrahuman5196 I see you were hired twice on this Upwork job, but I'm not sure why. As an fyi, I'm going to pay you $500 on one of the contracts, and then close out the other one with no payment.

LMK if you have any questions on this!

[joekaufmanexpensify]

@abdulrahuman5196 $500 sent and first contract ended!

[joekaufmanexpensify]

@abdulrahuman5196 second contract ended with no payment.

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Closing as this is all set. Thanks everyone!