[HOLD for payment 2023-08-10] [$1000] Long emoji names are not being truncated and icons displayed at the start #23519

kavimuru · 2023-07-24T22:31:42Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings > Preferences.
Select Spanish language.
Go back and open a chat.
Type ":pist" in the chat
Observe that the emoji icons are not at their positions

Expected Result:

Long emoji names should be broken into multiple lines (so the entire name is visible), and should appear in the same position as other emojis).

Actual Result:

Long emojis names are not being truncated that cause the icons not displayed at the their position

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690043682464129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01245a38493bcc690f
Upwork Job ID: 1683941474981871616
Automatic offers:

hungvu193 | Contributor | 25816031

melvin-bot · 2023-07-24T22:31:46Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-24T22:31:48Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

s-alves10 · 2023-07-24T23:40:05Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long emoji suggestions doesn't show ellipsis, instead they are cut off

What is the root cause of that problem?

Emoji suggestion style has no text ellipsis feature

App/src/styles/styles.js

Lines 199 to 201 in b7d17e0

    
           emojiSuggestionsText: { 
        
               fontSize: variables.fontSizeMedium, 
        
           },

What changes do you think we should make in order to solve the problem?

We have 2 options: ellipsis and multiline

Add flexShrink: 0 to the emojiSuggestionsEmoji style to prevent the shrink
Add the following styles to the emojiSuggestionsText style in each case

Ellipsis

    flexShrink: 1,
    ...spacing.mr2,

Add two props below

App/src/components/EmojiSuggestions.js

Line 72 in 2b67fa3

    <Text style={styles.emojiSuggestionsText} numberOfLines={1} ellipsizeMode='tail'>

Multiline

    flexShrink: 1,
    ...spacing.mr2,
    ...wordBreak.breakAll

This works fine.

android

web

What alternative solutions did you explore? (Optional)

We can apply similar styles with mention suggestions
Add styles.ph2 to the EmojiSuggestion container style

App/src/components/EmojiSuggestions.js

Line 70 in b7d17e0

Set width:24 in the emojiSuggestionsEmoji style

App/src/styles/styles.js

Lines 194 to 198 in b7d17e0

    
           emojiSuggestionsEmoji: { 
        
               fontSize: variables.fontSizeMedium, 
        
               width: 51, 
        
               textAlign: 'center', 
        
           },

Add the following styles to the emojiSuggestionsText style

    marginLeft: 8,
    overflow: 'hidden',
    textOverflow: 'ellipsis',
    whiteSpace: 'nowrap',

hungvu193 · 2023-07-25T03:17:29Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long emoji names are not being truncated and icons displayed at the start

What is the root cause of that problem?

We didn't define a width for our emoji text which cause the issue.

App/src/styles/styles.js

Lines 204 to 206 in 6e6d2bd

    
           emojiSuggestionsText: { 
        
               fontSize: variables.fontSizeMedium, 
        
           },

What changes do you think we should make in order to solve the problem?

We should add width: "100%" or flex: 1 to the emojiSuggestionsText.

    emojiSuggestionsText: {
     // we can also add some padding right here to make it symmetrical with the left.
       fontSize: variables.fontSizeMedium,
        flex: 1,
        paddingRight: 10,
        ...wordBreak.breakWord,
    },

What alternative solutions did you explore? (Optional)

N/A

Result:

Screen.Recording.2023-07-26.at.06.52.36.mov

jfquevedol2198 · 2023-07-25T04:51:15Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long emoji names are not being truncated and icons displayed at the start

What is the root cause of that problem?

App/src/components/EmojiSuggestions.js

Line 72 in b7d17e0

numberOfLines of Text in this line is not specified and styles are not correct.

What changes do you think we should make in order to solve the problem?

We can do same like MentionSuggestions

Update these lines as follows:

 <View style={[styles.autoCompleteSuggestionContainer, styles.ph2]}>
    <Text style={styles.emojiSuggestionsEmoji}>{EmojiUtils.getEmojiCodeWithSkinColor(item, props.preferredSkinToneIndex)}</Text>
    <Text style={[styles.emojiSuggestionsText, styles.flex1]}>

Styles Update:

    emojiSuggestionsEmoji: {
        fontSize: variables.fontSizeMedium,
        width: variables.fontSizeMedium,
        textAlign: 'center',
    },
    emojiSuggestionsText: {
        fontSize: variables.fontSizeMedium,
        ...spacing.ml2,
        ...wordBreak.breakAll
    },

Android

iOS

Web

mWeb - Chrome

mWeb - Safari

What alternative solutions did you explore? (Optional)

Update this line as follows:

    <Text style={[styles.emojiSuggestionsText, styles.flex1, styles.pr4]}>

Styles Update:

    emojiSuggestionsText: {
        fontSize: variables.fontSizeMedium,
        ...wordBreak.breakAll
    },

joekaufmanexpensify · 2023-07-25T20:45:02Z

Reproduced. Though, I don't think we'd truncate the emojis that don't fit on one line. We should break them onto a second line (like we do for these same emojis in the android native app).

melvin-bot · 2023-07-25T20:45:10Z

Job added to Upwork: https://www.upwork.com/jobs/~01245a38493bcc690f

melvin-bot · 2023-07-25T20:45:14Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-25T20:45:19Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

jfquevedol2198 · 2023-07-25T20:51:12Z

@joekaufmanexpensify
We can add numberOfLines={2} with other changes
[Updated Proposal]

Web

Mobile

allroundexperts · 2023-07-25T23:46:34Z

@jfquevedol2198 Please do not post code diff in your proposals.

Regarding your mentioned solution. I don't think it will handle the case where text is spread over 3 or more lines.

allroundexperts · 2023-07-25T23:47:37Z

@hungvu193 and @s-alves10 You might want to update your proposals as well based on this feedback.

allroundexperts · 2023-07-25T23:48:00Z

Still looking for better proposals.

hungvu193 · 2023-07-25T23:53:20Z

@allroundexperts Updated my proposal for multiple lines case #23519 (comment)

jfquevedol2198 · 2023-07-26T00:01:37Z

@allroundexperts Updated my proposal.
It supports multilines and identical gaps between emoji and emoji name and it keeps consistency with MentionSuggestions

s-alves10 · 2023-07-26T01:20:34Z

Proposal

Updated

allroundexperts · 2023-07-26T10:52:44Z

@hungvu193's updated proposal looks good to me as they were the first to propose a solution that works for multiline. The subsequent updated proposals were essentially doing the same thing.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-07-26T10:52:50Z

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

s-alves10 · 2023-07-26T11:37:11Z

@allroundexperts

multiline was added later. Why don't we consider that?
In addition, I spent more time to find out perfect solution for all platforms. I think this should be considered

jfquevedol2198 · 2023-07-26T13:23:58Z

@allroundexperts
My proposal was the first one to use flex and keep consistency with MentionSuggestions which worked already perfectly. and my solution keeps same gaps between icon and emojiText.

How to implement

And, I also spent time to find better solution because hungvu193's solution didn't work for Mobile before multiline.

jfquevedol2198 · 2023-07-26T13:30:07Z

@allroundexperts
I hope you compare mine and others:

My solution	Others' solution

hungvu193 · 2023-07-26T13:39:40Z

I already suggested adding flex, or width: 100% in my first proposal. Please check my editing history. I can't say I spent more time than anyone else here, but I did spend my time to make sure my solution worked on all platform. Not sure why we're arguing here.

melvin-bot · 2023-08-01T17:53:50Z

🎯 ⚡️ Woah @allroundexperts / @hungvu193, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @hungvu193 got assigned: 2023-07-28 19:47:17 Z
when the PR got merged: 2023-08-01 17:53:49 UTC

On to the next one 🚀

melvin-bot · 2023-08-03T17:06:57Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-08-03T17:07:02Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Long emoji names are not being truncated and icons displayed at the start #23878

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment offer (Contributor)
@allroundexperts does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-08-03T17:07:03Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR: Static emoji autosuggestion #14686
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/14686/files#r1290971864
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1691737975785319
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

joekaufmanexpensify · 2023-08-07T13:09:44Z

@allroundexperts mind completing the BZ checklist here when you have a sec? TY!

joekaufmanexpensify · 2023-08-09T20:21:00Z

Not overdue.

allroundexperts · 2023-08-11T07:15:56Z

Checklist

The PR that introduced the bug has been identified. Link to the PR: Static emoji autosuggestion #14686
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/14686/files#r1290971864
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1691737975785319
I think a regression test might not be needed here since this is really an rare use case. If someone disagrees, then the steps are the following.

Regression Steps

On mobile web, Go to Settings > Preferences.
Select Spanish language.
Go back and open a chat.
Type ":pist" in the chat

Verify that the emoji name appears in two lines.

Do we 👍 or 👎

joekaufmanexpensify · 2023-08-11T12:53:08Z

Thanks! I agree no test needed here. This is niche. BZ checklist complete, so all set to issue payment!

joekaufmanexpensify · 2023-08-11T12:56:40Z

This qualifies for urgency, so we need to issue the following payments:

@hungvu193 $1,500 ($1000 for PR and $500 speed bonus). Paid via upwork.
@allroundexperts $1,500 ($1000 for C+ review and $500 speed bonus). Paid via NewDot.
@ayazhussain79 $250 for reporting bonus. Paid via upwork.

joekaufmanexpensify · 2023-08-11T13:05:54Z

@ayazhussain79 offer sent for $250!

joekaufmanexpensify · 2023-08-11T13:06:56Z

@hungvu193 $1,500 sent and contract ended!

joekaufmanexpensify · 2023-08-11T13:07:17Z

@allroundexperts could you please request $1,500 via NewDot and confirm here once requested?

ayazhussain79 · 2023-08-11T13:12:02Z

@joekaufmanexpensify offer accepted, Thank you

allroundexperts · 2023-08-11T13:14:48Z

Requested @joekaufmanexpensify!

joekaufmanexpensify · 2023-08-11T13:58:43Z

@ayazhussain79 $250 sent and contract ended!

joekaufmanexpensify · 2023-08-11T13:58:54Z

Upwork job closed.

joekaufmanexpensify · 2023-08-11T14:00:19Z

Closing as this is all set! The only thing left is for our internal admin to pay @allroundexperts (request has been submitted). Please LMK if your request is not paid within the next 7 days, and I will investigate.

Noting for the admin who pays that payment summary message is here!

JmillsExpensify · 2023-08-15T16:31:00Z

Reviewed the details for @allroundexperts. Approved for payment in NewDot based on BZ summary above.

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 24, 2023

melvin-bot bot assigned joekaufmanexpensify Jul 24, 2023

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Jul 25, 2023

melvin-bot bot changed the title ~~Long emoji names are not being truncated and icons displayed at the start~~ [$1000] Long emoji names are not being truncated and icons displayed at the start Jul 25, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 25, 2023

melvin-bot bot assigned allroundexperts Jul 25, 2023

melvin-bot bot assigned marcochavezf Jul 26, 2023

melvin-bot bot added the Weekly KSv2 label Jul 30, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 3, 2023

melvin-bot bot changed the title ~~[$1000] Long emoji names are not being truncated and icons displayed at the start~~ [HOLD for payment 2023-08-10] [$1000] Long emoji names are not being truncated and icons displayed at the start Aug 3, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Aug 3, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 9, 2023

melvin-bot bot removed the Overdue label Aug 9, 2023

allroundexperts mentioned this issue Aug 11, 2023

Static emoji autosuggestion #14686

Merged

54 tasks

joekaufmanexpensify closed this as completed Aug 11, 2023

[HOLD for payment 2023-08-10] [$1000] Long emoji names are not being truncated and icons displayed at the start #23519

[HOLD for payment 2023-08-10] [$1000] Long emoji names are not being truncated and icons displayed at the start #23519

Comments

kavimuru commented Jul 24, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 24, 2023

melvin-bot bot commented Jul 24, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

s-alves10 commented Jul 24, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

hungvu193 commented Jul 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result:

jfquevedol2198 commented Jul 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

joekaufmanexpensify commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023

melvin-bot bot commented Jul 25, 2023

jfquevedol2198 commented Jul 25, 2023 • edited Loading

allroundexperts commented Jul 25, 2023 • edited Loading

allroundexperts commented Jul 25, 2023

allroundexperts commented Jul 25, 2023

hungvu193 commented Jul 25, 2023

jfquevedol2198 commented Jul 26, 2023 • edited Loading

s-alves10 commented Jul 26, 2023

Proposal

allroundexperts commented Jul 26, 2023 • edited Loading

melvin-bot bot commented Jul 26, 2023

s-alves10 commented Jul 26, 2023 • edited Loading

jfquevedol2198 commented Jul 26, 2023 • edited Loading

jfquevedol2198 commented Jul 26, 2023

hungvu193 commented Jul 26, 2023 • edited Loading

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 3, 2023

melvin-bot bot commented Aug 3, 2023 • edited by joekaufmanexpensify Loading

melvin-bot bot commented Aug 3, 2023 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented Aug 7, 2023

joekaufmanexpensify commented Aug 9, 2023

allroundexperts commented Aug 11, 2023

Checklist

Regression Steps

joekaufmanexpensify commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

ayazhussain79 commented Aug 11, 2023

allroundexperts commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

joekaufmanexpensify commented Aug 11, 2023

JmillsExpensify commented Aug 15, 2023

kavimuru commented Jul 24, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 24, 2023 •

edited by joekaufmanexpensify

Loading

s-alves10 commented Jul 24, 2023 •

edited

Loading

hungvu193 commented Jul 25, 2023 •

edited

Loading

jfquevedol2198 commented Jul 25, 2023 •

edited

Loading

jfquevedol2198 commented Jul 25, 2023 •

edited

Loading

allroundexperts commented Jul 25, 2023 •

edited

Loading

jfquevedol2198 commented Jul 26, 2023 •

edited

Loading

allroundexperts commented Jul 26, 2023 •

edited

Loading

s-alves10 commented Jul 26, 2023 •

edited

Loading

jfquevedol2198 commented Jul 26, 2023 •

edited

Loading

hungvu193 commented Jul 26, 2023 •

edited

Loading

melvin-bot bot commented Aug 3, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Aug 3, 2023 •

edited by joekaufmanexpensify

Loading