[HOLD for payment 2023-08-16] [$1000] Web - No margin between composer box and whisper message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select new room option
2. Enter room name, add admin as who can post and set visibility to public
3. Click on create room button
4. Go to room report screen and click on header
5. Go to Share code and copy code
6. Paste that url to other users browser to add that user in room
7. Change who can post from admin to All members
8. Check space between composer box and whisper message
   in other users

Expected Result:

Should be some space between composer box and whisper message

Actual Result:

No space between composer box and whisper message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.45-8
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-26.at.5.15.20.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690374276965949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01885f7f425c61dd68
• Upwork Job ID: 1684801738734956544
• Last Price Increase: 2023-07-28
• Automatic offers:
• situchan | Reviewer | 25936924
• Pujan92 | Contributor | 25936926
• gadhiyamanan | Reporter | 25936927

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No gap between composer and the whisper message after changing the room settings

What is the root cause of that problem?

For the writeCapability we are not rerendering the ReportActionsView which is the cause of the issue and won't update the shouldOmitBottomSpace in ReportActionsList with new report data.

App/src/pages/home/report/ReportActionsView.js

Line 350 in 3d22f59

function arePropsEqual(oldProps, newProps) {

App/src/pages/home/report/ReportActionsList.js

Lines 168 to 170 in 3d22f59

	const isArchivedRoom = ReportUtils.isArchivedRoom(props.report);
	const hideComposer = ReportUtils.shouldHideComposer(props.report, errors);
	const shouldOmitBottomSpace = hideComposer || isArchivedRoom;

What changes do you think we should make in order to solve the problem?

Add writeCapability field condition within arePropsEqual function to rerender the component on its changed value.

    if (lodashGet(newProps, 'report.writeCapability') !== lodashGet(oldProps, 'report.writeCapability')) {
        return false;
    }

We can also update the code to remove const isArchivedRoom = ReportUtils.isArchivedRoom(props.report); as shouldHideComposer function already checking the isArchivedRoom.

[kadiealexander]

Repro:

2023-07-28_17-42-35.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01885f7f425c61dd68

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[situchan]

@Pujan92's proposal looks good to me. We can only do the main fix here - re-render on writeCapability update.

We can also update the code to remove const isArchivedRoom = ReportUtils.isArchivedRoom(props.report); as shouldHideComposer function already checking the isArchivedRoom.

This will be done in #22389

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@thienlnam, @kadiealexander, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[thienlnam]

Just assigned

[Pujan92]

@situchan PR is ready for review!

[melvin-bot]

🎯 ⚡️ Woah @situchan / @Pujan92, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @Pujan92 got assigned: 2023-08-04 00:06:59 Z
• when the PR got merged: 2023-08-07 17:47:41 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: No margin between composer box and whisper message #24179

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Add ability for admins to restrict who can post within rooms #19094
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add ability for admins to restrict who can post within rooms #19094 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

As this is minor UI bug and edge case that rarely happens, I don't think regression test is needed

[kadiealexander]

Sorry team I'm not sure why this never switched to Daily!

[kadiealexander]

Payouts due:

• Issue Reporter: $250 @gadhiyamanan
• Contributor: $1000 + $500 bonus @Pujan92
• Contributor+: $1000 + $500 bonus @situchan

Eligible for 50% #urgency bonus? Yes

Upwork job is here.