Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: After deleting request money on Workspace, navigate to Concierge #24123

Closed
1 of 6 tasks
kavimuru opened this issue Aug 3, 2023 · 12 comments
Closed
1 of 6 tasks

DEV: After deleting request money on Workspace, navigate to Concierge #24123

kavimuru opened this issue Aug 3, 2023 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Aug 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-condition: Have a workspace

  1. Click FAB => Request money
  2. Input amount => Next
  3. Select workspace = request
  4. Click on request money message
  5. Hover on cash message => delete
  6. Observe navigate to the previous report and then navigate to Concierge

Expected Result:

Observe navigate to the previous report the same with request money for user

Actual Result:

navigate to the previous report and then navigate to Concierge

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-03.at.09.16.19.mov

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691028842094869

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mvtglobally
Copy link

potentially related to #20908

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 3, 2023

As @mvtglobally pointed out, this is an existing bug that is being fixed in #20908

Removing deploy blocker label and will keep track of this issue in the issue mentioned above

Also changing the priority to weekly

@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 3, 2023
@hayata-suenaga
Copy link
Contributor

actually changing the priority to monthly as the above issue where the cause is being fix has a monthly label (the fix needs a change in a library we rely on, and changing a library takes a time)

@hayata-suenaga hayata-suenaga added Monthly KSv2 and removed Weekly KSv2 Needs Reproduction Reproducible steps needed labels Aug 3, 2023
@PauloGasparSv PauloGasparSv changed the title DEV: After deleting request money on Workspace, navigate to Concierge [HOLD App #20908] DEV: After deleting request money on Workspace, navigate to Concierge Aug 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@sakluger sakluger added Daily KSv2 and removed Monthly KSv2 labels Sep 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@sakluger sakluger changed the title [HOLD App #20908] DEV: After deleting request money on Workspace, navigate to Concierge DEV: After deleting request money on Workspace, navigate to Concierge Sep 5, 2023
@sakluger
Copy link
Contributor

sakluger commented Sep 5, 2023

Looks like the HOLD issue was fixed by another issue. @hayata-suenaga what does that mean for this issue?

@hayata-suenaga
Copy link
Contributor

@sakluger thank you for letting me know about it

I tested the bug reproduction flow and confirmed that the issue was fixed by this PR.

@sakluger could you check if we need payment to the bug reporter and then close the issue 🙇

Screen.Recording.2023-09-05.at.1.07.56.PM.mov

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@sakluger, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@sakluger, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

@sakluger
Copy link
Contributor

Thanks @hayata-suenaga!

All the issues linked to that PR were reported in June, and this issue was reported on Aug 2, so I don't think we need to pay for this bug report.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants