Deploy Checklist: New Expensify 2023-08-03

[OSBotify]

Release Version: 1.3.50-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update App to React Native 0.72 version #18507
• Setup App for TypeScript #20179
• Match Report Header and LHN Avatars  #22467
• Migrate FloatingMessageCounter to function component #22912
• Add ability to Take/Upload Receipts #23046
• Fix/19483 close anchor popup #23152
• Migrate to functional component #23272
• Fix 22306 web appropriate message is not shown when drag drop a folder #23321
• Disabling spell check on multiple pages #23447
• Remove unused Modal/index.js file #23462
• Workspace tooltip #23527
• Append current time to the downloaded file name #23531
• Update header subtitle styles for thread (child) reports #23621
• Fix currency changes after refresh although URL has currency params #23636
• Fix: hide draft icon when composer hides #23641
• Add merchant and date fields to manual requests #23648
• updated regex for legal name and cardholder name #23650
• fix: Select and copy does not copy New Expensify link in link format #23704
• feat: task view with offline with feedback #23705
• Fix workspace icon border radius is different than the overlay #23707
• Fix "Deleted message" chat appears in chat list for pinned deleted threads #23715
• Replace policyIDList with policyIDToLastModified map in Reconnect App call #23748
• Feature : Improve display of error message on AvatarWithImagePicker #23754
• Use installation token for OS Botify #23760
• fix redundant api call on priority page #23772
• use getIconsForParticipants for icons in getAssignee in Task #23773
• Fix: regex execution Maximum regex stack depth reached error #23774
• Parent Message of thread chat on LHN doesn't updated when the parent message is updated #23777
• update composer comment when language changed. #23779
• Corrected regression from issue 21838 #23780
• Web - Loader appears for a second while switch between chats #23781
• Disable go to profile page for optimistic user #23802
• Only show settlement button if total is not 0 #23828
• Fix FullPageNotFoundView in ReimbursementAccountPage #23843
• Fix empty workspace name in money requests confirmation page #23844
• fix: 23811 handle mentions renderer not receiving props #23845
• Refactor EmojiPickerMenu native to functional component and using scrollTo method #23854
• Migrated Switch to function component syntax #23857
• Migrate withDelayToggleButtonState.js to function component #23860
• Fix: Long emoji names are not being truncated and icons displayed at the start #23878
• migrated ScrollViewWithContext to a functional component #23879
• Convert Date Picker to Functional Component #23880
• Prevent user from visiting archived room setting #23907
• migration from class to functional component #23911
• [23304] Update tasks status color. #23912
• Update Onfido SDK to 13.1.0 #23915
• fix: disable confirm button if offline #23917
• Fix/23818 - Polish admins-only policy room - Clear "Form's" states correctly #23919
• gray out date for settled money requests in MoneyRequestView #23927
• fix: 22507 Blank Page Displayed when Copying and Pasting URL next to Original URL and Reloading with Enter Key #23931
• Migrate BaseReportActionContextMenu.js to fc component. #23934
• Fix crash on opening money request page after sign ing #23937
• Fix Tasks assigned disappears from LHN when leaving the chat in focus mode #23938
• Persist failed personal details when adding workspace member #23947
• Update frequently used emojis in state whenever its onyx key changes #23965
• Update Task Permissions #23971
• Prevent link opening on click outside Link #23972
• Card rev shareExpensifyHelp page. #23975
• Fix cursor on pdf view web #23976
• Fix crash app when opening split bill detail page by deep link #23977
• request money open workspace details when selected workspace clicked. #23980
• Onfido SDK: Remove the deprecated uploadFallback prop #23983
• [CP Staging] Return early when dismissing modal so we don't call onNavigate with no attachments #23988
• Fix incorrect user display name tooltip position in money request confirmation page #23990
• [CP Staging] [Revert] Perf/onyx upgrade use cache directly #24003
• [CP Staging] Remove reference to missing method #24010
• Fix: resetting the country/state picker when it is reopened #24023
• Revert "fix: show main composer when there is no focused draft" #24025
• Fix: update AttachmentModal translation #24035
• Fix wrong lottie animations names #24036
• [Improvement] Introduce label props to statePicker & stateSelectorModal #24037
• Fix link preview size #24052
• Revert "Use installation token for OS Botify" #24060
• MoneyRequest: use ScreenWrapper only if editing #24097
• [CP Staging] Make sure medium avatar size gets medium container size #24109

Deploy Blockers:

• DEV: After deleting request money on Workspace, navigate to Concierge #24123
• [HOLD for payment 2023-08-16] User can't click on header to open detail of public room #24124
• [HOLD for payment 2023-08-16] Profile - Zoom and rotate button doesn't work for uploading avatar image #24131
• [HOLD for payment 2023-08-16] [$1000] IOS - Unable to send message after copying  #24147
• [HOLD for payment 2023-09-21] [$1000] Compose box - Cursor at left instead of right side while editing the comment #24157
• [HOLD for payment 2023-09-15] [$1000] Android - Request money - Different app behavior when asking for camera permission in Scan receipt #24160
• [Awaiting Payment August 17th] dev: Selecting image from file explorer doesn't open image previewer #24183
• [$1000] Chat - Send button is not enabled if only 1 character is typed after sending another message #24193

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Beamanator]

Oof we've got a lot of old PRs again 🙃 we can make a new section and check them off like last time (I'll help with that tomorrow morning)

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.50-0 🚀

[mvtglobally]

Checking off as previously tested
#22467
#22912
#23152
#23462
#23531
#23641
#23704
#23707
#23715
#23754
#23772
#23773
#23777
#23780
#23843
#23844
#23845
#23854
#23857
#23860
#23878
#23879
#23907
#23912
#23915
#23917
#23927
#23975
#23980
#23983
#23988
#24003
#24010
#24025
#24036
#24109

[Beamanator]

Checking off #24123 since we marked in NAB

[Beamanator]

Checking off #24131 b/c it was fixed & CP'd to staging 👍

[Beamanator]

Checking off #24160 since it's related to "receipt scanning" which is under beta - but it still should be fixed soon

[mvtglobally]

Can you help with #23648 (comment)

[Beamanator]

Yes @mvtglobally - i tested #23648 and checked it off b/c it's working well! 👍

[mvtglobally]

@Beamanator We are down to 2% TR left

Current summary
#23527 pending validation on all platforms
#23621 pending validation on all platforms
#23636 is failing with #23436
We are blocked #23648 (comment)
#23828 pending validation on all platforms
#23934 is failing #24147
#23938 is failing #24158
#23947 pending validation on all platforms
#23965 pending validation on all platforms
#23971 pending validation on all platforms
#23972 pending validation on all platforms
#23977 pending validation on all platforms

[Beamanator]

Thanks for the update @mvtglobally ! I have to head out now for the weekend, I posted in internal channels, mentioning your update 👍 So someone else mayyy take this over this afternoon, but most likely we'll pick this back up on Monday 👍

[Beamanator]

Last note for the day:

• this deploy blocker ([HOLD for payment 2023-08-16] User can't click on header to open detail of public room #24124) has a fix merged ([CP Staging] Fix user cannot open detail page of chat room #24091) that is currently being CP'd to staging 👍

[mvtglobally]

@Beamanator We are down to 1% TR left

Current summary
#23636 is failing with #23436
#23828 pending validation on all platforms
#23934 is failing #24147
#23938 is failing #24158
#23971 pending validation on all platforms
#23977 pending validation on all platforms

[mvtglobally]

Regression is completed

Current summary

• Fix currency changes after refresh although URL has currency params #23636 is failing with [HOLD for payment 2023-08-14] [$1000] Currency changes after refresh although URL has currency params  #23436
• Migrate BaseReportActionContextMenu.js to fc component. #23934 is failing [HOLD for payment 2023-08-16] [$1000] IOS - Unable to send message after copying  #24147
• Fix Tasks assigned disappears from LHN when leaving the chat in focus mode #23938 is failing Task - Ones opened task conv in Focus mode is not displayed in LHN anymore #24158
• Update Task Permissions #23971 is failing [HOLD for payment 2024-01-17] [$500] Tasks - User is unable to complete task without opening task first #24169
• Fix crash app when opening split bill detail page by deep link #23977 is pass on web/mWeb and blocked on the rest by [HOLD for payment 2023-09-21] [HOLD] [$1000] Chat - LHN page displayed instead Legal name page when using deeplink #23745

[Beamanator]

Checking #24124 off since its fix is on staging 👍

[Beamanator]

Checking off #24193 as we considered it a dupe

Checking off #24147 b/c we CPd its fix (#24203) to staging & it tested well, according to @MonilBhavsar

[puneetlath]

Checking off #24183 as it's only occurring on dev so isn't a deploy blocker.

[puneetlath]

Checking off #23934 based on this comment.

[puneetlath]

Checking off #23938 since it was already there on production, so even if it isn't working, it's not a deploy blocker. I've asked the issue assignees to re-test.

[puneetlath]

Checking off #23636 since it's not a deploy blocker. Commented in the PR so that they can address the fix not working.

[puneetlath]

Checking off #23971. I tested it on web and iOS staging and it seems to be working as expected.

[puneetlath]

Checking off #23977. I tested on iOS and it seems to be working.

[puneetlath]