Fix link preview size #24052

Nikhil-Vats · 2023-08-02T11:13:21Z

Details

Size of link previews was very big, this PR reduces it for both mobiles and desktops.

Fixed Issues

$ #23179
PROPOSAL: #23179 (comment)

Tests

You can use the following links to compare the size of link previews - facebook.com, youtube.com, cnn.com.

Send one or more of the links above in a chat.
Open the same chat on testing environment (staging for QA) and on prod (new.expensify.com).
Compare the size of link previews in testing and prod environment, size of preview should be lesser now.
Here is the exact change in size -
Before -
Large screen (web/desktop app) - max width = 350px, max height = 350px
Small screen (apps/browsers) - max width = 180px, max height = 180px but this was only being applied on browser (chrome/safari) and not on apps because of wrong logic in code
After -
On all screens sizes (mobile/desktop), preview size is same - max-width = 340px, max-height = 180px

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Before followed by after

Mobile Web - Chrome

Before followed by after - Here, mobile styles were being applied before as well, CNN preview was smaller because, max width was smaller (180px) and image also maintains the aspect ratio. Now, we have increased max width to 340px on all screens, so height is also allowed to be more (still less than max height 180px though).

Mobile Web - Safari

Before followed by after - Here, mobile styles were being applied before as well

Desktop

Before followed by after -

iOS

Before followed by after - Image also maintains the aspect ratio which also affects the width, height. See the formula.

Android

Before followed by after -

melvin-bot · 2023-08-02T11:13:27Z

@shawnborton @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nikhil-Vats · 2023-08-02T11:15:01Z

src/pages/home/report/LinkPreviewer.js


    useEffect(() => {
-        setMaxImageSize(windowHeight / 2 < MAX_IMAGE_SIZE ? SMALL_SCREEN_MAX_IMAGE_SIZE : MAX_IMAGE_SIZE);


This condition was true for browsers on mobile, so mobile styles were being applied on browsers on mobile but not for mobile apps.

Nikhil-Vats · 2023-08-02T11:15:52Z

src/pages/home/report/LinkPreviewer.js

@@ -120,10 +124,10 @@ function LinkPreviewer(props) {
                                    styles.linkPreviewImage,
                                    {
                                        aspectRatio: image.width / image.height,


image also keeps the aspect ratio maintained which also affects the height and width.

Nikhil-Vats · 2023-08-02T11:16:20Z

Hey @aimane-chnaif, PR is ready for review.

shawnborton · 2023-08-02T12:39:54Z

Thanks for spinning this up! So after seeing this, I feel like we might want to make the max-height on desktop even smaller. Perhaps we just go with what mobile has at 180?

Nikhil-Vats · 2023-08-02T13:48:27Z

Ok @shawnborton. I would also like to confirm - what should be the max-width on desktop - 180px/240px/350px? On mobile, it is 340px.

Web

240px followed by 180px (both max-width and max-height)

Desktop

240px followed by 180px (both max-width and max-height)

shawnborton · 2023-08-02T14:00:25Z

Maybe we can do the same max-width for both desktop & mobile? And same for height? Just to keep things simple. So that might be say 340px max-width on desktop & mobile, 180px max-height on desktop & mobile. Thoughts?

Nikhil-Vats · 2023-08-02T14:07:41Z

Yeah, that looks okay for both.

Web

Mobile

shawnborton · 2023-08-02T14:08:48Z

Nice, let's do that then. Thanks for being flexible here!

Nikhil-Vats · 2023-08-02T14:20:04Z

@aimane-chnaif, PR and test proofs updated as per latest design.

aimane-chnaif · 2023-08-02T19:43:44Z

While testing, previews are randomly duplicated (i.e. google.com shows instagram logo in my video) but not a blocker as it's not caused by this PR.
Not able to find consistent reproducible step.

Screen.Recording.2023-08-02.at.8.41.40.PM.mov

aimane-chnaif · 2023-08-02T19:58:10Z

@Nikhil-Vats thanks for following design feedback and quick fixes.

aimane-chnaif · 2023-08-02T20:01:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

LGTM 🎉

dangrous

Code looks good! I see we had an update from @shawnborton that made this much simpler, since now desktop and mobile are just the same.

@Nikhil-Vats can you update your test steps in the PR description to match the new code? It's still saying desktop and mobile are different in the After section which - unless I misread - is not true anymore. Thank you!

Once that's done I can merge.

Nikhil-Vats · 2023-08-03T01:58:39Z

Hey @dangrous, I have updated the PR description.

OSBotify · 2023-08-03T14:35:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-03T17:40:55Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:29:15Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:56:28Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:45:36Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix link preview size

b1abd96

Nikhil-Vats requested a review from a team as a code owner August 2, 2023 11:13

melvin-bot bot requested review from aimane-chnaif and shawnborton and removed request for a team August 2, 2023 11:13

Nikhil-Vats commented Aug 2, 2023

View reviewed changes

Configure same size for desktop and mobile

716230d

aimane-chnaif approved these changes Aug 2, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous August 2, 2023 20:01

dangrous approved these changes Aug 2, 2023

View reviewed changes

dangrous merged commit f3e4f7c into Expensify:main Aug 3, 2023
14 checks passed

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

Nikhil-Vats mentioned this pull request Aug 9, 2023

[$1000] Chat - Link preview image size not fixed #23179

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix link preview size #24052

Fix link preview size #24052

Nikhil-Vats commented Aug 2, 2023 •

edited

Loading

melvin-bot bot commented Aug 2, 2023

Nikhil-Vats Aug 2, 2023

Nikhil-Vats Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

shawnborton commented Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

shawnborton commented Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

shawnborton commented Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

aimane-chnaif commented Aug 2, 2023

aimane-chnaif commented Aug 2, 2023

aimane-chnaif commented Aug 2, 2023

aimane-chnaif left a comment

dangrous left a comment

Nikhil-Vats commented Aug 3, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023


		useEffect(() => {
		setMaxImageSize(windowHeight / 2 < MAX_IMAGE_SIZE ? SMALL_SCREEN_MAX_IMAGE_SIZE : MAX_IMAGE_SIZE);

Fix link preview size #24052

Fix link preview size #24052

Conversation

Nikhil-Vats commented Aug 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 2, 2023

Nikhil-Vats Aug 2, 2023

Choose a reason for hiding this comment

Nikhil-Vats Aug 2, 2023

Choose a reason for hiding this comment

Nikhil-Vats commented Aug 2, 2023

shawnborton commented Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

shawnborton commented Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

shawnborton commented Aug 2, 2023

Nikhil-Vats commented Aug 2, 2023

aimane-chnaif commented Aug 2, 2023

aimane-chnaif commented Aug 2, 2023

aimane-chnaif commented Aug 2, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

Nikhil-Vats commented Aug 3, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

Nikhil-Vats commented Aug 2, 2023 •

edited

Loading