feat: task view with offline with feedback #23705

allroundexperts · 2023-07-27T01:47:03Z

Details

This PR adds OfflineWithFeedback component to the TaskView when the title / description or the assignee is changed. This PR does not cover the offline completion of the report.

Fixed Issues

$ #23200
PROPOSAL: #23200 (comment)

Tests

Go to any Task report
Turn off network
Update task title/description/assignee
Verify that the updated fields are greyed out
Turn on the network and verify that fields are not greyed out
Turn off the network again and verify that fields are not greyed out

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Go to any Task report
Turn off network
Update task title/description/assignee
Verify that the updated fields are greyed out
Turn on the network and verify that fields are not greyed out
Turn off the network again and verify that fields are not greyed out

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-27.at.6.21.31.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-27.at.6.32.53.AM.mov

Mobile Web - Safari

Screen.Recording.2023-07-27.at.6.30.14.AM.mov

Desktop

Screen.Recording.2023-07-27.at.6.27.01.AM.mov

iOS

Screen.Recording.2023-07-27.at.6.38.14.AM.mov

Android

Screen.Recording.2023-07-27.at.6.36.07.AM.mov

melvin-bot · 2023-07-27T01:47:08Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/actions/Task.js

mollfpr · 2023-07-27T13:01:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

23705.Web.mp4

Mobile Web - Chrome

23705.mWeb-Chrome.mp4

Mobile Web - Safari

23705.mWeb-Safari.mp4

Desktop

23705.Desktop.mp4

iOS

23705.iOS.mp4

Android

23705.Android.mp4

mollfpr

LGTM and tests well 🚀

neil-marcellini

Looking pretty good, but I want to make sure we handle the error case well too. Please feel free to DM me on NewDot if you have questions.

src/libs/actions/Task.js

src/components/ReportActionItem/TaskView.js

allroundexperts · 2023-07-28T01:33:53Z

@neil-marcellini Done with your requested changes. Here's how its working now:

Screen.Recording.2023-07-28.at.6.30.39.AM.mov

mollfpr · 2023-07-28T15:50:55Z

@allroundexperts Should the updated field be reverted after dismissing the RBR? I see in your video above the title is not reverted.

allroundexperts · 2023-07-28T15:58:48Z

@allroundexperts Should the updated field be reverted after dismissing the RBR? I see in your video above the title is not reverted.

It should be reverted as soon as the failure data arrives IMO. In video, I'm manually setting Onyx data while being offline so the failure response from backend never arrives.

neil-marcellini · 2023-07-28T21:23:24Z

src/libs/actions/Task.js

+ *
+ * @param {Object} report
+ */
+function clearEditTaskErrors(report) {


NAB: Let's pass only what we need, which is the reportID.

src/libs/actions/Task.js

neil-marcellini

Looking great. The only thing is that I think we should move the error above the line separating the task from the comments. I'll get some design feedback too.

neil-marcellini · 2023-07-28T21:33:33Z

src/libs/actions/Task.js

@@ -756,6 +751,18 @@ function isTaskAssigneeOrTaskOwner(taskReport, sessionAccountID) {
    return sessionAccountID === getTaskOwnerAccountID(taskReport) || sessionAccountID === getTaskAssigneeAccountID(taskReport);
 }

+/**
+ * Clears any possible stored errors for a specific field on a task report


NAB: More simply; "Clear errors from editing a task".

Actually, we don't need a description at all. It's quite simple.

App/contributingGuides/STYLE.md

Line 170 in a30f549

- Avoid descriptions that don't add any additional information. Method descriptions should only be added when it's behavior is unclear.

neil-marcellini · 2023-07-28T21:38:00Z

I prefer this option for displaying the error that Sibtain showed. @shawnborton do you agree?

shawnborton · 2023-07-31T12:18:53Z

Works for me!

src/components/ReportActionItem/TaskView.js

neil-marcellini

Other than that the code looks good

neil-marcellini

Looks good!

OSBotify · 2023-08-03T16:38:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

allroundexperts · 2023-08-03T16:42:45Z

@neil-marcellini Is this eligible for bonus? Asking because you were OoO and this had some added scope as well.

OSBotify · 2023-08-03T17:40:49Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:29:09Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:56:19Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:45:27Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh · 2024-02-22T14:20:20Z

src/components/ReportActionItem/TaskView.js

+                        />
+                    </OfflineWithFeedback>
+                ) : (
+                    <MenuItemWithTopDescription


Coming from #35196, we should have wrapped MenuItemWithTopDescription with the OfflineWithFeedback to support the offline mode. In offline mode, tasks created without an assignee will not have offline feedback.

feat: task view with offline with feedback

034680f

allroundexperts requested a review from a team as a code owner July 27, 2023 01:47

melvin-bot bot requested review from mollfpr and removed request for a team July 27, 2023 01:47

Merge branch 'main' into fix-23200

0965cb3

allroundexperts mentioned this pull request Jul 27, 2023

[HOLD for payment 2023-08-17] [$1000] Update Task title/description/assignee when offline is not grey out #23200

Closed

6 tasks

mollfpr reviewed Jul 27, 2023

View reviewed changes

src/libs/actions/Task.js Show resolved Hide resolved

feat: reset pending fields for failure data

9a88b34

allroundexperts requested a review from mollfpr July 27, 2023 11:45

feat: add pending fields wrapper

294a46c

mollfpr approved these changes Jul 27, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini July 27, 2023 13:09

neil-marcellini requested changes Jul 27, 2023

View reviewed changes

src/libs/actions/Task.js Outdated Show resolved Hide resolved

src/components/ReportActionItem/TaskView.js Outdated Show resolved Hide resolved

src/components/ReportActionItem/TaskView.js Show resolved Hide resolved

allroundexperts added 2 commits July 28, 2023 05:43

feat: add error state to tasks

7f84799

feat: trigger re-render if errorFields are not equal

19077e1

allroundexperts requested a review from neil-marcellini July 28, 2023 01:33

feat: lint errors

31b79e6

mollfpr approved these changes Jul 28, 2023

View reviewed changes

neil-marcellini reviewed Jul 28, 2023

View reviewed changes

neil-marcellini requested changes Jul 28, 2023

View reviewed changes

feat: move the error dot above the horizontal line in task view

14198e8

allroundexperts requested a review from neil-marcellini July 28, 2023 21:46

neil-marcellini requested changes Aug 2, 2023

View reviewed changes

src/components/ReportActionItem/TaskView.js Outdated Show resolved Hide resolved

neil-marcellini reviewed Aug 2, 2023

View reviewed changes

feat: resolve conflicts and comments

0cdcff4

allroundexperts requested a review from neil-marcellini August 3, 2023 07:37

feat: remove isAssignee function

cdd9fba

neil-marcellini approved these changes Aug 3, 2023

View reviewed changes

neil-marcellini merged commit d33b92d into Expensify:main Aug 3, 2023
11 checks passed

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

situchan mentioned this pull request Aug 4, 2023

Fix invited members does not reflect in offline mode #22410

Merged

58 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

fedirjh reviewed Feb 22, 2024

View reviewed changes

fedirjh mentioned this pull request Feb 22, 2024

[HOLD for payment 2024-02-20] [$500] Task - The assignee ">" arrow is not grayed out when creating tasks offline #35196

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: task view with offline with feedback #23705

feat: task view with offline with feedback #23705

allroundexperts commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

mollfpr commented Jul 27, 2023 •

edited

Loading

mollfpr left a comment

neil-marcellini left a comment

allroundexperts commented Jul 28, 2023

mollfpr commented Jul 28, 2023

allroundexperts commented Jul 28, 2023

neil-marcellini Jul 28, 2023

allroundexperts Jul 28, 2023

neil-marcellini left a comment

neil-marcellini Jul 28, 2023

allroundexperts Jul 28, 2023

neil-marcellini commented Jul 28, 2023

shawnborton commented Jul 31, 2023

neil-marcellini left a comment

neil-marcellini left a comment

OSBotify commented Aug 3, 2023

allroundexperts commented Aug 3, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

fedirjh Feb 22, 2024

feat: task view with offline with feedback #23705

feat: task view with offline with feedback #23705

Conversation

allroundexperts commented Jul 27, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 27, 2023

mollfpr commented Jul 27, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

allroundexperts commented Jul 28, 2023

mollfpr commented Jul 28, 2023

allroundexperts commented Jul 28, 2023

neil-marcellini Jul 28, 2023

Choose a reason for hiding this comment

allroundexperts Jul 28, 2023

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Jul 28, 2023

Choose a reason for hiding this comment

allroundexperts Jul 28, 2023

Choose a reason for hiding this comment

neil-marcellini commented Jul 28, 2023

shawnborton commented Jul 31, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 3, 2023

allroundexperts commented Aug 3, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

fedirjh Feb 22, 2024

Choose a reason for hiding this comment

mollfpr commented Jul 27, 2023 •

edited

Loading