Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment August 17th] dev: Selecting image from file explorer doesn't open image previewer #24183

Closed
1 of 6 tasks
kavimuru opened this issue Aug 6, 2023 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Aug 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open an existing chat
  2. Click on '+' icon
  3. Click on 'Add attachment'
  4. Select a picture

Expected Result:

Attachment preview should open

Actual Result:

File Explorer opened again

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-04.22-42-09.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691178392967439

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 6, 2023

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 6, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru removed the DeployBlockerCash This issue or pull request should block deployment label Aug 6, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 6, 2023
@trjExpensify
Copy link
Contributor

Looks like @allroundexperts has a PR in review for this. Presuming it's a regression, I don't need to assign you to this issue. @aimane-chnaif though for the review, right?

@aimane-chnaif
Copy link
Contributor

Right

@marcaaron marcaaron removed their assignment Aug 7, 2023
@trjExpensify trjExpensify removed the Needs Reproduction Reproducible steps needed label Aug 14, 2023
@trjExpensify trjExpensify changed the title dev: Selecting image from file explorer doesn't open image previewer [Awaiting Payment August 17th] dev: Selecting image from file explorer doesn't open image previewer Aug 14, 2023
@trjExpensify
Copy link
Contributor

Updated the title to reflect the payment date.

@trjExpensify
Copy link
Contributor

Okay, so confirming payments:

Is that correct, @aimane-chnaif?

@aimane-chnaif
Copy link
Contributor

No payment for me as this caused by the PR I reviewed

@trjExpensify
Copy link
Contributor

Ohh, I thought that was @allroundexperts. My bad! Cool, so offer sent to Natnael-Guchima

@aimane-chnaif
Copy link
Contributor

yes, on that PR, @allroundexperts was author (C), I was reviewer (C+)

@allroundexperts
Copy link
Contributor

We're both in the same boat ⛵⛵⛵

@trjExpensify
Copy link
Contributor

Looool. The party boat 😂

We're all settled up here. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants