Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Chat - Send button is not enabled if only 1 character is typed after sending another message #24193

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 7, 2023 · 13 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-requisite: user must be logged in and in any chat

  1. Type and send any message
  2. Type a new message with only 1 character

Expected Result:

The send button should be enabled after typing 1 character

Actual Result:

User must have to type more than 1 character for the send button to be enabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.50.0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6155681_Esbp2194_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010168816ae3accfb6
  • Upwork Job ID: 1688437010257268736
  • Last Price Increase: 2023-08-07
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 7, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@hungvu193
Copy link
Contributor

hungvu193 commented Aug 7, 2023

Feel like this is issue with our current react native version when multiline is enable. The commit caused this issue:
facebook/react-native@a804c0f

We can apply this diff (AudiusProject/audius-client#3622) to resolve this issue or waiting for our upstream to upgrade to latest RN version.

@techievivek
Copy link
Contributor

@hungvu193

Feel like this is issue with our current react native version when multiline is enable.

Did we enable multiline recently?

@hungvu193
Copy link
Contributor

@hungvu193

Feel like this is issue with our current react native version when multiline is enable.

Did we enable multiline recently?

Yep. you can try to set it to false in our Composer and this issue will be solved.

<Composer
checkComposerVisibility={() => this.checkComposerVisibility()}
autoFocus={this.shouldAutoFocus}
multiline
ref={this.setTextInputRef}

@techievivek techievivek added the External Added to denote the issue can be worked on by a contributor label Aug 7, 2023
@melvin-bot melvin-bot bot changed the title Chat - Send button is not enabled if only 1 character is typed after sending another message [$1000] Chat - Send button is not enabled if only 1 character is typed after sending another message Aug 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010168816ae3accfb6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@techievivek
Copy link
Contributor

@hungvu193 Okk, then using the patch sounds good to me.

@pradeepmdk
Copy link
Contributor

pradeepmdk commented Aug 7, 2023

already discussed here both are same issue #24147

@techievivek
Copy link
Contributor

techievivek commented Aug 7, 2023

@pradeepmdk ohh, thanks. We are discussing this internally if we should update the RN version or can we just patch-fix this.

@pradeepmdk
Copy link
Contributor

Thanks for the update @techievivek

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 7, 2023
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Aug 7, 2023

Closing, considering a dupe of #24147

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants