Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: show main composer when there is no focused draft" #24025

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

marcochavezf
Copy link
Contributor

Reverts #23618

cc @puneetlath

@marcochavezf marcochavezf requested a review from a team as a code owner August 1, 2023 22:45
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team August 1, 2023 22:45
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@puneetlath
Copy link
Contributor

Going to merge since this is a straight revert for a deploy blocker. Then CP to staging. @marcochavezf and I will then test on staging to make sure the deploy blocker is no longer happening.

@puneetlath puneetlath merged commit e41c6e3 into main Aug 1, 2023
10 of 12 checks passed
@puneetlath puneetlath deleted the revert-23618-fix/issue-17531 branch August 1, 2023 22:53
@melvin-bot melvin-bot bot added the Emergency label Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@marcochavezf
Copy link
Contributor Author

Removed Emergency label, explanation above

OSBotify pushed a commit that referenced this pull request Aug 1, 2023
Revert "fix: show main composer when there is no focused draft"

(cherry picked from commit e41c6e3)
@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2023

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2023

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.50-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants