Parent Message of thread chat on LHN doesn't updated when the parent message is updated #23777
Conversation
melvin-bot
bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| const reportID = propsToForward.reportID; | ||
| // We only want to pass a boolean to the memoized component, | ||
| // instead of a changing number (so we prevent unnecessary re-renders). | ||
| const isFocused = !shouldDisableFocusOptions && currentReportID === reportID; | ||
|
|
||
| const policy = lodashGet(policies, [`${ONYXKEYS.COLLECTION.POLICY}${fullReport.policyID}`], ''); | ||
|
|
||
| const parentReportAction = useMemo(() => parentReportActions[fullReport.parentReportActionID], [parentReportActions, fullReport.parentReportActionID]); |
There was a problem hiding this comment.
This is kind of unnecessary. Please revert this.
There was a problem hiding this comment.
I late realized it. Sorry.
There was a problem hiding this comment.
@parasharrajat We use parentntReportAction in dependency (line 90)
There was a problem hiding this comment.
I think we should not put parentReportActions (all report actions) into dependency, we only should listen a parent report of that thread
There was a problem hiding this comment.
I am not saying to put the whole parentReportActions into dependency but to remove useMemo and directly get the parent action from the object as
const parentReportAction = parentReportActions[id]
There is nothing being calculated from useMemo its use is unnecessary.
There was a problem hiding this comment.
@parasharrajat Sorry about that 😄 , I Just updated
|
@dukenv0307 Please let me know when updated. |
|
@parasharrajat I just updated. Please help to review again |
|
@parasharrajat Bump |
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
Screenshots🔲 iOS / nativeScreen.Recording.2023-07-31.at.10.23.50.AM.mov🔲 iOS / SafariScreen.Recording.2023-07-31.at.10.24.33.AM.mov🔲 MacOS / DesktopScreen.Recording.2023-07-31.at.10.19.41.AM.mov🔲 MacOS / ChromeScreen.Recording.2023-07-31.at.10.18.45.AM.mov🔲 Android / ChromeScreen.Recording.2023-07-31.at.10.23.17.AM.mov🔲 Android / nativeScreen.Recording.2023-07-31.at.10.26.50.AM.mov |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
Co-authored-by: Puneet Lath <puneet@expensify.com>
|
@puneetlath Updated |
|
Great thanks! Nice messi comments by the way 😄 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.49-0 🚀
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.50-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀
|
| @@ -156,5 +165,11 @@ export default React.memo( | |||
| key: ONYXKEYS.COLLECTION.POLICY, | |||
| }, | |||
| }), | |||
| withOnyx({ | |||
There was a problem hiding this comment.
We have withOnyx HOC already we why we are adding another one?
There was a problem hiding this comment.
Ops, I didn't notice. May be it came during merging main. Will fix this in a followup in not done already.
There was a problem hiding this comment.
@s77rt The second withOnyx is needed since the fullReport is only available after we successfully retrieve the data from Onyx with the previous withOnyx HOC
Please let me know if any concerns
cc @parasharrajat
There was a problem hiding this comment.
Ohhh, so dependent keys... @hannojg was talking about this earlier. Not sure what is the status..
| parentReportActions: { | ||
| key: ({fullReport}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fullReport.parentReportID}`, | ||
| canEvict: false, | ||
| }, |
There was a problem hiding this comment.
This will make the option row re-render whenever any report action change (and not just the parent report action). This can be fixed in two ways:
- Using Onyx selector but this actually does not take props (can't access fullReport.parentReportID), so we can't use this solution unfortunately https://expensify.slack.com/archives/C01GTK53T8Q/p1691169417094889
- Use React.memo custom comparator, by default the memo will compare
prevProps.parentReportActionswithnextProps.parentReportActions(which will be different if any report action chane), we should instead compareprevProps.parentReportActions[fullReport.parentReportActionID]withnextProps.parentReportActions[fullReport.parentReportActionID]
There was a problem hiding this comment.
My thought was that because we are already listening to a particular collection and when any item in that collection changes it will update.
Here
- When any action on the thread changes, it will rerender.
- But only one option row will be affected not all.
I couldn't think of any other optimization during PR review so moved as it is. The memo idea is good. @dukenv0307 Do you want to create a followup?
There was a problem hiding this comment.
@parasharrajat The PR to implement the memo custom comparator is ready for review: #24351
cc @s77rt
Details
Parent Message of thread chat on LHN doesn't updated when the parent message is updated
Fixed Issues
$ #23424
PROPOSAL: #23424 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.1.mp4
Mobile Web - Chrome
chrome.mp4
Mobile Web - Safari
safari.mp4
Desktop
desktop.2.mp4
iOS
ios.mov
Android
android.mp4