-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-06] [TS migration] Migrate 'getPlatform' constants dependency to TypeScript #24681
Comments
Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue! |
@fabioh8010 PR is ready for review! |
Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
PR merged 🚀 |
Merged PR introduces a regression |
You forgot to delete a file |
@shubham1206agra It wasn’t [TS migration] Migrate 'getPlatform' constants dependency to TypeScript which caused the regression. Actually it was [TS migration] Migrate 'CONFIG.js' constant to TypeScript 😢 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-06. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: