Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App Issue #25125] [TS migration] Migrate 'ArrowKeyFocusManager.js' component to TypeScript #24985

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 11 comments

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ArrowKeyFocusManager.js 4
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@fabioh8010
Copy link
Contributor

⚠️ Note

This component should be removed and its usage replaced with useArrowKeyFocusManager hook!

@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@filip-solecki
Copy link
Contributor

It probably should not be closed
cc @mountiny

@fabioh8010
Copy link
Contributor

@filip-solecki Do you want to lead this replacement of ArrowKeyFocusManager to useArrowKeyFocusManager? 🙂

@hayata-suenaga Could you reopen this issue? Thanks!

@filip-solecki
Copy link
Contributor

Yes, I'll do it, but I am blocked by OptionsSelector as it is not migrated to functional component so I can't use any hook there. I am currently working on removing OptionsSelector from our codebase but it will take some time to replace it with SelectionList as it needs some improvements

@fabioh8010
Copy link
Contributor

@filip-solecki Could you link OptionsSelector issue here?

@filip-solecki
Copy link
Contributor

Sure, here is the blocker

@fabioh8010
Copy link
Contributor

Thanks!

@hayata-suenaga Could we also put this issue on HOLD because of #25125? Thanks!

@hayata-suenaga hayata-suenaga changed the title [TS migration] Migrate 'ArrowKeyFocusManager.js' component to TypeScript [HOLD App Issue #25125] [TS migration] Migrate 'ArrowKeyFocusManager.js' component to TypeScript Mar 25, 2024
@mountiny
Copy link
Contributor

mountiny commented Apr 8, 2024

Closing per here

@mountiny mountiny closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants