[HOLD for payment 2024-06-03] [TS migration] Migrate 'OptionsSelector' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/OptionsSelector/optionsSelectorPropTypes.js	3
src/components/OptionsSelector/index.js	2
src/components/OptionsSelector/index.android.js	2
src/components/OptionsSelector/BaseOptionsSelector.js	18

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[cdOut]

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I would like to work on this task.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[Christinadobrzyn]

Hey @mountiny should there be an internal engineer assigned also? Should it be you or someone else?

[mountiny]

@cdOut from agency is working on this!

[Christinadobrzyn]

we're working on this Melvin!

[AndrewGable]

@cdOut - Can you please make sure to address this TODO item in your PR: https://github.com/Expensify/App/pull/34168/files#diff-29ef0426ea09b0af3420c95911645adcd54c0d3d4c0d8c4fa5aa99dfe37a3646R604 ?

[cdOut]

@cdOut - Can you please make sure to address this TODO item in your PR: https://github.com/Expensify/App/pull/34168/files#diff-29ef0426ea09b0af3420c95911645adcd54c0d3d4c0d8c4fa5aa99dfe37a3646R604 ?

Of course, I will include it in this TS migration.

As a follow up, I am still waiting on this refactor to be finished to start working on migrating OptionsSelector.

[Christinadobrzyn]

monitoring this - #31606 before @cdOut can continue with #25125 (comment)

[s77rt]

@Christinadobrzyn This should be paid only once since it's part of the same issue

[Christinadobrzyn]

it looks like we're working on this draft- #41077

@s77rt, let us know if there's anything else for an update!

[Christinadobrzyn]

monitoring - #41077

[Christinadobrzyn]

monitoring - #41077

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Christinadobrzyn]

monitoring - #41077

[s77rt]

PR is merged. Waiting for next deploy

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Remove 'OptionsSelector' component #41077

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[s77rt]

No regression test needed. Neither a new feature nor a bug.

[Christinadobrzyn]

Payouts due:

• Contributor+: $250 @s77rt (added a second payment to the existing job offer)

Upwork job is here.

[s77rt]

@Christinadobrzyn I think this should be still at $250 total based on the work done.

[Christinadobrzyn]

Ah thanks for the heads up @s77rt - I'll adjust the payment back to $250 in Upwork when I pay this out.

[danieldoglas]

Held on payment.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s77rt paid $250 via Upwork (LINK)
• Contributor: @cdOut is from an agency-contributor and not due payment

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

All paid out based on this summary #25125 (comment)

Closing but let me know if you need anything!