[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168

kubabutkiewicz · 2024-01-09T17:40:45Z

Details

Fixed Issues

$ #25138

Tests

Click FAB Icon
Send Money
Input amount
Select user
Add Description
Edit Description
Toggle Billable
Send

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click FAB Icon
Send Money
Input amount
Select user
Add Description
Edit Description
Toggle Billable
Send

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…s-migration/MoneyRequestConfirmationList/component

src/types/onyx/PolicyTaxRates.ts

src/types/onyx/Policy.ts

src/components/MoneyRequestConfirmationList.tsx

VickyStash · 2024-01-15T09:15:52Z

src/components/MoneyRequestConfirmationList.tsx

+                // eslint-disable-next-line @typescript-eslint/naming-convention
+                onPress={(_event, value) => confirm(value)}


Suggested change

// eslint-disable-next-line @typescript-eslint/naming-convention

onPress={(_event, value) => confirm(value)}

onPress={(event, value) => confirm(value)}

I think this underscore was added for this marking this param as not used so not sure if this will change anything since I think we will still need disable eslint for that line

src/components/MoneyRequestConfirmationList.tsx

…s-migration/MoneyRequestConfirmationList/component

VickyStash

LGTM

VickyStash · 2024-01-17T10:23:08Z

src/components/ConfirmedRoute.tsx

@@ -30,13 +30,13 @@ type ConfirmedRoutePropsOnyxProps = {

 type ConfirmedRouteProps = ConfirmedRoutePropsOnyxProps & {
    /** Transaction that stores the distance request data */
-    transaction: Transaction;
+    transaction: Transaction | undefined;


Suggested change

transaction: Transaction | undefined;

transaction?: Transaction;

…s-migration/MoneyRequestConfirmationList/component

blazejkustra

LGTM

blazejkustra · 2024-01-29T14:13:55Z

src/components/MoneyRequestConfirmationList.tsx

+    bankAccountRoute = '',
+    policyID = '',
+    reportID = '',
+    receiptPath = '',
+    receiptFilename = '',
+    transactionID = '',


If possible let's remove empty strings as default value

…s-migration/MoneyRequestConfirmationList/component

melvin-bot · 2024-01-30T10:01:30Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…s-migration/MoneyRequestConfirmationList/component

hoangzinh · 2024-02-01T15:01:07Z

src/components/MoneyRequestConfirmationList.tsx

+        ? translate('common.tbd')
+        : CurrencyUtils.convertToDisplayString(
+              shouldCalculateDistanceAmount
+                  ? DistanceRequestUtils.getDistanceRequestAmount(distance, mileageRate?.unit ?? CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES, mileageRate?.rate ?? 0)


Could you explain why don't we set default value for mileageRate like previous

App/src/components/MoneyRequestConfirmationList.js

Line 203 in 9ab4fe9

mileageRate: {unit: CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES, rate: 0, currency: 'USD'},

Then we can just use mileageRate.unit here

Right, but when we default value in props for some reason typescript is not detecting that and for example type for mileageRate?.unit is still Unit | undefined

hoangzinh · 2024-02-01T15:03:14Z

src/components/MoneyRequestConfirmationList.tsx

+            return;
+        }
+
+        const amount = DistanceRequestUtils.getDistanceRequestAmount(distance, mileageRate?.unit ?? CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES, mileageRate?.rate ?? 0);


Same question here

#34168 (comment)

src/components/MoneyRequestConfirmationList.tsx

hoangzinh · 2024-02-01T15:17:54Z

src/components/MoneyRequestConfirmationList.tsx

+                    style={[styles.moneyRequestMenuItem, styles.mt2]}
+                    titleStyle={styles.moneyRequestConfirmationAmount}
+                    disabled={didConfirm}
+                    brickRoadIndicator={shouldDisplayFieldError && TransactionUtils.isAmountMissing(transaction ?? null) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}


The previous default value is an empty string, is it a mistake?

App/src/components/MoneyRequestConfirmationList.js

Line 656 in 9ab4fe9

brickRoadIndicator={shouldDisplayFieldError && TransactionUtils.isAmountMissing(transaction) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

no, the type comes from the component and its 'error' | undefined so I just adjusted to match types from a component

hoangzinh · 2024-02-01T15:19:35Z

src/components/MoneyRequestConfirmationList.tsx

+                            }}
+                            disabled={didConfirm}
+                            interactive={!isReadOnly}
+                            brickRoadIndicator={shouldDisplayFieldError && TransactionUtils.isCreatedMissing(transaction ?? null) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}


Same here,

The previous default value is an empty string, is it a mistake?

App/src/components/MoneyRequestConfirmationList.js

Line 702 in 9ab4fe9

brickRoadIndicator={shouldDisplayFieldError && TransactionUtils.isCreatedMissing(transaction) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

#34168 (comment)

…s-migration/MoneyRequestConfirmationList/component

AndrewGable · 2024-02-20T20:38:25Z

src/components/MoneyRequestConfirmationList.tsx

+
+    const receiptData = receiptPath && receiptFilename ? ReceiptUtils.getThumbnailAndImageURIs(transaction ?? null, receiptPath, receiptFilename) : null;
+    return (
+        // @ts-expect-error TODO: Remove this once OptionsSelector (https://github.com/Expensify/App/issues/25125) is migrated to TypeScript.


Do we have a follow up issue for this?

…s-migration/MoneyRequestConfirmationList/component

kubabutkiewicz · 2024-02-21T11:44:54Z

@AndrewGable Yes we have, #25125

AndrewGable · 2024-02-21T18:58:39Z

Thanks - FYI, There are now conflicts.

…s-migration/MoneyRequestConfirmationList/component

kubabutkiewicz · 2024-02-22T11:15:33Z

@AndrewGable conflicts fixed 😄

…s-migration/MoneyRequestConfirmationList/component

roryabraham · 2024-02-27T09:05:01Z

@kubabutkiewicz heads up - lint is failing here

…s-migration/MoneyRequestConfirmationList/component

kubabutkiewicz · 2024-02-27T13:56:55Z

@roryabraham thanks for a heads up, lint check is fixed now

AndrewGable · 2024-02-27T16:51:40Z

@hoangzinh - Do you mind running through the tests again once more? This is an important page to not break, so just want to make sure it's well tested before we merge it.

hoangzinh · 2024-02-28T05:45:10Z

@AndrewGable sure, I will try to test again today

hoangzinh

I tested again. Looks good cc @AndrewGable

OSBotify · 2024-02-28T16:51:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:06:22Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

AndrewGable · 2024-02-29T16:59:48Z

FYI this PR caused too many regressions and we are going to revert it. I'd be happy to review the next PR that addresses these issues.

kubabutkiewicz · 2024-02-29T17:05:04Z

Will work on this tomorrow, sorry ! @AndrewGable

OSBotify · 2024-02-29T23:30:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz added 9 commits January 9, 2024 13:49

ref: started migratiing MoneyRequestConfirmationList

cef767a

ref: keep migrating

d76e0df

ref: wip

e0dc2e9

fix: wip

8946496

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

64f3421

…s-migration/MoneyRequestConfirmationList/component

Update policyCategories type in MoneyRequestConfirmationList

ef6ae5f

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

f00cfe9

…s-migration/MoneyRequestConfirmationList/component

fix: wip

441e437

fix: wip

814715b

VickyStash reviewed Jan 15, 2024

View reviewed changes

kubabutkiewicz added 2 commits January 17, 2024 10:39

fix: resolve comments

e5921ce

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

1c2368b

…s-migration/MoneyRequestConfirmationList/component

VickyStash approved these changes Jan 17, 2024

View reviewed changes

kubabutkiewicz added 2 commits January 18, 2024 13:26

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

5986deb

…s-migration/MoneyRequestConfirmationList/component

fix: typecheck

d851908

blazejkustra approved these changes Jan 29, 2024

View reviewed changes

kubabutkiewicz added 2 commits January 30, 2024 10:45

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

72262ac

…s-migration/MoneyRequestConfirmationList/component

fix: typecheck

d4365b1

kubabutkiewicz marked this pull request as ready for review January 30, 2024 10:01

kubabutkiewicz requested a review from a team as a code owner January 30, 2024 10:01

melvin-bot bot requested review from hoangzinh and removed request for a team January 30, 2024 10:01

kubabutkiewicz added 3 commits January 30, 2024 11:02

fix: remove unnecessary default values

2c030a3

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

5293f54

…s-migration/MoneyRequestConfirmationList/component

fix: typecheck

b037ab9

hoangzinh reviewed Feb 1, 2024

View reviewed changes

kubabutkiewicz added 3 commits February 2, 2024 14:35

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

90cc670

…s-migration/MoneyRequestConfirmationList/component

fix: sync with main

523302c

fix: resolve comments

b8d621e

AndrewGable reviewed Feb 20, 2024

View reviewed changes

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

c5a4bb8

…s-migration/MoneyRequestConfirmationList/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

ef465f9

…s-migration/MoneyRequestConfirmationList/component

kubabutkiewicz added 4 commits February 26, 2024 10:40

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

90a7ad9

…s-migration/MoneyRequestConfirmationList/component

fix: typecheck

479cf7a

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

f1915bc

…s-migration/MoneyRequestConfirmationList/component

fix: typecheck

f17da9e

kubabutkiewicz added 2 commits February 27, 2024 14:51

fix: linter

ad6eff9

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

b953adc

…s-migration/MoneyRequestConfirmationList/component

hoangzinh approved these changes Feb 28, 2024

View reviewed changes

melvin-bot bot requested a review from AndrewGable February 28, 2024 10:23

AndrewGable approved these changes Feb 28, 2024

View reviewed changes

AndrewGable merged commit 636345a into Expensify:main Feb 28, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

youssef-lr mentioned this pull request Feb 29, 2024

IOU-"Enter a merchant name"error shown for amount in split bill scan. #37473

Closed

6 tasks

situchan mentioned this pull request Feb 29, 2024

[HOLD FOR PAYMENT - 2024-03-03] IOU-Billable option is shown in send money confirmation page. #37489

Closed

6 tasks

puneetlath mentioned this pull request Feb 29, 2024

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript" #37529

Merged

melvin-bot bot mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-03-20] [TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #25138

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168

[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168

kubabutkiewicz commented Jan 9, 2024 •

edited

Loading

VickyStash Jan 15, 2024

kubabutkiewicz Jan 17, 2024

VickyStash left a comment

VickyStash Jan 17, 2024

blazejkustra left a comment

blazejkustra Jan 29, 2024

melvin-bot bot commented Jan 30, 2024

hoangzinh Feb 1, 2024

kubabutkiewicz Feb 2, 2024

kubabutkiewicz Feb 2, 2024

hoangzinh Feb 1, 2024

kubabutkiewicz Feb 2, 2024

hoangzinh Feb 1, 2024

kubabutkiewicz Feb 2, 2024

hoangzinh Feb 1, 2024

kubabutkiewicz Feb 2, 2024

AndrewGable Feb 20, 2024

kubabutkiewicz commented Feb 21, 2024

AndrewGable commented Feb 21, 2024

kubabutkiewicz commented Feb 22, 2024

roryabraham commented Feb 27, 2024

kubabutkiewicz commented Feb 27, 2024

AndrewGable commented Feb 27, 2024

hoangzinh commented Feb 28, 2024

hoangzinh left a comment

OSBotify commented Feb 28, 2024

OSBotify commented Feb 29, 2024

AndrewGable commented Feb 29, 2024

kubabutkiewicz commented Feb 29, 2024

OSBotify commented Feb 29, 2024

		// eslint-disable-next-line @typescript-eslint/naming-convention
		onPress={(_event, value) => confirm(value)}

	// eslint-disable-next-line @typescript-eslint/naming-convention
	onPress={(_event, value) => confirm(value)}
	onPress={(event, value) => confirm(value)}

	transaction: Transaction \| undefined;
	transaction?: Transaction;

[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168

[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript #34168

Conversation

kubabutkiewicz commented Jan 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VickyStash left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blazejkustra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kubabutkiewicz commented Feb 21, 2024

AndrewGable commented Feb 21, 2024

kubabutkiewicz commented Feb 22, 2024

roryabraham commented Feb 27, 2024

kubabutkiewicz commented Feb 27, 2024

AndrewGable commented Feb 27, 2024

hoangzinh commented Feb 28, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 28, 2024

OSBotify commented Feb 29, 2024

AndrewGable commented Feb 29, 2024

kubabutkiewicz commented Feb 29, 2024

OSBotify commented Feb 29, 2024

kubabutkiewicz commented Jan 9, 2024 •

edited

Loading