[HOLD FOR PAYMENT - 2024-03-03] IOU-Billable option is shown in send money confirmation page.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.45
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap on a 1:1 report
3. Tap plus icon near compose
4. Tap send money
5. Enter an amount
6. Tap next

Expected Result:

Billable option must not be shown in send money confirmation page.

Actual Result:

Billable option is shown in send money confirmation page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6396704_1709194919343.az_recorder_20240229_130538.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@Julesssss I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #vip-bills.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Billable option is shown in send money confirmation page

What is the root cause of that problem?

We only apply the logical NOT (!) operator for the policy and not case where it is set to true:

App/src/components/MoneyRequestConfirmationList.tsx

Line 262 in 04c8305

const shouldShowBillable = !policy?.disabledFields?.defaultBillable ?? true;

What changes do you think we should make in order to solve the problem?

We should set negation to the whole term:

 const shouldShowBillable = !(policy?.disabledFields?.defaultBillable ?? true); 

What alternative solutions did you explore? (Optional)

N/A

[Julesssss]

Hi @GandalfGwaihir, would you like to submit a PR?

[allgandalf]

PR is up :)

[situchan]

regression from #34168
cc: @kubabutkiewicz @hoangzinh

[Julesssss]

It turns out that many bugs were introduced to this page, so we had to revert the original PR.

@GandalfGwaihir had pretty much completed the PR. Not sure how far @parasharrajat was into the C+ review, but please let me know and we'll figure out a fair payment. Sorry!

[parasharrajat]

It's fine. I don't need payment for this.

[puneetlath]

FYI, this is likely fixed by this revert. Will have QA re-test once it is CP'd.

[allgandalf]

it's alright @Julesssss , I don't need payment, was a simple fix :) not everything is about money :)

[puneetlath]

Looks like the revert fixed this.