Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript" #37529

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript" #37529

merged 1 commit into from
Feb 29, 2024

Conversation

puneetlath
Copy link
Contributor

Reverts #34168

@puneetlath puneetlath marked this pull request as ready for review February 29, 2024 16:58
@puneetlath puneetlath requested a review from a team as a code owner February 29, 2024 16:58
@melvin-bot melvin-bot bot removed the request for review from a team February 29, 2024 16:58
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 29, 2024

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from blimpich February 29, 2024 16:58
@puneetlath
Copy link
Contributor Author

Money requests seem to generally work after the revert.
image

@puneetlath
Copy link
Contributor Author

Going to go ahead and merge without tests passing since it's a straight revert.

@puneetlath puneetlath merged commit 3730ed2 into main Feb 29, 2024
12 of 15 checks passed
@puneetlath puneetlath deleted the revert-34168-ts-migration/MoneyRequestConfirmationList/component branch February 29, 2024 17:04
@melvin-bot melvin-bot bot added the Emergency label Feb 29, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 29, 2024

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor Author

Merged without tests passing because of #37529 (comment)

This was referenced Feb 29, 2024
Closed
Closed
OSBotify pushed a commit that referenced this pull request Feb 29, 2024
@puneetlath @OSBotify
Merge pull request #37529 from Expensify/revert-34168-ts-migration/Mo…
00449ee 
…neyRequestConfirmationList/component

Revert "[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript"

(cherry picked from commit 3730ed2)
This was referenced Feb 29, 2024
Closed
Open
Closed
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
Closed
91 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.45-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@puneetlath puneetlath self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

@blimpich blimpich Awaiting requested review from blimpich

Assignees

@puneetlath puneetlath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puneetlath @OSBotify @AndrewGable