-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU-"Enter a merchant name"error shown for amount in split bill scan. #37473
Comments
Triggered auto assignment to @sonialiap ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @danieldoglas ( |
We think that this bug might be related to #vip-bills |
@danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The merchant error is shown for the amount field. What is the root cause of that problem?This is coming from this commit where we put merchant error for amount error. What changes do you think we should make in order to solve the problem?Revert the commit changes by using the amount error. |
cc @kubabutkiewicz we think this might be coming from your PR #34168 |
taking a look 👀 |
#37515 PR ready @youssef-lr |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
FYI, this is likely fixed by this revert. Will have QA re-test once it is CP'd. |
Looks like the revert fixed this. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Action Performed:
Expected Result:
"Enter an amount"error must be shown for amount in split bill scan.
Actual Result:
"Enter a merchant name"error shown for amount in split bill scan.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6396619_1709183942120.az_recorder_20240229_064940.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: