Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU-"Enter a merchant name"error shown for amount in split bill scan. #37473

Closed
4 of 6 tasks
izarutskaya opened this issue Feb 29, 2024 · 12 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

  1. Launch app
  2. Tal on Workspace chat
  3. Tap plus icon near compose
  4. Tap split bill--- Scan
  5. Using camera upload a photo
  6. Tap split
  7. Open the newly created split scan expense
  8. Note amount field error

Expected Result:

"Enter an amount"error must be shown for amount in split bill scan.

Actual Result:

"Enter a merchant name"error shown for amount in split bill scan.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6396619_1709183942120.az_recorder_20240229_064940.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 29, 2024

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

We think that this bug might be related to #vip-bills

@izarutskaya
Copy link
Author

@danieldoglas I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@bernhardoj
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

The merchant error is shown for the amount field.

What is the root cause of that problem?

This is coming from this commit where we put merchant error for amount error.

What changes do you think we should make in order to solve the problem?

Revert the commit changes by using the amount error.

@youssef-lr
Copy link
Contributor

cc @kubabutkiewicz we think this might be coming from your PR #34168

@kubabutkiewicz
Copy link
Contributor

taking a look 👀

@kubabutkiewicz
Copy link
Contributor

#37515 PR ready @youssef-lr

Copy link

melvin-bot bot commented Feb 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@puneetlath
Copy link
Contributor

FYI, this is likely fixed by this revert. Will have QA re-test once it is CP'd.

@puneetlath
Copy link
Contributor

Looks like the revert fixed this.

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants