[HOLD for payment 2023-09-27] [$1000] Add PrivateNotes pages to allow users to add private notes on report

[techievivek]

High-level of proposed solution

Add a private notes section to the ‘details’ pane of each room and DM to allow all new dot users to collect notes about other users/rooms while messaging customers. Each room and DM will have one, continuous private note. This will save the step of switching apps when taking/referring to notes and encourage users to use NewDot when messaging by making it our source of truth for contact information.

Add a section in details for private notes

We’ll add a section in the details pane with the title ‘Private Notes’. In the Personal Details of a DM, it will fit below the ‘Message ’ section. In the Room Details, it will fit between the ‘Invite’ and ‘Leave Room’ sections. We’ll keep the character limit of 15k we’re currently using for messages to standardize.

Create a single note for each DM and room for each member

Each room and DM will have a single, continuous note for each member. To maintain consistency with other forms and textboxes, we’ll include a ‘Save’ button and allow users to write in markdown.

Ex. In a DM between Ava and Betty, there will be two notes. In a room where Ava, Betty, and Callum are all members, there will be three notes. None of the members will be able to access another member’s note (except in the special situation immediately below).

Allow Team Expensify user and Expensify employees to view notes added by other Team Expensify users

Context in Guides’ private notes will be helpful when a customer gets a new “owner” (e.g. AM steps in after a won deal, Guide steps in after another Guide leaves). Additionally, these notes will be helpful to a Guide’s mentor when catching up on what’s happening in preparation for a call and keeping track of a deal in general.

To give the new owner and/or mentor visibility into the notes for a deal/customer, we’ll allow users with @expensify.com (Mentors) and @team.expensify.com (Guides and AMs) logins to view notes written by @team.expensify.com logins in rooms and DMs they are members of.

Notes for Completeness:

• Each @team.expensify.com login that is a member of a room or DM will show as an entry in the Private Notes section if they’ve added notes.
• Tapping on an entry will show the notes in read-only mode. There will be no option to write/edit other users’ notes.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018981f5d13dbcc635
• Upwork Job ID: 1693596798257332224
• Last Price Increase: 2023-08-21

[techievivek]

Although this is a new feature, we need the help of a C+ member to review it. I am adding the bug label so a bug-zero member can assist with the payment. Thanks

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018981f5d13dbcc635

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

[techievivek]

@sobitneupane, I have a draft PR ready here #25490. Once it's ready for review, I'll ping you. In the meantime, please review the GH description to familiarize yourself with this new feature. Let me know if you have any questions. Thanks.

[strepanier03]

I'll follow along until my action or payment is needed. Feel free to ping me if I miss something I need to do.

[techievivek]

Made some progress today, hoping to get it ready by tomorrow.

[strepanier03]

Thanks @techievivek!

[melvin-bot]

@strepanier03, @sobitneupane, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

[techievivek]

We got this merged today, huge thanks to @sobitneupane for prioritizing this. 🙇

[strepanier03]

Woohoo, thank you @sobitneupane and @techievivek!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add private notes feature to newDot #25761

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - N/A internal report
• Contributor that fixed the issue - N/A fixed internally by @techievivek
• Contributor+ that helped on the issue and/or PR - @sobitneupane $1000 via Manual Requests

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

This is a new feature. So, bugZero checklist is not applicable here.

[sobitneupane]

Regression Test Proposal

1. Login to newDot.
2. Go to any DM/ room chat report details page and you will see an option of private notes page.
3. Click on the private notes page and you will see another option of my note on the next page.
4. Once you clicked on that option you should be able to add notes to your chat report.
5. Verify you are able to add notes in Markdown format and it is rendered in HTML.
6. If you are on an expensify.com domain or team.expensify subdomain then you should be able to view private notes of other team.expensify.com members.

[techievivek]

@sobitneupane Can we create a separate test for the team's expensify to ensure it receives focused attention as they are superusers for this feature?

[techievivek]

I am suggesting a test for it.

[techievivek]

Hmm, they don't have access to any expensify email address or team expensify email address so I think we can just put it in the regression test proposal but they will never be able to test that.

[techievivek]

Ok, just created the issue for adding the new regression tests.

[strepanier03]

Back in office just in time for this to be paid, working on it now.

[strepanier03]

Thank you @techievivek for helping out with the regression test step 🙌

[strepanier03]

Payment summary

• External issue reporter - N/A internal report
• Contributor that fixed the issue - N/A fixed internally by @techievivek
• Contributor+ that helped on the issue and/or PR - @sobitneupane $1000 via Manual Requests

@sobitneupane - Please put in your manual request for payment and I'll assign Jason once you confirm that's done.

[techievivek]

@sobitneupane Did you have a look at the above comment and put a manual request?

[sobitneupane]

Sorry for the delay. I will make the request by the weekend. In the meantime, I think we are good to close this issue.

[techievivek]

Ok, great, thanks.

[sobitneupane]

#25489 (comment)

Requested payment on newDot

[JmillsExpensify]

$1,000 payment approved for @sobitneupane based on BZ summary.