[HOLD for payment 2023-09-20] [$1000] Workspace - Incorrect Behavior When Inviting Existing User with Capitalized Email

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to any workspace
2. Open the "Members" page within the workspace
3. Click the "Invite" button and invite a new user
4. Go back to the "Members" page
5. Attempt to invite the same user again, but this time, capitalize the first letter of the user's email address or write the email address entirely in capital letters
6. Observe the description that is displayed

Expected Result:

The description should clearly state that the user is already a member of the workspace

Actual Result:

Instead of the expected message, it displays "No results found" when inviting the same user with capitalized email letters

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.56-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

CapitalizedInvitation.mp4

Recording.2949.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Habben101

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691797768663379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c78f3bb410f312f
• Upwork Job ID: 1696552547259813888
• Last Price Increase: 2023-08-29
• Automatic offers:
• jjcoffee | Reviewer | 26416348
• Habben101 | Reporter | 26416352

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect Behavior When Inviting Existing User with Capitalized Email

What is the root cause of that problem?

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 187 to 196 in c435734

	const headerMessage = useMemo(() => {
	const searchValue = searchTerm.trim();
	if (!userToInvite && CONST.EXPENSIFY_EMAILS.includes(searchValue)) {
	return translate('messages.errorMessageInvalidEmail');
	}
	if (!userToInvite && excludedUsers.includes(searchValue)) {
	return translate('messages.userIsAlreadyMemberOfWorkspace', {login: searchValue, workspace: policyName});
	}
	return OptionsListUtils.getHeaderMessage(personalDetails.length !== 0, Boolean(userToInvite), searchValue);
	}, [excludedUsers, translate, searchTerm, policyName, userToInvite, personalDetails]);

We don't lowercase the search value before validating it

What changes do you think we should make in order to solve the problem?

we should lowercase searchvalue before validating like this

const searchValue = searchTerm.trim().toLowerCase();

Result

[esh-g]

Proposal

Please re-state the problem

There is a difference of error messages between uppercase and lowercase emails.

What is the root cause of this problem?

We are not converting the searchTerm to lowercase while comparing it to the excluded participants.

App/src/pages/workspace/WorkspaceInvitePage.js

Line 188 in ed2c287

const searchValue = searchTerm.trim();

What changes should be made in order to solve this problem?

We should convert the searchTerm to lowercase before comparing which can be done like this:

const searchValue = searchTerm.trim().toLowerCase();

This is approach is being used in other places as well, so I think we will be consistent in that approach.

App/src/libs/OptionsListUtils.js

Line 638 in ed2c287

const searchValue = parsedPhoneNumber.possible ? parsedPhoneNumber.number.e164 : searchInputValue.toLowerCase();

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Line 420 in ed2c287

const normalizedSearchTerm = searchTerm.toLowerCase().trim().replaceAll(':', '');

What other alternative approach did you explore? (Optional)

None

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emails of workspace members when typed in capital letters in the Invite search input shows 'No results found' instead of showing "user already a member of the workspace"

What is the root cause of that problem?

We are directly matching the trimmed searchTerm without converting it to lower case.

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 187 to 193 in 63d87ba

	const headerMessage = useMemo(() => {
	const searchValue = searchTerm.trim();
	if (!userToInvite && CONST.EXPENSIFY_EMAILS.includes(searchValue)) {
	return translate('messages.errorMessageInvalidEmail');
	}
	if (!userToInvite && excludedUsers.includes(searchValue)) {
	return translate('messages.userIsAlreadyMemberOfWorkspace', {login: searchValue, workspace: policyName});

So already existing emails do not get matched because they are in lower case and the search string includes capital letters.

What changes do you think we should make in order to solve the problem?

We should change this mentioned above

App/src/pages/workspace/WorkspaceInvitePage.js

Line 188 in 63d87ba

const searchValue = searchTerm.trim();

to

const searchValue = searchTerm.trim().toLowerCase();

Now even Expensify emails are matched case-insensitively.

What alternative solutions did you explore? (Optional)

We can instead not convert directly the searchValue to lower case and change it to lower case in the conditionals like this

const searchValue = searchTerm.trim();
if (!userToInvite && CONST.EXPENSIFY_EMAILS.includes(searchValue.toLowerCase())) {
    return translate('messages.errorMessageInvalidEmail');
}
if (!userToInvite && excludedUsers.includes(searchValue.toLowerCase())) {
    return translate('messages.userIsAlreadyMemberOfWorkspace', {login: searchValue, workspace: policyName});
}

Slight difference with this is the header message is shown in the same case as the search value with this solution whereas with the first solution the header message shows the lower case email.

Result

capitalLetterEmailSearchInWorkspaceInvitePage.mov

capitalLetterEmailSearchInWorkspaceInvitePage2.mov

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@muttmuure Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c78f3bb410f312f

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[muttmuure]

Added external

[jjcoffee]

So we've got three duplicate proposals here, all with the correct RCA and solution. @DylanDylann's proposal happens to be the first so we can go with that!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Habben101 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: fix: header message for already invited member of workspace #23490
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: header message for already invited member of workspace #23490 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - checklist item already exists to ensure test steps cover all possible scenarios
• Determine if we should create a regression test for this bug. No - fairly edge case and so not high value enough
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[melvin-bot]

@jjcoffee, @techievivek, @muttmuure, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jjcoffee]

@muttmuure Gentle bump for payment here. Also, I think this may be due the timeliness bonus as it was only delayed due to the merge freeze (see this comment).

[techievivek]

Gentle bump @muttmuure ^

[techievivek]

Gentle bump @muttmuure ^^

[muttmuure]

Getting to this now

[muttmuure]

Offers sent, including urgency bonus

[jjcoffee]

@muttmuure Thanks, offer accepted!

[Habben101]

@muttmuure Thanks, I've accepted the offer.

[techievivek]

@muttmuure are we done with the payment here? Can we close the issue now?

[techievivek]

DMed Matt to look into it.

[muttmuure]

Handling

[muttmuure]

Just waiting on @DylanDylann to accept, then we can close out

[DylanDylann]

@muttmuure I've accepted, thank you!

[muttmuure]

Paid!