Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for payment 2023-09-06] Payment issue for E/App PR#24579 #25720

Closed
melvin-bot bot opened this issue Aug 22, 2023 · 21 comments
Closed

[Hold for payment 2023-09-06] Payment issue for E/App PR#24579 #25720

melvin-bot bot opened this issue Aug 22, 2023 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Issue created to compensate the Contributor+ member for their work on #24579
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/307949.
Contributor+ member who reviewed the PR - @allroundexperts.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0107c793d187d71a7f
  • Upwork Job ID: 1694092657817137152
  • Last Price Increase: 2023-08-22
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Aug 22, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 22, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 22, 2023

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0107c793d187d71a7f

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 22, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 22, 2023

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

@garrettmknight
Copy link
Contributor

PR hasn't been deployed yet, will update the title for the pay date when it deploys.

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@garrettmknight
Copy link
Contributor

Deployed to staging. Will update title/date when it goes to prod.

@garrettmknight
Copy link
Contributor

Huh, this shouldn't be overdue?

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Overdue Daily KSv2 labels Aug 28, 2023
@garrettmknight garrettmknight changed the title Payment issue for E/App PR#24579 [Hold for payment 2023-09-06] Payment issue for E/App PR#24579 Aug 31, 2023
@garrettmknight
Copy link
Contributor

Went to prod yesterday, holding for payment until next week.

@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Aug 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@garrettmknight
Copy link
Contributor

Sorry for the wait @allroundexperts - just sent you an offer.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@garrettmknight
Copy link
Contributor

@allroundexperts
Copy link
Contributor

@garrettmknight No worries. I'm paid through the App. Can you please write a payment summary and I'll request the payment?

@garrettmknight
Copy link
Contributor

Ah, good call.

@garrettmknight
Copy link
Contributor

garrettmknight commented Sep 11, 2023

Summary of payments for this issue:

@allroundexperts
Copy link
Contributor

@garrettmknight I don't think there is an urgency bonus for a PR review.

@garrettmknight
Copy link
Contributor

Thanks for keeping me honest @allroundexperts

@allroundexperts
Copy link
Contributor

Requested payment.

@melvin-bot melvin-bot bot added the Overdue label Sep 22, 2023
@garrettmknight
Copy link
Contributor

Still awaiting payment

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 4, 2023
@garrettmknight
Copy link
Contributor

Still awaiting payment? @allroundexperts

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@allroundexperts
Copy link
Contributor

Yep. Jmills was busy lately it seems. I think he'll handle it today!

@JmillsExpensify
Copy link

$1,000 payment for @allroundexperts approved based on BZ summary.

@garrettmknight
Copy link
Contributor

Cool, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants