Remove policy expense chat beta #24579

Beamanator · 2023-08-15T13:59:39Z

~~Holding on https://github.com/Expensify/Web-Expensify/pull/38506~~

Details

Full plan for removing the beta here (internal link), but basically we have to remove this beta so that we can give conference attendees instant access to workspace chats

Note: I got further confirmation in slack here (public link) that everything is looking good regarding workspace chats so we should be free to make this change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/307949

Tests

Make sure everything with workspace chats is working correctly

Create a new workspace
Verify a new workspace chat is created between you & the workspace admins & that it shows in the LHN

Verify that no errors appear in the JS console

Offline tests

Same as above, these chats should be created optimistically when offline

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-22.at.10.11.51.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-08-15T13:59:44Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2023-08-15T15:10:35Z

FYI this is obviously not quite ready, it's waiting on a few backend PRs 😅

abdulrahuman5196 · 2023-08-16T03:59:05Z

Sure kindly let me know when it's ready I can give a review.

…icyExpenseChatBeta

Beamanator · 2023-08-18T07:34:28Z

Web-E PR is in staging! We can start testing this in staging, but won't merge till the web-e changes are in prod ~~(which should happen soon!)~~ Nevermind, this will happen Monday

Beamanator · 2023-08-18T08:39:43Z

tests/unit/OptionsListUtilsTest.js

+        _.keys(REPORTS).forEach((reportKey) => {
+            if (ReportUtils.shouldDisableWriteActions(REPORTS[reportKey]) || ReportUtils.isExpensifyOnlyParticipantInReport(REPORTS[reportKey])) {
+                return;
+            }
+            filteredReports[reportKey] = REPORTS[reportKey];


we have to filter here b/c we do this in TaskShareDestinationSelectorModal before calling getShareDestinationOptions. So we either do this logic in the test as well, OR we extract this filtering into getShareDestinationOptions

I am not able to understand why we have to do this change? Because getShareDestinationOptions is a separate function not dependent on any component right?

I believe we need the change b/c we currently use getShareDestinationOptions by passing in filtered reports - here:

App/src/pages/tasks/TaskShareDestinationSelectorModal.js

Lines 49 to 60 in 4a7558c

const filteredReports = useMemo(() => {

const reports = {};

_.keys(props.reports).forEach((reportKey) => {

if (ReportUtils.shouldDisableWriteActions(props.reports[reportKey]) || ReportUtils.isExpensifyOnlyParticipantInReport(props.reports[reportKey])) {

return;

}

reports[reportKey] = props.reports[reportKey];

});

return reports;

}, [props.reports]);

const updateOptions = useCallback(() => {

const {recentReports} = OptionsListUtils.getShareDestinationOptions(filteredReports, props.personalDetails, props.betas, searchValue.trim(), [], CONST.EXPENSIFY_EMAILS, true);

So tests were failing when we weren't filtering out archived reports (via `ReportUtils.shouldDisableWriteActions) first

Beamanator · 2023-08-18T09:42:14Z

@abdulrahuman5196 this PR is now ready for review, only on staging! 🙏

abdulrahuman5196 · 2023-08-18T13:14:51Z

Thank you will check on this. Meanwhile the author's checklist is pending. Kindly check on the same

…icyExpenseChatBeta

Beamanator · 2023-08-21T07:40:09Z

Hmm one bug I'm noticing that I think we should fix in another issue after this one:

Screen.Recording.2023-08-21.at.10.39.27.AM.mov

Beamanator · 2023-08-21T13:07:41Z

Ok it looks like ^ is happening b/c we load policyExpenseChat REPORTS when logging in, but not always their report actions 🤔

Beamanator · 2023-08-21T13:30:02Z

Now I'm thinking this is a bigger issue that needs to be tackled before merging this actually

Beamanator · 2023-08-21T14:02:59Z

Starting thread here, to discuss some workspace chat issues: https://expensify.slack.com/archives/C01GTK53T8Q/p1692626420186549

Beamanator · 2023-08-22T07:06:37Z

@abdulrahuman5196 this PR is ready for review now! No longer waiting on backend changes & it seems the "weird states" I found above are all expected / can be fixed elsewhere so no need to make any more changes here, let's get this merged soon!! (following your testing & review of course)

…icyExpenseChatBeta

dylanexpensify · 2023-08-22T08:49:53Z

Wooot! Amazing! Please treat this as your top priority @abdulrahuman5196 🙇‍♂️ 🙏

allroundexperts · 2023-08-22T18:48:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-23.at.1.38.22.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-23.at.1.41.52.AM.mov

Mobile Web - Safari

Screen.Recording.2023-08-23.at.1.42.57.AM.mov

Desktop

Screen.Recording.2023-08-23.at.1.43.51.AM.mov

iOS

Screen.Recording.2023-08-23.at.1.58.35.AM.mov

Android

Screen.Recording.2023-08-23.at.1.57.25.AM.mov

allroundexperts · 2023-08-22T19:53:03Z

Code is looking good to me. Starting the testing now.

allroundexperts

Looks good!

melvin-bot · 2023-08-22T21:02:13Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-08-22T21:02:17Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #25720.

OSBotify · 2023-08-23T05:40:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-24T03:35:35Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:52:23Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:07:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:21:26Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator added 2 commits August 15, 2023 16:58

Remove policyExpenseChat beta

c9e2d65

Update tests

1099600

Beamanator requested a review from a team as a code owner August 15, 2023 13:59

Beamanator self-assigned this Aug 15, 2023

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team August 15, 2023 13:59

Beamanator added 3 commits August 18, 2023 10:03

Merge branch 'main' of github.com:Expensify/App into beaman-removePol…

6db5ae1

…icyExpenseChatBeta

Yeah pretend i remembered to remove that earlier

bbc2cf6

Remove unused betas

c50119e

Beamanator added 2 commits August 18, 2023 10:56

Remove unused var

a65f22e

Fix getShareDestinationsOptions test

093590f

Beamanator commented Aug 18, 2023

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into beaman-removePol…

0364988

…icyExpenseChatBeta

Beamanator changed the title ~~[HOLD Web-E#38506] Remove policy expense chat beta~~ Remove policy expense chat beta Aug 22, 2023

Merge branch 'main' of github.com:Expensify/App into beaman-removePol…

3352cc8

…icyExpenseChatBeta

Beamanator requested a review from cristipaval August 22, 2023 15:05

dylanexpensify requested review from situchan and removed request for abdulrahuman5196 August 22, 2023 15:18

dylanexpensify requested review from allroundexperts and removed request for situchan August 22, 2023 18:48

allroundexperts approved these changes Aug 22, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp August 22, 2023 21:02

melvin-bot bot mentioned this pull request Aug 22, 2023

[Hold for payment 2023-09-06] Payment issue for E/App PR#24579 #25720

Closed

cristipaval approved these changes Aug 23, 2023

View reviewed changes

cristipaval merged commit 4f412db into main Aug 23, 2023

cristipaval deleted the beaman-removePolicyExpenseChatBeta branch August 23, 2023 05:35

OSBotify mentioned this pull request Aug 24, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove policy expense chat beta #24579

Remove policy expense chat beta #24579

Beamanator commented Aug 15, 2023 •

edited

Loading

melvin-bot bot commented Aug 15, 2023

Beamanator commented Aug 15, 2023

abdulrahuman5196 commented Aug 16, 2023

Beamanator commented Aug 18, 2023 •

edited

Loading

Beamanator Aug 18, 2023

abdulrahuman5196 Aug 21, 2023

Beamanator Aug 21, 2023

Beamanator commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 22, 2023

dylanexpensify commented Aug 22, 2023

allroundexperts commented Aug 22, 2023 •

edited

Loading

allroundexperts commented Aug 22, 2023

allroundexperts left a comment

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

OSBotify commented Aug 23, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

	const filteredReports = useMemo(() => {
	const reports = {};
	_.keys(props.reports).forEach((reportKey) => {
	if (ReportUtils.shouldDisableWriteActions(props.reports[reportKey]) \|\| ReportUtils.isExpensifyOnlyParticipantInReport(props.reports[reportKey])) {
	return;
	}
	reports[reportKey] = props.reports[reportKey];
	});
	return reports;
	}, [props.reports]);
	const updateOptions = useCallback(() => {
	const {recentReports} = OptionsListUtils.getShareDestinationOptions(filteredReports, props.personalDetails, props.betas, searchValue.trim(), [], CONST.EXPENSIFY_EMAILS, true);

Remove policy expense chat beta #24579

Remove policy expense chat beta #24579

Conversation

Beamanator commented Aug 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 15, 2023

Beamanator commented Aug 15, 2023

abdulrahuman5196 commented Aug 16, 2023

Beamanator commented Aug 18, 2023 • edited Loading

Beamanator Aug 18, 2023

Choose a reason for hiding this comment

abdulrahuman5196 Aug 21, 2023

Choose a reason for hiding this comment

Beamanator Aug 21, 2023

Choose a reason for hiding this comment

Beamanator commented Aug 18, 2023

abdulrahuman5196 commented Aug 18, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 21, 2023

Beamanator commented Aug 22, 2023

dylanexpensify commented Aug 22, 2023

allroundexperts commented Aug 22, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Aug 22, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

OSBotify commented Aug 23, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

Beamanator commented Aug 15, 2023 •

edited

Loading

Beamanator commented Aug 18, 2023 •

edited

Loading

allroundexperts commented Aug 22, 2023 •

edited

Loading