Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for mWeb Download App Banner #25820

Closed
grgia opened this issue Aug 24, 2023 · 7 comments
Closed

Clean up for mWeb Download App Banner #25820

grgia opened this issue Aug 24, 2023 · 7 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Aug 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Feature Added here - #25418

Clean up points:

  • Remove blue outline on mWeb
  • Add AppIcon to Expensicons
  • Change shouldStackButtons to use Flex order
  • fix downloadAppModal key capitalization in en.js / es.js
  • if the banner is dismissed it doesn't reappear on sign-out - only after refresh (only affects Android Chrome).
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170b9f8d80a16cdaf
  • Upwork Job ID: 1694645507289415680
  • Last Price Increase: 2023-08-24
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Aug 24, 2023
@grgia grgia self-assigned this Aug 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0170b9f8d80a16cdaf

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@grgia grgia mentioned this issue Aug 24, 2023
77 tasks
@grgia grgia assigned jjcoffee and unassigned mananjadhav Aug 24, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 24, 2023

@mananjadhav sorry for the ping, assigning @jjcoffee as they have context from the original PR!

@dylanexpensify
Copy link
Contributor

@grgia mind if we get an update on this?

@grgia
Copy link
Contributor Author

grgia commented Sep 14, 2023

@dylanexpensify this is code clean up and lower priority. Do we have an issue for replacing this with smart banners?

@dylanexpensify
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants